Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp571578pxb; Tue, 15 Feb 2022 22:27:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJy3P6z8U/xzytcOYZayvmU6zBOZiWxeRCWgcNZUn16hs4OQI65Xfe+/m5I0x4GkBAiXJD70 X-Received: by 2002:a63:6c83:0:b0:364:5899:a34b with SMTP id h125-20020a636c83000000b003645899a34bmr1079980pgc.47.1644992861084; Tue, 15 Feb 2022 22:27:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644992861; cv=none; d=google.com; s=arc-20160816; b=yRm+j8Z5H2FI0RCOW9FG+nwWODaPAU0+TCyFAB9olOe97VrAzsIiKkcC/7yD8rMN5P xKzdj7i7ucqL4j9spkiLe5CSwU/WAKZn8v3FTsGuD9vQLFpJQdti/6kLyeszeyXaiFSy t0vGa9e89pUkoHzQGF/BUQNq//mc2iKwZWV5eNZhtnfSq4tCyoVJipa+y8F0/QD0cAu0 Nu9a4SQtzrYfZsYWkHtZldKFZ4tqICaBzGzSCaWYXACkJgprDtUqq5aXMjEHULKOvod9 ER/jvJVi2CaNN940G5Lx63ikvoTE6iAumYUlDeZoQCgWFLIV8Ry0XxSO6wj759mnE4jJ bwiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=2IOPzjnWd8EjziAtZYTS8knf64b+omTdunkNR62RvLo=; b=PER0oib1YzEj3wpCuwZ9DnVia4VAd3pYLzjVK2pmBRlM6JieeGJTME82ZqYfkLw2Gc fUnQfwpXW9IL8H2FfqFNqF5Jk98lKSOgpZ45tUCbRdw7AoWZ0YukQ7aBK5q5F7ggZL/H 92qv866K5GX23fjO/FtV/KdjU0ZQWFpJ+CMg/YVLAuo6ZQyZ5mPuBYZn7yn/TF8rW/Rg IwJfht9BqTjLm1N3sg4+pNZhCebMSL///FmEZ1U0ndA+P7/n+Ne1STcxeOtXGrh9EAgZ dEqpIniBoO6kXihm9I6OLBR/6w45bHR2aUvOFhhYKOPDplQhCCve4Cy+X89k3VUt9an+ Qf/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=rock-chips.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id i1si16479353plr.524.2022.02.15.22.27.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 22:27:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=rock-chips.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 96E4C1DA43; Tue, 15 Feb 2022 22:21:56 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237746AbiBPBlW (ORCPT + 99 others); Tue, 15 Feb 2022 20:41:22 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:44368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245579AbiBPBkt (ORCPT ); Tue, 15 Feb 2022 20:40:49 -0500 Received: from mail-m17640.qiye.163.com (mail-m17640.qiye.163.com [59.111.176.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54116237F9; Tue, 15 Feb 2022 17:40:38 -0800 (PST) Received: from localhost.localdomain (unknown [58.22.7.114]) by mail-m17640.qiye.163.com (Hmail) with ESMTPA id 50A6454032D; Wed, 16 Feb 2022 09:40:36 +0800 (CST) From: Jon Lin To: broonie@kernel.org Cc: heiko@sntech.de, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jon Lin Subject: [PATCH v3 6/6] spi: rockchip: clear interrupt status in error handler Date: Wed, 16 Feb 2022 09:40:28 +0800 Message-Id: <20220216014028.8123-7-jon.lin@rock-chips.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220216014028.8123-1-jon.lin@rock-chips.com> References: <20220216014028.8123-1-jon.lin@rock-chips.com> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWRpMSx5WS0wfQ0NDGEpMTB keVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWVVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Ohw6OSo5Fz5IEhYMPg0zGRcz IRgaCihVSlVKTU9PQkxOTUhNTENJVTMWGhIXVREUFVUXEhU7CRQYEFYYExILCFUYFBZFWVdZEgtZ QVlOQ1VJSVVMVUpKT1lXWQgBWUFJS01DNwY+ X-HM-Tid: 0a7f0030400ad995kuws50a6454032d X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SORBS_WEB, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The interrupt status bit of the previous error data transmition will affect the next operation and cause continuous SPI transmission failure. Signed-off-by: Jon Lin --- Changes in v3: None Changes in v2: None Changes in v1: None drivers/spi/spi-rockchip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index 8b4d56ee2193..cdc16eecaf6b 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -278,8 +278,9 @@ static void rockchip_spi_handle_err(struct spi_controller *ctlr, */ spi_enable_chip(rs, false); - /* make sure all interrupts are masked */ + /* make sure all interrupts are masked and status cleared */ writel_relaxed(0, rs->regs + ROCKCHIP_SPI_IMR); + writel_relaxed(0xffffffff, rs->regs + ROCKCHIP_SPI_ICR); if (atomic_read(&rs->state) & TXDMA) dmaengine_terminate_async(ctlr->dma_tx); -- 2.17.1