Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     "trix@redhat.com" <trix@redhat.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "nathan@kernel.org" <nathan@kernel.org>,
        "ndesaulniers@google.com" <ndesaulniers@google.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "llvm@lists.linux.dev" <llvm@lists.linux.dev>
Subject: Re: [PATCH] dpaa2-switch: fix default return of
 dpaa2_switch_flower_parse_mirror_key
Thread-Topic: [PATCH] dpaa2-switch: fix default return of
 dpaa2_switch_flower_parse_mirror_key
Thread-Index: AQHYIblgcwa2mr3+1UqnRzNxN8McnayUgTuA
Date:   Tue, 15 Feb 2022 11:51:18 +0000
Message-ID: <20220215115117.zz56xxvymbntumvi@skbuf>
References: <20220214154139.2891275-1-trix@redhat.com>
In-Reply-To: <20220214154139.2891275-1-trix@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?K5BgCHSqii7a34O2ZePzS08Sr/dMHtbSzwB7GANFMCcAG3MNnslXHTSd9lqo?=
 =?us-ascii?Q?MNBDx/XBD24l3/1szYOarLwc5Tk14lluj1Yms6CAiFKY+1mVUi30CyFYSfTf?=
 =?us-ascii?Q?kEb2iL/zVA8isqK1iJPhXMjXVY8jOA7HDdb1sfJPKsOdSa89YW3uKCcZFNA0?=
 =?us-ascii?Q?JFfIbyuNrKCK0VeC1slQs5c8Db/o5NVYB4XTpBCowmjtrwFdX1mC4OkTR3Bh?=
 =?us-ascii?Q?hwL29EqcNh6QSig5TGSBoKEnYJqgExmydY9da7aT593Ce2g0FxkpkQYs0eMk?=
 =?us-ascii?Q?HQLO+Fli1q77d1azK0ZnTv+mDVpLpuQoN5YBp777yUh2ROOp8Pk3hb8xtX/O?=
 =?us-ascii?Q?ThLPeuzX0pns8K90IC/q4TsTmWPyFBEu/V+OERIznnAoNQiwdKX+8suZIcrc?=
 =?us-ascii?Q?IODvcj7IPsubBdLbOoN/0IyzQ9DfdmwLkm7L4pfKac9N92b3yDSeZgefuzMF?=
 =?us-ascii?Q?T7VRPBLiYqVZPeKhnmdzp7OOpEX07NtTVz/3EK5jnwopPXf/2JXVfG2/g07t?=
 =?us-ascii?Q?4eoRbT/tzs8IP+TY8CT/kOUzk1nWWGZWQvEn6A9ELH6gDzxHB3d2/68Mdp7Y?=
 =?us-ascii?Q?TWj8WLkUBYsG/QNsXtmi3lbcIot7ccQFTQrWJOxWI1jivNtF5DdaKR1vRsan?=
 =?us-ascii?Q?SzPuztx/L11VBxfkzTW2wx0KJqveDxndZWGeSAdgJNF/Ge4GT9LjCV26Jy8h?=
 =?us-ascii?Q?hYY2jRp5bRM7eNB/LgD1QLVbI8rLbCnWByJ6yk5ti0rWlw62tIILpcDeA+DE?=
 =?us-ascii?Q?uwUCrWNnVBihzTqdzx/T6oxTLjFJ5lFx/M0+AcAunb3K5wknNPK6K8TCepll?=
 =?us-ascii?Q?DU8uoUxPcJVYpZGx13unt6zOngL+yfR2+NNK0YEeSxHMCt+v8f8MuWjMuu7F?=
 =?us-ascii?Q?YH01p4UzNFdXY/kYPRcbL2K5m7tnEJThQU6x9mQGwTFuWdbIJOTJzA52Xz9T?=
 =?us-ascii?Q?+n8lFfLD8rDfOP7Y8yTVMp8uRumJdsk3aBuKazrMqiQUHxd8FZYLbb6lP9Ub?=
 =?us-ascii?Q?vfmQoXgvpB72fp8xRUm83UDMO5aICo4+42n3BkRmMsJE/onO2uHyVYsbnorZ?=
 =?us-ascii?Q?3kh2Zh77lrZvQ18/g4CIcew9ANn8tSO/lVGhjXQH1MZmsZDu99hlNgUA66tL?=
 =?us-ascii?Q?nk+ZWgozUbNrQdz7Pr4HT50uqykgNTrP6L3C85yEj6bwTl304MGr8AcGHCER?=
 =?us-ascii?Q?Li2eX/QntnilOHP2ZFHNwlopBhEz4PTMRAaBB70l5Gy42paLZ3/z+4LNwrsB?=
 =?us-ascii?Q?BNOWEsGoXdqRYRne36YhYvOOFuUoLagCF8kHJSSlQk13xZDhA7P47/2vk/mj?=
 =?us-ascii?Q?nafl9vSFVKd+qGKIvrnvmqusGxHnAw2jhQSPfJc4pRandOcnjHDL6Ww2HBdE?=
 =?us-ascii?Q?xISi0cgq3dB3njTqhFdYIabRuYT7vXZAZxjrKa6sngUzMAqx/ZP57IYHUH5e?=
 =?us-ascii?Q?UtlXI5R72Iso1fgAEcwkoPxAWTDuD81HhTsuoJ14NCyAHtWWLm9HnPLHFLXQ?=
 =?us-ascii?Q?1oNXlDwUe3xpSCgr4U/JVAfh5e7QpqCIoU/YioUuTuH2JOExaCcEmO48oLtD?=
 =?us-ascii?Q?gKzAyncKyTSoJpDixjLqgML4hhTfVgcK2NT0Tx0RjDooir1MEKTLrx8KfIzJ?=
 =?us-ascii?Q?l+FLbRu+HE7KcvPEeo0yZ0w=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <89082DB9BEA00E499CFD3141C238E8F3@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8555.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41573e99-fb4c-4fa6-a623-08d9f0797a9b
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 11:51:18.7428
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XrulDJF++XEXZtUHGe8rkRjjI20hkfViyS37bsOYwIo126aXjOE2G6ZOsGWAdW/2MRSHTLFfs1fyPbxtLOI8FA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2705
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 14, 2022 at 07:41:39AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>=20
> Clang static analysis reports this representative problem
> dpaa2-switch-flower.c:616:24: warning: The right operand of '=3D=3D'
>   is a garbage value
>   tmp->cfg.vlan_id =3D=3D vlan) {
>                    ^  ~~~~
> vlan is set in dpaa2_switch_flower_parse_mirror_key(). However
> this function can return success without setting vlan.  So
> change the default return to -EOPNOTSUPP.
>=20
> Fixes: 0f3faece5808 ("dpaa2-switch: add VLAN based mirroring")
> Signed-off-by: Tom Rix <trix@redhat.com>


Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>

Thanks!