Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp581679pxb; Tue, 15 Feb 2022 22:48:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJwlujHI4T1TQVQAStTpZembvtRbd5/n/9EOCPfe5trwKljDywnIQPUju3tupRFX/BcOv130 X-Received: by 2002:a17:902:c951:b0:14d:c2bf:659 with SMTP id i17-20020a170902c95100b0014dc2bf0659mr1141689pla.95.1644994123354; Tue, 15 Feb 2022 22:48:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644994123; cv=none; d=google.com; s=arc-20160816; b=rK9i+Wrs1DNJ1oI4Vo/y2xDMiVZOtzVlKd4mOnoC/2/j+ZV5gDf1MVsrPEXWcr+BIK OC3hb/5h1QE2De8hYbLgKG7+pATUjQN4OQRHhGVSuINp1OZESrEFguUjQZsuljCG96E9 U9JT9Bj70vHQ2ZU9CRyMRSsz5QE0zjgmOEyVUTokNp5YIaSMVUkat44BUbgi4A+t2oDp 3cLPoflTWir9MBdQNUgLR2jgBwyfuAvVoOW7wMNTIqMt85F+hBKtSRuaOHS2ea5BgsuT gucz8V6Bh7svcfc3VeDfBKeNMaLOwWJD9NMgNCBLazP0YWngkyASSKmxaqqfS61oouR4 PBuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=ZkxmGx+RhSXUnTtiHYBk2oBZBIvoHSGA9RtJEh+QZbo=; b=WxxKAYT2JWUbsKWzh3S+R088dyKd2YKfXCDOUc38aKx9vELoc4RJKbeh4AzG9XQ3Mf X1eJeCeLTZ3eUVIGk4EfjJFdsZqPnxQhdwgHgHeConss2O8wSVlqfK8Q24aFL3xZvdvJ pEzLzf7y+3TQc1BoFG4vSVoV+eI0eeYnfOYqoH8FV/FRSKCcixVGz4wXlMw1YsITuQEb V6kdYvFlxbQklV6OU5S56TfRk/Y9v+cO8A3GgQt6169YqL1GaLR3lX/a89IGwuZYxJbD gRCI1Dn7snK1Qwth6d+f+3/6sgYpUYQA/VUi/TaeDN/XbZTL08Fy2S5/zb6nsXShHTa2 64qA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id a15si4999046pgp.549.2022.02.15.22.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 22:48:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 84CB020D35A; Tue, 15 Feb 2022 22:34:56 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234849AbiBOIDl (ORCPT + 99 others); Tue, 15 Feb 2022 03:03:41 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:33788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231487AbiBOIDk (ORCPT ); Tue, 15 Feb 2022 03:03:40 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6B7A26574; Tue, 15 Feb 2022 00:03:29 -0800 (PST) Received: from fraeml744-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4JyYVf56Pvz6F92f; Tue, 15 Feb 2022 16:03:06 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml744-chm.china.huawei.com (10.206.15.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Feb 2022 09:03:28 +0100 Received: from [10.47.81.62] (10.47.81.62) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.21; Tue, 15 Feb 2022 08:03:27 +0000 Message-ID: Date: Tue, 15 Feb 2022 08:03:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH -next] scsi: hisi_sas: Remove unnecessary print function dev_err() To: Yang Li , CC: , , , Abaci Robot References: <20220215020524.44268-1-yang.lee@linux.alibaba.com> From: John Garry In-Reply-To: <20220215020524.44268-1-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.81.62] X-ClientProxiedBy: lhreml703-chm.china.huawei.com (10.201.108.52) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/02/2022 02:05, Yang Li wrote: > The print function dev_err() is redundant because platform_get_irq() > already prints an error. > > Eliminate the follow coccicheck warnings: > ./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1661:3-10: line 1661 is > redundant because platform_get_irq() already prints an error > ./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1642:4-11: line 1642 is > redundant because platform_get_irq() already prints an error > ./drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1679:3-10: line 1679 is > redundant because platform_get_irq() already prints an error > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Acked-by: John Garry