Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <1644917065-23168-1-git-send-email-hammerh0314@gmail.com>
 <1644917065-23168-2-git-send-email-hammerh0314@gmail.com> <b50bf9ef-eb38-8e86-70f9-7a9a959be67b@canonical.com>
In-Reply-To: <b50bf9ef-eb38-8e86-70f9-7a9a959be67b@canonical.com>
From:   hammer hsieh <hammerh0314@gmail.com>
Date:   Wed, 16 Feb 2022 09:51:21 +0800
Message-ID: <CAOX-t55+_AE9eKf3OwRb1pos7gZZBa1xVV7EXAEMDQ2mm5VS0Q@mail.gmail.com>
Subject: Re: [PATCH v8 1/2] dt-bindings:serial:Add bindings doc for Sunplus
 SoC UART Driver
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Greg KH <gregkh@linuxfoundation.org>, robh+dt@kernel.org,
        linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>,
        p.zabel@pengutronix.de, wells.lu@sunplus.com,
        "hammer.hsieh" <hammer.hsieh@sunplus.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> =E6=96=BC 2022=E5=
=B9=B42=E6=9C=8815=E6=97=A5
=E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=8810:53=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On 15/02/2022 10:24, Hammer Hsieh wrote:
> > Add bindings doc for Sunplus SoC UART Driver
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Hammer Hsieh <hammerh0314@gmail.com>
> > ---
> > Changes in v8:
> >  - no change.
> >
> >  .../bindings/serial/sunplus,sp7021-uart.yaml       | 56 ++++++++++++++=
++++++++
> >  MAINTAINERS                                        |  5 ++
> >  2 files changed, 61 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/serial/sunplus,sp=
7021-uart.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/serial/sunplus,sp7021-ua=
rt.yaml b/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
> > new file mode 100644
> > index 0000000..894324c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
> > @@ -0,0 +1,56 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (C) Sunplus Co., Ltd. 2021
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/serial/sunplus,sp7021-uart.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Sunplus SoC SP7021 UART Controller Device Tree Bindings
> > +
> > +maintainers:
> > +  - Hammer Hsieh <hammerh0314@gmail.com>
> > +
> > +allOf:
> > +  - $ref: serial.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: sunplus,sp7021-uart
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  resets:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - resets
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    aliases {
> > +            serial0 =3D &uart0;
>
> Incorrect indentation. With this fixed:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
>
> Best regards,
> Krzysztof

OK, will modify it. Thanks.

Regards,
Hammer