Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp585432pxb; Tue, 15 Feb 2022 22:56:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQ1Tpg/0XTd8WhViWm4P42YjQm4aDVTBdkF85hatz1Qq+qLkyyazaoFtdmccintgHEWDqk X-Received: by 2002:a17:90b:4a11:b0:1b9:9685:eea4 with SMTP id kk17-20020a17090b4a1100b001b99685eea4mr197651pjb.136.1644994590543; Tue, 15 Feb 2022 22:56:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644994590; cv=none; d=google.com; s=arc-20160816; b=n7hI4v7bhivrDG+zVR8Alx0DhQFctcITz+Sx/bmqdGsRnNXjBs1RUfToubmdNYYiSe 4avJw3eRpRQSz+eAuXd4ejkkDoTC3VI6HbTmGzgNpIdsyCa9Aeq5Tah+Z+w1itJ+uP7p J/k4dr6k74+Jm27ATxTyRkjHofk981n1refiYciVnKCKN43fpU2mmQIpD0UV11FIBGmW bKHgmG6lVfUjiesmx3v6jeJVhvKyCBxZxl3fg725kXq5HIXgMB5nQTFroA2Z+43RhahQ 1dqXY8SlJA7qZnnwtB/wvMsovLhVA9qqjt+4c3jW3xByaNN1PKe1zjt+3Mc3IYSDvkJA HhsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=XXedcp2yhbUzo3O92znwEibtv2eEO56xS91b3yWI2ys=; b=PwILlzaeVKFA+0C5X+V8wMY66vgFwYyesYb+Scx7zV+JvR3Vbh+mCc4rG9y4RPnQB7 uy0VU20oaarmD4n5Nma4V1U54AGJjj8YUmm0U+cdWm55GO5liQ4zr0IcSJb47oZxCk4U csdUG3KwORu0mv0Et70o7UDrONZhyp1ZEiBfVgkMbd24lu0Tzqt2xqgrqmu0aIz3nKxz ooX7c6Jej1Xbm3mun4B99O0vmHG9O6VNDGXR7UoMVM55uiccs3z/qtsqZ9NhuarufmPA gZ2cAd7Cg0i14iOpkHZvywe1Gc5oKKY3UTkDHsOzwFxdLlW+Cnsux8uF3u40zVMtI/En tP7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=0ZBGtyXp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id h17si3708791pgb.824.2022.02.15.22.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 22:56:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=0ZBGtyXp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B88261A76F3; Tue, 15 Feb 2022 22:38:47 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244316AbiBOVO2 (ORCPT + 99 others); Tue, 15 Feb 2022 16:14:28 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:44282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236566AbiBOVO2 (ORCPT ); Tue, 15 Feb 2022 16:14:28 -0500 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B99487E09E for ; Tue, 15 Feb 2022 13:14:17 -0800 (PST) Received: by mail-io1-xd36.google.com with SMTP id r8so3174458ioc.8 for ; Tue, 15 Feb 2022 13:14:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=XXedcp2yhbUzo3O92znwEibtv2eEO56xS91b3yWI2ys=; b=0ZBGtyXpprvtwB02Ug9plwdlXTZcNgMbVrrfq+GoCMWZsFy4kMhFPR7Ik6GYKsdWWm 8apaMiJqABQECCkZYmE9EiOcpwvPr/is8h0+UHwGOiQP+w2GavCXrykeRgJ3xVqO+tha /A+W/eXYZmW49+PRRnIzK0IUMHotFOGZHJv1EOQT749nDlTZyVsROay0wxzG5KdxVcni lCifbH5uZtwvXmI9r1oCfmotaVmTwcLQniKLwKT2Lz11TZ/G9p4iUjmeAewQJoAwU7b4 wz60283Of2U+JnK2Hh6lvdOPr36mjlvJe6PwKH3+NbchhhoCL3VoaCJBt3PA7t/EjDlB bYoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=XXedcp2yhbUzo3O92znwEibtv2eEO56xS91b3yWI2ys=; b=Ve/h1Md+5XhBUFZu6T2HHoTHHcUXc/mZHPsdKzYZxbKiJZ3kS2VPA3wMbApQSwygqH 4H5nbTAayObungRfTU4ka67oH5NfXlnf/KUBNyaL+g/p8X2a0bPtZWZhnXH3Q9AA3/Yf KkBTs97FLs0Cjp0C5wJKFkHmW32Knkk5Uh7wKiCRl3FDlICxRbUUEDADi3y/GPzMprVS P7qPL5MtfE0zQMROPzjLZzOVjAT4JrHxYOVOeS+DAXKpCQf8zT5UIFP4dXTvj5KljUTp 5x8Gw+Kzs66xtu/w4RCtNvwiMGLKJznsLOUm6dBcrHYpsIfOkADNwsP5JYrstpRWYrbe eatQ== X-Gm-Message-State: AOAM530FxD5X/ZoEMAendq0f+xaCudCiLRUxbHNUpOSfWcG4j+fQpuoP QrKLZoOyz6ameYv6PRNEcjmv5Q== X-Received: by 2002:a05:6602:168c:: with SMTP id s12mr486266iow.100.1644959657041; Tue, 15 Feb 2022 13:14:17 -0800 (PST) Received: from m1.localdomain ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id b6sm23928798ioz.43.2022.02.15.13.14.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 13:14:16 -0800 (PST) From: Jens Axboe To: tj@kernel.org, Chengming Zhou , boris@bur.io Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20220213085902.88884-1-zhouchengming@bytedance.com> References: <20220213085902.88884-1-zhouchengming@bytedance.com> Subject: Re: [PATCH] blk-cgroup: set blkg iostat after percpu stat aggregation Message-Id: <164495965641.2684.16928611518978800084.b4-ty@kernel.dk> Date: Tue, 15 Feb 2022 14:14:16 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 13 Feb 2022 16:59:02 +0800, Chengming Zhou wrote: > Don't need to do blkg_iostat_set for top blkg iostat on each CPU, > so move it after percpu stat aggregation. > > Applied, thanks! [1/1] blk-cgroup: set blkg iostat after percpu stat aggregation commit: f122d103b564e5fb7c82de902c6f8f6cbdf50ec9 Best regards, -- Jens Axboe