Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
IronPort-SDR: 6gBjHwVCpkApe48hHj/iFMfucg9Pth6iyV9NCeLdL0MdgnuZbmfm9jgXS2ds+V6YZCbaZ4N8mu
 SlljFNCModLk/J2smHjqWmIlgIJSpDnPNBWg2wOKhS/LgsZH7YHKbplFg/XX1cotLXCNOqiLxJ
 52KpWTzMh7bIB9fgNak+IeutUj06ofoamdxdLAQyql2T3fgld5aJOAnFoDwavSxqB2Ot5LMbeB
 wqcgY+lC37fDP+xFoA5fBDjeapRNw45M8BbXp6fR7zFrJm6kglKm+o1xSc7NXxRDVtScqEqyCW
 8UuNmQRwN80u4/NmVjEgNfjG
From:   Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
To:     Fenghua Yu <fenghua.yu@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Shuah Khan <shuah@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        tan.shaopeng@jp.fujitsu.com
Subject: [PATCH v3 4/5] selftests/resctrl: Change the default limited time to 120 seconds
Date:   Wed, 16 Feb 2022 11:26:40 +0900
Message-Id: <20220216022641.2998318-5-tan.shaopeng@jp.fujitsu.com>
In-Reply-To: <20220216022641.2998318-1-tan.shaopeng@jp.fujitsu.com>
References: <20220216022641.2998318-1-tan.shaopeng@jp.fujitsu.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

When testing on a Intel(R) Xeon(R) Gold 6254 CPU @ 3.10GHz the resctrl
selftests fail due to timeout after exceeding the default time limit of
45 seconds. On this system the test takes about 68 seconds. 
Since the failing test by default accesses a fixed size of memory, the
execution time should not vary significantly between different environment.
A new default of 120 seconds should be sufficient yet easy to customize
with the introduction of the "settings" file for reference.

Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
---
From the perspective of the kselftest framework,
a rule of "Don't take too long" is a concern.
To get some better informed opinions from kselftest audience,
I highlighted this change in the cover letter.

I adopted most of Reinette's phrase from the discussion in patch v2
to explain why 120s is appropriate for this test.

 tools/testing/selftests/resctrl/settings | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 tools/testing/selftests/resctrl/settings

diff --git a/tools/testing/selftests/resctrl/settings b/tools/testing/selftests/resctrl/settings
new file mode 100644
index 000000000000..6091b45d226b
--- /dev/null
+++ b/tools/testing/selftests/resctrl/settings
@@ -0,0 +1 @@
+timeout=120
-- 
2.27.0