Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Wu, Hao" <hao.wu@intel.com>
To:     "Zhang, Tianfei" <tianfei.zhang@intel.com>,
        "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "Xu, Yilun" <yilun.xu@intel.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "corbet@lwn.net" <corbet@lwn.net>
Subject: Re: [PATCH v1 2/7] fpga: dfl: check feature type before parse irq
 info
Thread-Topic: [PATCH v1 2/7] fpga: dfl: check feature type before parse irq
 info
Thread-Index: AQHYIZYugBgIM3QaCEG59dx30/kn36yVbrFg
Date:   Wed, 16 Feb 2022 03:35:25 +0000
Message-ID: <DM6PR11MB38193BEA6566608EACAAB87785359@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <20220214112619.219761-1-tianfei.zhang@intel.com>
 <20220214112619.219761-3-tianfei.zhang@intel.com>
In-Reply-To: <20220214112619.219761-3-tianfei.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.200.16
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tXcUKTivFSPj4k8XaCw07OcleSEF6W4g2XjBaCNeBLGpUKOIPr//MaGZBYTf?=
 =?us-ascii?Q?8YcjUUdyuC87GWOTaf8r4Amf/RkBDcbRDVdh8QtouCSYypU+RnBbvJjCmBkA?=
 =?us-ascii?Q?ZEPSWiczXlk4llJSFreV6KioVyViVobpxO3dihtGPp9eywZi7sCNT8iPtdmb?=
 =?us-ascii?Q?vsWBywWeFqWO4B1Mtu5qAhYHRrj2T1FY3S2rlFC6p5mMHj8Fb0AZ/ow935JP?=
 =?us-ascii?Q?ia7T78gTYLtBfUdj5makt5uByvskexReKzNEn7OPOkH1Fy+9GeDkdfwav62W?=
 =?us-ascii?Q?JLU8D09n4IsLO8rZFA/rXAgmxMdTUMZCe/KHDKxdRU1fiP2f3qLT8BDsVeu5?=
 =?us-ascii?Q?3TB/eoRlaIw4TOvfPrivZD0QtqgUTRIhPhPJfNyFHhgcuOIXVihAqgabg8Mh?=
 =?us-ascii?Q?/Vp+zK4EK6B1j/5WATDiVhcC+XsmecCbfgSrFr+YXSGf4OAZHcrhSRXQPF1o?=
 =?us-ascii?Q?relU8F4zoIiPcP0eltBb1EWgD6Io+8RMUG+RwPQ+gyqNueThTzVi4omY69pa?=
 =?us-ascii?Q?XoxM9AmZmb2Z2wXkZQZIoIMfHiarLbljO4xSlFvfob8H4JOOE8ZMQPNHFg20?=
 =?us-ascii?Q?J7O75aCX0rzAoPKnBe5ka+GOLowMUw7b4Hh9SVyTkl9t1/DJYj1y/Lv4jdb6?=
 =?us-ascii?Q?/HVg71cka5nkgjnnJfUfekTG8EqfHgAnzjXiTYjm3SiEGaTbD2KJOFiCpNEg?=
 =?us-ascii?Q?8hLembJprNRNkU+UkPeeNq5p/7q2njw5vSLIZsHEBxeOzNf862TmgYQoQ1TF?=
 =?us-ascii?Q?jjjJMMtW8hQYo6GPS20yDtn1AgczPkfcz1TvNLVljj3tDR8ynEBfrbSFQt91?=
 =?us-ascii?Q?YghD3bm0H6HuKtn621VfDy0l1sHwdgWXqZigTiqKmSYnVRRMrcoTpxskhcPh?=
 =?us-ascii?Q?GB1+lSW7FmKoY6BBBr8cwaBuzS4Q97m5bq0QAeEDHZfy/XHjQDaC/yKn88D9?=
 =?us-ascii?Q?w6nSVFKRt3iQPmR4cKY2Wkyz7QIwTmwURrDsXMf+SbEBChzAUCU5KZgUestE?=
 =?us-ascii?Q?G73rs1wYcwVxKTbvYQkAFR855yQ4WTFbBHWHHeJh6H9JKrhTtiTyo7Fb0pIb?=
 =?us-ascii?Q?yA/Go+8FY3XnndOZ6IioSlA6NCaEeo/1aaVHF0fAOBbTA7LcSy62JP+lnZpV?=
 =?us-ascii?Q?JhC1o1BAjWAqYXpB6p+1+ShizY02hHnxAVM9sftwAzPIcK4xW5S/JpYzXj+y?=
 =?us-ascii?Q?+j915mt5cm2BqNMgrBI4YI23vPZrJums5ixSMmJutg18gK+iTMluxrCUQryg?=
 =?us-ascii?Q?PbfbkjqUImHdbvGLJs7GSHhR4v/yDb88MXvBfHJ47xRdeFXOYcLTLnuflJu4?=
 =?us-ascii?Q?ksyxcd9UyporuJqMP0N6V5roXJHCZIrAGtjSbLMm3KFAElngDC5/1MzkHKuc?=
 =?us-ascii?Q?AET7vzn6ONsRdiMKpjimt1sp8CTzT9KzadGiexhPyTgt4smxhihHWYgTL6XD?=
 =?us-ascii?Q?OqaYQvuxj+ingyS468YJxO+etM15t7y2wmr3Uk6hs8VDIdIJE/eDy+w7vV2K?=
 =?us-ascii?Q?8mH02FpeXnIgN5aSKoz5689vnXdejEDbG/zf9Kw3/xywUQI5QQrb2bFJ/zK5?=
 =?us-ascii?Q?WsQHvBATBovHCpesEnYoxhgHgXCDTVX83Lv7Gc6w1G/omdWoFOZjyfEsjX+L?=
 =?us-ascii?Q?KnfcvzGvUcXl6bznW+BEZ00=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a73116b5-dd1d-475f-a3c1-08d9f0fd5efa
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2022 03:35:25.9574
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: p7za+ijY3GIMhXrAEk/NZw3Uh6y4txrx/H6Wb3+lece4Hh9Cv5/l8ySF2dyuBuXIDhWFUKdXluHrQbUHzYkrFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1625
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH v1 2/7] fpga: dfl: check feature type before parse irq in=
fo
>=20
> From: Tianfei Zhang <tianfei.zhang@intel.com>
>=20
> The feature ID of "Port User Interrupt" and the
> "PMCI Subsystem" are identical, 0x12, but one is for FME,
> other is for Port. It should check the feature type While
> parsing the irq info in parse_feature_irqs().
>=20
> Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> ---
>  drivers/fpga/dfl.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>=20
> diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c
> index 599bb21d86af..26f8cf890700 100644
> --- a/drivers/fpga/dfl.c
> +++ b/drivers/fpga/dfl.c
> @@ -940,9 +940,14 @@ static int parse_feature_irqs(struct
> build_feature_devs_info *binfo,
>  {
>  	void __iomem *base =3D binfo->ioaddr + ofst;
>  	unsigned int i, ibase, inr =3D 0;
> +	enum dfl_id_type type;
>  	int virq;
>  	u64 v;
>=20
> +	type =3D feature_dev_id_type(binfo->feature_dev);
> +	if (type >=3D DFL_ID_MAX)
> +		return -EINVAL;
> +

You don't have to check this, it doesn't allow creating feature dev with ty=
pe >=3D DFL_ID_MAX.

>  	/*
>  	 * Ideally DFL framework should only read info from DFL header, but
>  	 * current version DFL only provides mmio resources information for
> @@ -959,16 +964,22 @@ static int parse_feature_irqs(struct
> build_feature_devs_info *binfo,
>  	 */
>  	switch (fid) {
>  	case PORT_FEATURE_ID_UINT:
> +		if (type !=3D PORT_ID)
> +			break;
>  		v =3D readq(base + PORT_UINT_CAP);
>  		ibase =3D FIELD_GET(PORT_UINT_CAP_FST_VECT, v);
>  		inr =3D FIELD_GET(PORT_UINT_CAP_INT_NUM, v);
>  		break;
>  	case PORT_FEATURE_ID_ERROR:
> +		if (type !=3D PORT_ID)
> +			break;
>  		v =3D readq(base + PORT_ERROR_CAP);
>  		ibase =3D FIELD_GET(PORT_ERROR_CAP_INT_VECT, v);
>  		inr =3D FIELD_GET(PORT_ERROR_CAP_SUPP_INT, v);
>  		break;
>  	case FME_FEATURE_ID_GLOBAL_ERR:
> +		if (type !=3D FME_ID)
> +			break;
>  		v =3D readq(base + FME_ERROR_CAP);
>  		ibase =3D FIELD_GET(FME_ERROR_CAP_INT_VECT, v);
>  		inr =3D FIELD_GET(FME_ERROR_CAP_SUPP_INT, v);
> --
> 2.17.1