Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <35be6c0b-e6a8-d0f1-1870-6a77a18556c7@amd.com>
Date:   Tue, 15 Feb 2022 19:01:16 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] drm/amdkfd: Replace zero-length array with flexible-array
 member
Content-Language: en-US
To:     cgel.zte@gmail.com
Cc:     airlied@linux.ie, Zeal Robot <zealci@zte.com.cn>,
        Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org,
        amd-gfx@lists.freedesktop.org,
        Changcheng Deng <deng.changcheng@zte.com.cn>,
        dri-devel@lists.freedesktop.org, alexander.deucher@amd.com,
        christian.koenig@amd.com
References: <20220215091142.1775600-1-deng.changcheng@zte.com.cn>
From:   Felix Kuehling <felix.kuehling@amd.com>
Organization: AMD Inc.
In-Reply-To: <20220215091142.1775600-1-deng.changcheng@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NERqVVlhM2tiZ1Z5UVBpb0x1QVZyb214bGVobmhaWUVkSDZQMUMwQkVrVDBC?=
 =?utf-8?B?MnJTTzZSbU9LYkNCZ0ZIUjVFdFcra0h6LzRkM0pKaFdnRkN3OXlMcXUyMkdB?=
 =?utf-8?B?T21ZRDJBRzErVUhLMEJRMlYrMzJOZ0JuWk81MFBMTVBZMFhlVHZlTk1yL0NW?=
 =?utf-8?B?REw4dDdrUFBFbFVDQ0F0M2FSL0hJYVhEczVIUjRKc2g4bk5UOUFOSU1Fdkla?=
 =?utf-8?B?Nmdjc1hjaFdnWWxiT2tIdXUvM2xCZ1M5MEN5dHRIUk4zMHB6WEpnYnpOTzUz?=
 =?utf-8?B?cnZ1NTJ3RXEzTWhoQWpaOHk3QytNZmNvK2VGNVNDRjdMeXJOOTk0djdvVGVj?=
 =?utf-8?B?V0Zsbm5KZHU3WkM3U0NpV3p0QlozZ3JRTkxyaFFLMnpwdFlvNjgvSzZ4c3dW?=
 =?utf-8?B?Y25wUkFINXE1aUxuZDcwRjJsa0dzTC9sdkdnUEJxRzZUcWNDRzVrcEJUZE8w?=
 =?utf-8?B?elM2cVBxbkZBOWdZZ3AwOHd1V0RIVEVSeDV1eEJMVXVGRVljYUdlOVo0d1Bx?=
 =?utf-8?B?b29oUENUd3Q5bXdNUDVoYk9IOEluTm1nRXFSbVFYZ3JQRWVoTzZUdWo3S2I1?=
 =?utf-8?B?N1B1ODBsNEt2WHFKTWZPRHlzVDhaMVUza2dpMEhaNFA2QVBERnhucFdrNTNw?=
 =?utf-8?B?RGx0eFBCNFAwOGtoWWRLRDNQWXN4eEZzOURMb00xK1FEYVZPbTRrRXFLWGJx?=
 =?utf-8?B?MXU0MmUwajlPalZ2WXNoak10SmpHcmtRWk9Kak5ST2ZnY1FnUzhaVy9Hakd2?=
 =?utf-8?B?MXFqaUU0RVIwT3dLa0ZKV3N3SmF5NDgyRVRDVVRScDlobmdneFV2OS9GdWZK?=
 =?utf-8?B?TW5scCsyMjVzZXdubWFhajUydEhlRm5Qd2Y2Y01SV25vU1prazdUTnZrS1o1?=
 =?utf-8?B?NkRFaVVCaVVBVGpDODdZRytVRDhyYlNUdFJiVEN6aXkrbHBMZzFvN0pJdmlK?=
 =?utf-8?B?alFFdWNyalFmeWRKUk43WisybERXb0hLdjdCYUpoNkIyMUN1V3E1RFVLSU1q?=
 =?utf-8?B?OUZQNStmR2NYcXd1M0JGRU1Ob1VWd0Q4ek90a1cyNEpMVWtoRmxObjhFOHZm?=
 =?utf-8?B?Mm1PTnNRTm01N2NuNHVQRmNZNDAxSUp3R3c5NTZGdS9IWFljQzdaSmxMRjBr?=
 =?utf-8?B?TG85MXhwanJUZTIxOVVWQytJeTJabzFLandhSUt3TjlaaTJKRDFMUUhGeEVI?=
 =?utf-8?B?Q1BlZSs2MFRqQndVRm4wTHgrYWl4d3Nwd1hXZXlSckJMMHBlSWlQZzBXYk1i?=
 =?utf-8?B?d3BqYm9LOW9qdVp5bDV6YnVyQ0RwaGRCQmhHYWhQUTJVcDRkMU5pNGR2K0pN?=
 =?utf-8?B?VktqRWtHNGFmakUyTVdvME43U0pBaTRueEdjYXNMQ0ZoR3JhZkNRenBYNkls?=
 =?utf-8?B?N0M5bnFxRHA1N3dsTUY4aEROU2RyREZwc0dlak1odUsrL2VEb1RSRzFmZ0FS?=
 =?utf-8?B?QWVlUmlzUTFVOU9UbnlJU3Q4N1R3SWpVLzR1MUIwN2lCdFF6WXVvalM4ektJ?=
 =?utf-8?B?cUJrUXVSK3h1MWZ3Z2orRnV2Wmw3UU03VmE0emplajBqSWdBbGNtMTBhdk44?=
 =?utf-8?B?QkpnNXEwQ3FrYXJ2Y0Y5SGVyeThrWGdRRW42OFhxRlRxMnBUSnNGSmVKbWxX?=
 =?utf-8?B?WTg0M0ZUc0ZqVkM5QnNOaS8weXVRa3RHNjdmOFZ3ckZyc2dYZTRIR3JCbFN2?=
 =?utf-8?B?V1hqVlhwWU9IVVczeC8vTFN3MEgzMlcreVgwMDhLWkxTa3dQcVYwMi9ZSzZH?=
 =?utf-8?B?UDBvWG4xcTJqeXlmRUVnalNlbXU5czVIaC92RU1jcjEzelZHcXQxQW1td3h4?=
 =?utf-8?B?bW9jV01TUGxvOU9VclJtalVJYTI3REtka1RHNXZ3MW44V1U1dndaZHVDNjYy?=
 =?utf-8?B?UHJ6M01XQVY1R1A1UEtUTG9xQzJHRUpXa2JCc1l0Qk1RUXVvckVTeUlRRnFK?=
 =?utf-8?B?bFVqeFd3akpKamh3ei8vRjZWS0pkUjJlclRZZGNSTWI0aGZhalRoWFgwYUNJ?=
 =?utf-8?B?a1VzL3hqekwrYTdwQnN5enJLMGhZS0JwOXUwcFlFSkcwTmhQbzQxWGV2a201?=
 =?utf-8?B?bmpUSCt2Q251bXF3R044N2h6dXVBWlNocTVDeFd0ZmZxRVlmVXVRSVdJR2I3?=
 =?utf-8?B?dVpFOVNEbkZEQmRNbzF0dE9IRDJYOFVsUUMxRFF1c3ZjYXRIZ3NGQVp6OVM0?=
 =?utf-8?Q?u/ms4ODY4ktKls8dAZv691M=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa516f59-8256-475c-f585-08d9f0df74c4
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 00:01:18.8178
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3ksYuX0+/KYaPDvLjM14h3iZ1MIHvHxpWeUfXuBhhMX11raMn+gvb4CDTFiJVQlAt//Q0TeLfRLusAMHR8GvKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4138
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-02-15 04:11, cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> There is a regular need in the kernel to provide a way to declare having
> a dynamically sized set of trailing elements in a structure. Kernel code
> should always use "flexible array members" for these cases. The older
> style of one-element or zero-length arrays should no longer be used.
> Reference:
> https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>

Makes sense. I'm applying this patch to amd-staging-drm-next.

I also found a similar issue in include/uapi/linux/kfd_ioctl.h. I'll 
send another patch to fix that as well.

Regards,
   Felix


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
> index e54a52785690..7d39191d13f6 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
> @@ -1084,7 +1084,7 @@ struct kfd_criu_svm_range_priv_data {
>   	uint64_t start_addr;
>   	uint64_t size;
>   	/* Variable length array of attributes */
> -	struct kfd_ioctl_svm_attribute attrs[0];
> +	struct kfd_ioctl_svm_attribute attrs[];
>   };
>   
>   struct kfd_criu_queue_priv_data {