Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp602159pxb; Tue, 15 Feb 2022 23:26:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJydVACn1SnaT+/OJIuZgvRId216Nykff1C2572ZRrDf33RD6bbV5wkjG28ARU1ZLDhtfAPt X-Received: by 2002:a63:4b47:0:b0:372:e449:5d95 with SMTP id k7-20020a634b47000000b00372e4495d95mr1171823pgl.387.1644996403685; Tue, 15 Feb 2022 23:26:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644996403; cv=none; d=google.com; s=arc-20160816; b=mcj96qP5PCn2nAkTzzIkiV5a0WJjpuE/cXdbDxRHZqhNuWDVYgL7PuMeZhANia434d gqQNF5qib31Ta/7JSmfbl0Ej0RiDtoqNbO64LXSZL+4Q925Mb21qfkgjCz2GQYjDt3OM JrZvjlPg8Y0pDILh4CeLSWEMwoDve9Y8QkOVvyR6J5GE4EgOKdxkoLFr634JifD1TVYf SJo39RNVxncKSu4LcZQUivLY4j8Fb01SaqF7n3LdLtr3reHT8GMewu6/UmZsJx041th+ 9GcsJSVZd95uuD7wj+6d8VfiXxyrghcQ1U1teFxSgLmbjy5VbtPTBiikgS1J1oLpAwzT H7sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=7vZVv1ogxeGB/tMAdmK5at+J4W8ez8n3jP7SjDQ5qgg=; b=OxfJVhtR3yp4+jWWl43O/vFd2avz1cd1NO/gXw8/fAlb55+R6xTkUtK4treo1rZ/LR Vo0KZ8BgbZjAQtr/6o7Ry5tQyTMM0NaY/Tknt23kdGtswjsJcQ4nIqnmslvW7R27Ujr2 HUQ+q8KaNokgjA4KnRpKjE8w1kQkm7KzXBbXUUOqiTvbstOukg+omvOi9g2WWDXPol3S pxkEiiyoySEUFwYHeL5SJQ+5/V+ERtvoPVfNK0fqpE+Mhnh06+4Vwo5aqAJYgma/ispe cCE5oIuasdXomX0E17pa9E+29NaowxqSGpwfU2W5X5t9xI8UhRBhbBiT3z/eodt/et7v USsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20210112.gappssmtp.com header.s=20210112 header.b=cMc473IC; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id e19si21094854pfv.219.2022.02.15.23.26.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 23:26:43 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20210112.gappssmtp.com header.s=20210112 header.b=cMc473IC; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A944628D38F; Tue, 15 Feb 2022 22:54:53 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245538AbiBPBiA (ORCPT + 99 others); Tue, 15 Feb 2022 20:38:00 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241056AbiBPBh7 (ORCPT ); Tue, 15 Feb 2022 20:37:59 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED79F19C29 for ; Tue, 15 Feb 2022 17:37:46 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id m7so1131552pjk.0 for ; Tue, 15 Feb 2022 17:37:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7vZVv1ogxeGB/tMAdmK5at+J4W8ez8n3jP7SjDQ5qgg=; b=cMc473ICFpscrz6Kg2TEINUfuiiCr7n79NNtBniP8KGkOAF9b9J6ETkih1Hf2OjAaY zra7/J1LRD1WVCT266kbSOhNePQTQlSfBQLJZxrHOBeKJGQTbkktK4afhTx62f9qaxUt M3bS42hVoqOTo+uWBcluZdMV2jxZLwDujKeQj034WXVqpgt0IyZn1+CxFAH7VvntEie7 NERFRXNHElKR54xfwdMvbtorHfsJcITMYqzhJ/9/IL3SNbXXflV/aIJBKhjKQFEFApQ7 RGyj8lNGy2O9KfPT9ksA0Nr0Xxft2xo3mbl4FQaPh8pNq66yD3XEDCxjjKAu4dHCbhFh ZxHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7vZVv1ogxeGB/tMAdmK5at+J4W8ez8n3jP7SjDQ5qgg=; b=ML08dJkSvut3WcLlx0gpOIFXES8LDqex+qL66Cee1lSJ1tyBY9pyI4m/iVQ4pl/6Ov tke66eCdzuOgRvFzOHMCHgB5mBEJ6u0niglahljwxI5H06OZXlqjK+xay+HtORIKzAq3 RUZSIj91HyB/UbZA2vZFq5ciDfvcH9qfl/8Kb7dHanBhchZi/KSb1wuKDQj4eMPjX8nU ZjAY0RX8pO2c9ixfWcMaXA2XaKhhtCBtZvaE9EgVnB92FwR7qCpj48bzblEGU+I6/VEU EaLjctjW/Tl8fVtGIzv0rilIYUpdOzlUSpl5SuL7xOYAglTvwalSIETtfUVywaAPcidC qEAA== X-Gm-Message-State: AOAM531Llgo0V84P5k7fOC+yh+BqHSwjsefS4UIOK+C67FhTLbY6rx7w 6X1/xP1s6xia10a15DwieQhuKU2xH4wY+04oRSNAtA== X-Received: by 2002:a17:90a:f28d:b0:1b9:975f:1a9f with SMTP id fs13-20020a17090af28d00b001b9975f1a9fmr265331pjb.220.1644975466504; Tue, 15 Feb 2022 17:37:46 -0800 (PST) MIME-Version: 1.0 References: <20220127124058.1172422-1-ruansy.fnst@fujitsu.com> <20220127124058.1172422-7-ruansy.fnst@fujitsu.com> In-Reply-To: <20220127124058.1172422-7-ruansy.fnst@fujitsu.com> From: Dan Williams Date: Tue, 15 Feb 2022 17:37:40 -0800 Message-ID: Subject: Re: [PATCH v10 6/9] mm: move pgoff_address() to vma_pgoff_address() To: Shiyang Ruan Cc: Linux Kernel Mailing List , linux-xfs , Linux NVDIMM , Linux MM , linux-fsdevel , "Darrick J. Wong" , david , Christoph Hellwig , Jane Chu , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2022 at 4:41 AM Shiyang Ruan wrote: > > Since it is not a DAX-specific function, move it into mm and rename it > to be a generic helper. > > Signed-off-by: Shiyang Ruan > Reviewed-by: Christoph Hellwig Looks ok to me. Reviewed-by: Dan Williams