Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 15 Feb 2022 18:58:39 -0800
From:   Guru Das Srinagesh <quic_gurus@quicinc.com>
To:     Satya Priya <quic_c_skakit@quicinc.com>
CC:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Das Srinagesh <gurus@codeaurora.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <swboyd@chromium.org>,
        <quic_collinsd@quicinc.com>, <quic_subbaram@quicinc.com>,
        <quic_jprakash@quicinc.com>
Subject: Re: [PATCH V6 3/6] mfd: pm8008: Add mfd cell struct to register LDOs
Message-ID: <20220216025839.GA28938@hu-gurus-sd.qualcomm.com>
References: <1644915231-7308-1-git-send-email-quic_c_skakit@quicinc.com>
 <1644915231-7308-4-git-send-email-quic_c_skakit@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1644915231-7308-4-git-send-email-quic_c_skakit@quicinc.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Tue, Feb 15, 2022 at 02:23:48PM +0530, Satya Priya wrote:
>  static const struct of_device_id pm8008_match[] = {
> -	{ .compatible = "qcom,pm8008", },
> -	{ },
> +	{ .compatible = "qcom,pm8008", .data = (void *)PM8008_INFRA},
> +	{ .compatible = "qcom,pm8008-regulators", .data = (void *)PM8008_REGULATORS},

Typo perhaps: Please set the last element of this array to the sentinel value NULL.
        {},

>  };
> +MODULE_DEVICE_TABLE(of, pm8008_match)

Missing a semicolon at the end.

>  
>  static struct i2c_driver pm8008_mfd_driver = {
>  	.driver = {