Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp603804pxb; Tue, 15 Feb 2022 23:29:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJzCvKE22hbSMWeaaeGXiYTaU2fBv3aOW7zOHaEok4NPsVMW1oCqeDJtCM6Er+RHQnQhnLc4 X-Received: by 2002:a17:903:244d:b0:14b:2c5f:b278 with SMTP id l13-20020a170903244d00b0014b2c5fb278mr1136939pls.13.1644996588230; Tue, 15 Feb 2022 23:29:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644996588; cv=none; d=google.com; s=arc-20160816; b=sQ0RORmQBiYxE/n/F2341E0ywXX6EbezXXpIu+CaTVdreQ++sfML7fLON9nygkNYTH iUHZbWbcnaqiQDe3QPe8lP7dQiZeLLl0n9tftCbiODjnu1Cp6A3xhp8B41a5oqvGmzEe pscrLaURZuIhSDJSqBoKUFw4xzr+VSYPxa08nlazCUmceNFbegsdJasr7kgPKa3a1Mmm QEVQHflDx39eWNUkCUGTXHqkKOU32OGySjxWinssWFFe0kKIQehmRdeV0bM2+d4TmsPm pu4m/69ghA68VeFdS4PrWLdxEbd/d4N4sgBTeUbVoxEMjVVF19Y7F6Q94yC3q9IpEmmu IcWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=vvTayVguxhrumT3w+R+Kjfmd3diECndIkorPQyxblp0=; b=mDF3nEEBaPTQjKppl59/XMU+A75MrlVSP+e3YB0JMEr4f1Yjd9Idoj0JQ4blrzRTQu lvMadzR8VB8EXrzThbHM6/4dXciFM6B6n+rHOor0Toasytqv+OKu6OWBJtNEANmthbps pzPg5gPIZJnIhCNqE9LYcg6crm4g8LnlkwVjYbe162xRVMA4M/Y9i98ml2M1YYEkL3ms 8rDhtgQZQ1lY71bK4QB9ARKNua4vUe+AbtvsCdfzunseAOw74bSZJmWN1ekppcsHkMXc tW1QuWDwiDHYsWzmuyfU79pSFADRoVs/OSsxh5qQBCUSm8eyOOUKU8rEgOqBMzLmXsxs HrZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20210112.gappssmtp.com header.s=20210112 header.b=NFjoQ+hO; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id b21si15840709pls.288.2022.02.15.23.29.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 23:29:48 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20210112.gappssmtp.com header.s=20210112 header.b=NFjoQ+hO; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5E254295FFA; Tue, 15 Feb 2022 22:57:22 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245487AbiBPBee (ORCPT + 99 others); Tue, 15 Feb 2022 20:34:34 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245496AbiBPBeb (ORCPT ); Tue, 15 Feb 2022 20:34:31 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19546F70DA for ; Tue, 15 Feb 2022 17:34:20 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id d187so834349pfa.10 for ; Tue, 15 Feb 2022 17:34:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vvTayVguxhrumT3w+R+Kjfmd3diECndIkorPQyxblp0=; b=NFjoQ+hOdtNnkcduj0LnOAfr0t13qJU0g+H3qDYhxHXNY2kSOBhjJ57id3nggkZ63z bd+0no5Sz1hfOpOM7FqU7/lcj3mw/zA9iIJGXn1/3gABVkhTJwDuVFXiLCiF+AoiAuvP xzHa0AMAlBDyRB3g8rVKOe7JL6peWAms2JmtnTljT+4i1CykaarkkcY2Phufrs+l4f98 tIBmQaYCJwnUN4p1EvcyxZr3Y2TIDezPhrxlygMSyqcqJutwde5Wmrbzs8FUsbjeBtAE KAXJkvUlQ4SnUi7Ml0QZWal8mO29LLZbB5qS5ZaYGR1b1d2ZM10qVKD8leaATzhRe6MQ OvXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vvTayVguxhrumT3w+R+Kjfmd3diECndIkorPQyxblp0=; b=JQdzTvwh8joUvLCAgD+5Jm/VzMuraDI2XTMNTXA/VTE8PLYTZkFeqY/6vlazkp7RXX cImee9UbdXvtBT6FeKbtpCZooRtyHPjZWQis0B7kxPUSYUwt0oZjycKDlMA84e5e3LYu es9C0zzwu8Fsrz96B7/ZqZlpjGbc1jZ8aB309wSTOqZVHZBU/adlX2v+5BUj2aOKBElM P3t/7yytiqEKTX8dj36CJLT5Z5YDgoFreu8Jf+ILFLyIIqnyBk0uNd+xBxWHbQtx3lCe dqcXY4KcGDxCUB4wAUo1TI0+s8bHjoOJBikwp8s5tX0nCfV2+hkm/Qh2GlGHFSIRM+gr il1g== X-Gm-Message-State: AOAM533Qc+//BwLjb/sQBbT6kIiXkIkbqBc122bNezne4g3rb6sT1Hdy rqFTexwc45GzH/SmOuT7neMqVCn+Kqjy2kx4n1VxQw== X-Received: by 2002:a05:6a02:283:b0:342:703e:1434 with SMTP id bk3-20020a056a02028300b00342703e1434mr370669pgb.74.1644975259581; Tue, 15 Feb 2022 17:34:19 -0800 (PST) MIME-Version: 1.0 References: <20220127124058.1172422-1-ruansy.fnst@fujitsu.com> <20220127124058.1172422-6-ruansy.fnst@fujitsu.com> In-Reply-To: <20220127124058.1172422-6-ruansy.fnst@fujitsu.com> From: Dan Williams Date: Tue, 15 Feb 2022 17:34:12 -0800 Message-ID: Subject: Re: [PATCH v10 5/9] fsdax: Introduce dax_load_page() To: Shiyang Ruan Cc: Linux Kernel Mailing List , linux-xfs , Linux NVDIMM , Linux MM , linux-fsdevel , "Darrick J. Wong" , david , Christoph Hellwig , Jane Chu , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2022 at 4:41 AM Shiyang Ruan wrote: > > The current dax_lock_page() locks dax entry by obtaining mapping and > index in page. To support 1-to-N RMAP in NVDIMM, we need a new function > to lock a specific dax entry I do not see a call to dax_lock_entry() in this function, what keeps this lookup valid after xas_unlock_irq()?