Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp604042pxb; Tue, 15 Feb 2022 23:30:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJzjll2ojFAq+5yvjlH5TBYuiBvCjzS8CTCzb1DBRuCsdIt/7Y8AF8sm1XQCj4ncHfV16wUS X-Received: by 2002:a17:90b:310:b0:1b5:677a:3383 with SMTP id ay16-20020a17090b031000b001b5677a3383mr280244pjb.187.1644996619937; Tue, 15 Feb 2022 23:30:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644996619; cv=none; d=google.com; s=arc-20160816; b=Eng+tjFLDFd7SSzTO+lCZBD75myST+f2OtSs2ZNaOXwIsQR3qDJzoOkIyYLIWh5oY0 LsotBByOUE8k3k5mELF+6ZOiccx83fiH1XMMfK2NinOrEK7uVTfqfgqVTUV1E+E1DCc3 jOPXypm21p4kUqHJltpHc7EnCuc3qW9ARkJgW458dcv5jW5V6O1mtC55Tm/PUAejqPP/ 3f7H/4o06C0KNGCVvcQuSSPJrqW6z1nVfI3rU/L2NlZBEF1eqE4fDO3kbESPvL2thcLb C49PpgUMMRYGC21rbPowcoUb6geFZThMNrbDjpxa2D1mtYx/guzwqNgcqAG2YMuHzfR5 +fGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:mime-version:message-id:date :dkim-signature; bh=JgRTlFw8++kyf5ZSG/NEY0qnd4+2DMvg2lXX0xsMQJI=; b=UT/ombSMtl0IxLjLmdjTeMWlloADJEnIy7IjredVAqgexvkt3xmbtMSuj3ZKZgJVFx TAKCi89UIFBrh1zDCqznVcjUxN1HQ455kLNlQRQQumV7VaKjneJCzRlqd//1kPSwpath bw+VE7Wxb7smOPizHr8xIkXzmJXNm6Gxs7gJb7RftI3fdTPXYrHyu1k3Nc5i+/Ap4nh9 zmEt1VYrAenl25uyDQ6IeKcUfi7rhXBbEkHjCsw1kRDO+g7RIZOiJAZ+zZ+J0u9jkP5D 1hdpqh/69rDHq+Xsy2S/sUY6QyMKLXeWdJXOk/qypPOnUEtQuKO7tCujN1+iXBoFmaSu VYRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="VG2vcH/t"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 81si5490676pgb.678.2022.02.15.23.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 23:30:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="VG2vcH/t"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D84B4294136; Tue, 15 Feb 2022 22:57:53 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344377AbiBPEhG (ORCPT + 99 others); Tue, 15 Feb 2022 23:37:06 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:51686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232657AbiBPEhF (ORCPT ); Tue, 15 Feb 2022 23:37:05 -0500 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C325EBBAD for ; Tue, 15 Feb 2022 20:36:51 -0800 (PST) Received: by mail-pj1-x104a.google.com with SMTP id f2-20020a17090a4a8200b001b7dac53bd6so721575pjh.4 for ; Tue, 15 Feb 2022 20:36:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=JgRTlFw8++kyf5ZSG/NEY0qnd4+2DMvg2lXX0xsMQJI=; b=VG2vcH/tSu2S3ORYoluC8fi+F9edyN/vKsOjZx3LCLD6vaDPIfMq5ziR5ni6kEZADU T92YVumGy29n+opxo8wtrWzxX3ACAo26qUDE0ISQffyaFtl4AO5KkjwNZetm3H9dsOeN KfRA1KMhyn6ek9jVfuns3icvtU48qSCBBiqZ+59/539bA2w4O4+fwEjQW/3KTE5Vv61C kc73NWY1WxnWU2B51rNCAvpLqt8kbdgmGcmfhLfMBJqUyUVw0VGY/k6CwVkYXLfOd4Ul 2HolZa0jVrRri93aZs2bnWL3aArfG5NuOY7wBUOkP9xapZgRnmpZYM2qAoWyysMBwoZH EGCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=JgRTlFw8++kyf5ZSG/NEY0qnd4+2DMvg2lXX0xsMQJI=; b=zyaagTAINKAg7CHCRtPgnOe8UMTFbP8qfTEIA/hp1ahoIvh0WewsIXVU7+nZIS92Hs YjSu+T5ahdt5oPDZmHqEj+42wl1YpP9OtxgIz2Pm/az3JkEZJSG81a4SnF2KDaxIkUcs jJblcwtLZPZnkvEjCLvl2g1xSMjoGsxcQbr4NzPB3NsBdQ2TBwVpRyGEF9KxS546T7jJ MPPnU0RLS4nilVS+iGHmmIpQ56ThRh757j/ttIWGzsHur/SKuCMGvToK2DX2Me6JQkoY FNfGBhD2lUSw/+C19/z45aX9pM71EQmZwKKnL22gggiTKg7Obay95Q7VW+JAZ+PsibC5 g2wg== X-Gm-Message-State: AOAM532Z74Bqlw/sN1xKeRC0EmKiOGxO94GnRbX51Kytf9qK32gav/+A VU6zKwIWujHZhgUi9knJo4RxslQK3DJC X-Received: from tzungbi-z840.tpe.corp.google.com ([2401:fa00:1:10:8ce7:5b2:9787:1a0b]) (user=tzungbi job=sendgmr) by 2002:a62:8c44:0:b0:4c4:8072:e588 with SMTP id m65-20020a628c44000000b004c48072e588mr1244438pfd.11.1644986210942; Tue, 15 Feb 2022 20:36:50 -0800 (PST) Date: Wed, 16 Feb 2022 12:36:34 +0800 Message-Id: <20220216043639.3839185-1-tzungbi@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.35.1.265.g69c8d7142f-goog Subject: [PATCH v4 0/5] platform/chrome: cros_ec: miscellaneous cleanups From: Tzung-Bi Shih To: bleung@chromium.org, groeck@chromium.org Cc: chrome-platform@lists.linux.dev, tzungbi@google.com, pmalani@chromium.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The 1st patch fixes unhandled undos in error handling path. The rest of patches cleans drivers/platform/chrome/cros_ec.c. Changes from v3: (https://patchwork.kernel.org/project/chrome-platform/cover/20220209095703.517608-1-tzungbi@google.com/) - Drop "platform/chrome: cros_ec: don't initialize `err` in cros_ec_register()". - Rename the 3rd patch's title. Changes from v2: (https://patchwork.kernel.org/project/chrome-platform/cover/20220209045035.380615-1-tzungbi@google.com/) - Fix review comments in 1st and 2nd patch. Changes from v1: (https://lore.kernel.org/lkml/20220125101527.1812887-1-tzungbi@google.com/T/#u) - Use imperative mood in commit messages. - Use IS_ERR_OR_NULL() in 1st patch. Tzung-Bi Shih (5): platform/chrome: cros_ec: fix error handling in cros_ec_register() platform/chrome: cros_ec: remove unused variable `was_wake_device` platform/chrome: cros_ec: initialize `wake_enabled` in cros_ec_register() platform/chrome: cros_ec: sort header inclusion alphabetically platform/chrome: cros_ec: append newline to all logs drivers/platform/chrome/cros_ec.c | 35 +++++++++++---------- include/linux/platform_data/cros_ec_proto.h | 3 -- 2 files changed, 19 insertions(+), 19 deletions(-) -- 2.35.1.265.g69c8d7142f-goog