Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 15 Feb 2022 22:56:33 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Hugh Dickins <hughd@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Michal Hocko <mhocko@suse.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        David Hildenbrand <david@redhat.com>,
        Alistair Popple <apopple@nvidia.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Rik van Riel <riel@surriel.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Yu Zhao <yuzhao@google.com>, Greg Thelen <gthelen@google.com>,
        Shakeel Butt <shakeelb@google.com>,
        Yang Li <yang.lee@linux.alibaba.com>,
        SeongJae Park <sj@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 10/13] mm/munlock: mlock_page() munlock_page() batch
 by pagevec
Message-ID: <YgwvoaJj5BqpMOiR@casper.infradead.org>
References: <55a49083-37f9-3766-1de9-9feea7428ac@google.com>
 <1abb94ee-fe72-dba9-3eb0-d1e576d148e6@google.com>
 <YgvXjwapRTOXQOuQ@casper.infradead.org>
 <ef1e285c-187a-f682-a62b-c6a0f42b5cbf@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ef1e285c-187a-f682-a62b-c6a0f42b5cbf@google.com>
Precedence: bulk

On Tue, Feb 15, 2022 at 01:02:30PM -0800, Hugh Dickins wrote:
> On Tue, 15 Feb 2022, Matthew Wilcox wrote:
> > > +#define mlock_new(page) ((struct page *)((unsigned long)page + NEW_PAGE))
> > 
> > I'm going to change this to:
> > 
> > static inline struct page *mlock_lru(struct page *page)
> > {
> > 	return (struct page *)((unsigned long)page + LRU_PAGE);
> > }
> > 
> > (mutatis mutandi for mlock_new)
> 
> Okay, thanks.  (You're not naming your folio "page" :-?)

Worse, I tried passing it '&folio->page'.  That produced some ...
interesting compiler error messages.