Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp607477pxb; Tue, 15 Feb 2022 23:36:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJxiYcpbK3tQ8riIdTyYdpUF4OzBJVwlnbfrd0iDjHaFlDTr2ApE2AnHlFo33hX1cPv5jomY X-Received: by 2002:a17:90a:3f09:b0:1b8:e615:a261 with SMTP id l9-20020a17090a3f0900b001b8e615a261mr327157pjc.196.1644996998063; Tue, 15 Feb 2022 23:36:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644996998; cv=none; d=google.com; s=arc-20160816; b=NFIIqS0JjSL94sXjhBZGZlXE7um722PJDseecvg7bWWtJyoVOVwUBkXSDNMshsW58L BNgoFuifN2/gbTSK7m6m8aPp8JyeU6jNNj917DHhpsqDXSeYf1p5HqbrzGQcChBUy1gz KFdGxUw7BP16AAWeNme/oS38LIiLihmxYBPAT5u8wxJ98Z2a8xavCNNFkJYZt4NQqfN7 M+ex0ODQryUMF7GMaOltNntlXXfvNkyx529hSWosRu1GYeiD9sZhd2IURQdxhNw9IdFU RdUkuRPkOl/Lc2LSS0H4CVPLQrl9qN5JeV7P3J1zvr1QI3+Kc6aG8DrzuU1jC192z3AC v9RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=zLCfwTEqPgbAts1m8jwlP8PVBAXIZUQ47054BaXjuWY=; b=zHqqdk1cuUX0Cw1+sq3hwjCbX8xsxlk+On1isxdLkb2GncYPtU8H5whn+FUYScwMFL w/0uhP6lAkfYdpZX7UcQgkph5Q4+5ul00DGXthGWTiw/NQBgFhBgDIcyuBL+ObbON72f wyPkVMUYPyorT8r+4i8VT50p8ZGi2EnYdLKrENMWWYNG6OnaAh88KM1C9gL3knEkoDCk 6PhDKCEDxiHL/1BMIBZ6sCGwX5BtHDZ936+Tmk1iasKACUomfFQl1Sxg0nqdCBfWutWz ae9dRdLQ0Virww4QBMw3xRM/dAvsnqVAK+RnL0HnpgJ6/Z/C76SRxbsWG+RjUzvAoqJt cCFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@who-t.net header.s=fm2 header.b=O59SGJn7; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=Zo49S1EP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id h1si4671318pgv.192.2022.02.15.23.36.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 23:36:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@who-t.net header.s=fm2 header.b=O59SGJn7; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=Zo49S1EP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E36F32B3545; Tue, 15 Feb 2022 23:02:15 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344656AbiBPFkn (ORCPT + 99 others); Wed, 16 Feb 2022 00:40:43 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344649AbiBPFkm (ORCPT ); Wed, 16 Feb 2022 00:40:42 -0500 Received: from wnew4-smtp.messagingengine.com (wnew4-smtp.messagingengine.com [64.147.123.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8235BD2ED; Tue, 15 Feb 2022 21:40:30 -0800 (PST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id BE76C2B00296; Wed, 16 Feb 2022 00:40:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 16 Feb 2022 00:40:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=who-t.net; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=zLCfwTEqPgbAts1m8jwlP8PVBAXIZUQ47054Ba XjuWY=; b=O59SGJn7XntFau15KVosBLouNjMxmYwm8UF+WWX0P9e0EwfCoUYc1S lc6YM6F5yHeRqe0ZL/mLXQu8UT8N9a8kZ52ecv7cQbYxz9FjL/lnwiVkwYMHa+CH tOtqwEQybObOdBFTh0rTxwgsucQBjP0tQtj0pQ2Sf2LPCW7wk3cB17t428ag4AzB /BCEkJHss6l+9XLaOCz0ADzROfvDCMzYfMjT9KdQp77iOpbjuv75bZMsiIHWHHrO qkbGsGE2xRQh/SO17Cblm4nlN1TqwOAs0pOQjVVhHIBQaqOj8ceyznTKuMAb1XZR 5Ux/vz8GprHnlJ2pi8WpcKV83L66FWMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=zLCfwTEqPgbAts1m8 jwlP8PVBAXIZUQ47054BaXjuWY=; b=Zo49S1EPi6J3CgIp82dMnuKxxk9dNijRv E5HYNb6sUgMUvuO3nTdFMV+nJjj4C2gjlLYVo/4rI25261e7q9ZpSEoWh/3XI/MX /Ys3NgTt1MR54NubXbpE35ZOuzJCU1nP3Cbhtc1CFAApl4HqdnZbG5FJqTZ8O5d/ nZfoCicWntqje+1Tq2IqMF0dV8OT+lXi9vLmvxeLTl0RZV0tSOcxinwmgyxxewhR 8r+NSLdimyXyUX9vS5U1XdUi9CRTKMNBSGu0Abk2ecwiyxGN00+MUBvEv+8G29wV focJsVMfdBVZ+oheV3eR7BDdMRWNlY4gSwdPDeGRc+snwoUF8YfOg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrjeehgdekfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheprfgvthgvrhcu jfhuthhtvghrvghruceophgvthgvrhdrhhhuthhtvghrvghrseifhhhoqdhtrdhnvghtqe enucggtffrrghtthgvrhhnpeehhfehfffgheelgeeuudelhefgvdefveekudevjeevjeev vefggefguddufeeuveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehpvghtvghrrdhhuhhtthgvrhgvrhesfihhohdqthdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 16 Feb 2022 00:40:23 -0500 (EST) Date: Wed, 16 Feb 2022 15:40:18 +1000 From: Peter Hutterer To: Benjamin Tissoires Cc: Jiri Kosina , Dmitry Torokhov , Jonathan Corbet , Ahelenia =?utf-8?Q?Ziemia=C5=84ska?= , Ping Cheng , Aaron Armstrong Skomra , Jason Gerecke , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 12/12] Input: docs: add more details on the use of BTN_TOOL Message-ID: References: <20220203143226.4023622-1-benjamin.tissoires@redhat.com> <20220203143226.4023622-13-benjamin.tissoires@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220203143226.4023622-13-benjamin.tissoires@redhat.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 03, 2022 at 03:32:26PM +0100, Benjamin Tissoires wrote: > The HID core stack used to be very relaxed considering the BTN_TOOL_* > usage. With the recent commits, we should now enforce to have only one > tool at a time, meaning that we can now express that requirement in the > docs. > > Signed-off-by: Benjamin Tissoires > > --- > > changes in v2: > - changed to explain that switching tool in one EV_SYN report > is not nice for userspace > --- > Documentation/input/event-codes.rst | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/input/event-codes.rst b/Documentation/input/event-codes.rst > index b24ae7d292cc..8741d390b184 100644 > --- a/Documentation/input/event-codes.rst > +++ b/Documentation/input/event-codes.rst > @@ -137,7 +137,11 @@ A few EV_KEY codes have special meanings: > code should be set to a value of 1. When the tool is no longer interacting > with the input device, the BTN_TOOL_ code should be reset to 0. All > trackpads, tablets, and touchscreens should use at least one BTN_TOOL_ > - code when events are generated. > + code when events are generated. Likewise all trackpads, tablets, and > + touchscreens should export only one BTN_TOOL_ at a time. To not break I still think s/export/set to nonzero/ to avoid any ambiguity with setting the evbit on the device vs setting the value to nonzero here, but the remainder is good, thanks :) Acked-by: Peter Hutterer Cheers, Peter > + existing userspace, it is recommended to not switch tool in one EV_SYN frame > + but first emitting the old BTN_TOOL_ at 0, then emit one SYN_REPORT > + and then set the new BTN_TOOL_ at 1. > > * BTN_TOUCH: > > -- > 2.33.1 >