Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 16 Feb 2022 12:18:49 +0900
From:   Sergey Senozhatsky <senozhatsky@chromium.org>
To:     Petr Mladek <pmladek@suse.com>
Cc:     Andre Kalb <andre.kalb@sma.de>, john.ogness@linutronix.de,
        linux-kernel@vger.kernel.org, rostedt@goodmis.org,
        senozhatsky@chromium.org
Subject: Re: [PATCH v2] printk: Set console_set_on_cmdline=1 when
 __add_preferred_console() is called with user_specified == true
Message-ID: <YgxtGWh0b9NXTyu8@google.com>
References: <YgKSbe9d3haHKMid@alley>
 <YgpXWQqjfJBISG1v@pc6682>
 <YgvsqldT1sjfF5lf@alley>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YgvsqldT1sjfF5lf@alley>
Precedence: bulk

On (22/02/15 19:10), Petr Mladek wrote:
[..]
> We should add a comment explaining the less obvious behavior as
> discussed in the thread. Something like:
> 
> > +static void set_user_specified(struct console_cmdline *c, bool user_specified)
> > +{
> > +	if (!user_specified)
> > +		return;
> > +
> 	/*
> 	 * @c console was defined by the user on the command line.
> 	 * Do not clear when added twice also by SPCR or the device tree.
> 	 */
> > +	c->user_specified = true;
> 	/* At least one console defined by the user on the command line. */
> > +	console_set_on_cmdline = 1;
> > +}
> > +
> >  static int __add_preferred_console(char *name, int idx, char *options,
> >  				   char *brl_options, bool user_specified)
> >  {
> 
> With the above comments:
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> 
> Sergey, is it enough from your POV, please?

Yes, Petr. Thank you.

Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>