Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v6 01/71] binfmt_elf: Take the mmap lock when walking the VMA
 list
Thread-Topic: [PATCH v6 01/71] binfmt_elf: Take the mmap lock when walking the
 VMA list
Thread-Index: AQHYInpRQctdnN4nV0+fc4QEv9tDRA==
Date:   Tue, 15 Feb 2022 14:42:55 +0000
Message-ID: <20220215144241.3812052-1-Liam.Howlett@oracle.com>
References: <20220215143728.3810954-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220215143728.3810954-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?JqBXqRryMah0mz+OJQRBUqnElP7gBi2RNdRNvahb+dmvI531kMsxxNPRRp?=
 =?iso-8859-1?Q?m4rlKeYroPt82EIMlMvZoljbG7D0zE6em9JMY7KolDOO5NAsc3YljFlsgz?=
 =?iso-8859-1?Q?SU9yaTw2guYCX0VC2vkuN5hCa7XKIQbUUah0mbP2GN0I2LyE+tdu4W74fc?=
 =?iso-8859-1?Q?7G2Nt1aFhtlPLVdlKgUNtthMOq20FCCOjXy5+NXX05pvBFlsvD5sAncfjl?=
 =?iso-8859-1?Q?HaMTEDbNt8lMxAtJXqvf8D+7GJFFlSXMqRogG8K1A1qU1ghArLkHsdqCNe?=
 =?iso-8859-1?Q?WEdt6NZqruSQ3EA7D10sXfV1VPCXSwTvZlSNCiUlpL3LhdV/qv883ZeCpq?=
 =?iso-8859-1?Q?7Ri5dmgI6lKHhVXe3a+CIH0BX0xfDZDdOSDLoO6At6P74ai+NWc5yHhAEp?=
 =?iso-8859-1?Q?Zlvpifyk/EaWcGeBWhhj4+rRPW0LyLL7xULTak+koiRuG424cYjklR7y+3?=
 =?iso-8859-1?Q?Wk9nHB/0YxBAfGxbhGIVyclI9uHjkDiQJErS6mTar21qb6WQa77sob3jCs?=
 =?iso-8859-1?Q?cW47nyfqiiUdX+i9jEe4UHhc96mKPwcZYjbdKhwcNwBO4052VGqB3Wk7y1?=
 =?iso-8859-1?Q?qnRyAt98awxKK4iFRIWs2LKcEKZOHLiKe5g8njl3twcxOumY4ssWd16t0D?=
 =?iso-8859-1?Q?aqraDws9PXkHX5Wfqt2ulBmcI86fBHmPpSiSpOm20WZrQuswQ2qGej7awB?=
 =?iso-8859-1?Q?u0qYjLBYT0CP7B/lND8Uw1kxU7zbY4YY3FOa86zpjL0QksyV3K0psRh8a0?=
 =?iso-8859-1?Q?MJbckPbcXx2MfhEy4iLe+w5PqVfjnz8/HU+5swEBmqhLEET5r0oQJlJJQV?=
 =?iso-8859-1?Q?6NVPN0rOJmUHIFesGAihsMu1MUucQwDEYhjVjCXSUMnLwx9z/dNXHT9wzi?=
 =?iso-8859-1?Q?1N47ZG8T59PA7zAjR4PWKwQCKMMQaKIIrAvAMC0SmKdFvacy+sneqng/bo?=
 =?iso-8859-1?Q?CeviNJBK21DBMG08cxUP5QOq6DDpb6CbLle3ErJ1VsEwdcn7D3rEocWHpt?=
 =?iso-8859-1?Q?YU6qWWBR8k012WBgo6X4Cq+L4t/4jnWOLP2/iOhvssl6kJTe75dbM5KWDC?=
 =?iso-8859-1?Q?CsKDTdatV7kWTZcCm4HeBUeytdX9QFPRBa3okOoZ9D9RKnrq5qLvUmOIMj?=
 =?iso-8859-1?Q?0ttczaOiqWKfJe70o+iWiMClXsPKO+YbAeD8irNYgqTzpwETql/h96qacz?=
 =?iso-8859-1?Q?cONfgUE9epkNY/ornUl3hMamgpp/q7ABb4Dsdbq8zQhvrkDRbNLK0zass4?=
 =?iso-8859-1?Q?ONwV3SBYTwLTetFMmsBNtkCVYOc7mAgomoIfONOfbY9LzaosssYb10esNG?=
 =?iso-8859-1?Q?Pf0FW4lL4Kv5Qy3qez7jWUcJ1s77JVQu1haS4MV9SSQSyUjU/Jn+7IlFZK?=
 =?iso-8859-1?Q?3ErqWQ3QE8rrsEkGg+VuAjEGvZyhwdRMr8BGr6r1SG/bZnR8K7TfF+of6W?=
 =?iso-8859-1?Q?dwEWLjfpT3tFZLxxD8VmEm/NNGXwsTjwS9FW6/+PzyBB4US+s4ke+3dNvE?=
 =?iso-8859-1?Q?UntJspz4RspcxUkDH/hq4T7KsjcxQmBEIuH3E6WuWzHwnO8JT7iquqLYWa?=
 =?iso-8859-1?Q?HbheTHeNhHi6K6ZcRnijZb6fiopwYFOlTMXqnzSClXmSqU+gCsLwxuM38G?=
 =?iso-8859-1?Q?ZJcqVRMVd9A64z/7m1/0c6OsmPNJWvgG7XYR7YDjQJwOPdVudCGqPfuD/I?=
 =?iso-8859-1?Q?cxZQGmjCu4md1RulWh8=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1d53b62-f76c-4e1c-21d5-08d9f09173fd
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 14:42:55.5747
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Csme6jn2p2V6cBDpPDZ/ACQt98U4SOz0qc5TNzSW/7gk+8BNBlxhUOv5JvVaacuDkbgkaPBL+eIQ5zeKkORv3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1001MB2197
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10258 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0
 mlxlogscore=999 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202150085
X-Proofpoint-GUID: Z9AeMRfOYHfGrpC8M901K5tngjbb86Fj
X-Proofpoint-ORIG-GUID: Z9AeMRfOYHfGrpC8M901K5tngjbb86Fj
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

I'm not sure if the VMA list can change under us, but dump_vma_snapshot()
is very careful to take the mmap_lock in write mode.  We only need to
take it in read mode here as we do not care if the size of the stack
VMA changes underneath us.

If it can be changed underneath us, this is a potential use-after-free
for a multithreaded process which is dumping core.

Fixes: 2aa362c49c31 ("coredump: extend core dump note section to contain fi=
le names of mapped files")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
---
 fs/binfmt_elf.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index 9e11e6f13e83..f15efed29d3d 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -1651,6 +1651,7 @@ static int fill_files_note(struct memelfnote *note)
 	name_base =3D name_curpos =3D ((char *)data) + names_ofs;
 	remaining =3D size - names_ofs;
 	count =3D 0;
+	mmap_read_lock(mm);
 	for (vma =3D mm->mmap; vma !=3D NULL; vma =3D vma->vm_next) {
 		struct file *file;
 		const char *filename;
@@ -1661,6 +1662,7 @@ static int fill_files_note(struct memelfnote *note)
 		filename =3D file_path(file, name_curpos, remaining);
 		if (IS_ERR(filename)) {
 			if (PTR_ERR(filename) =3D=3D -ENAMETOOLONG) {
+				mmap_read_unlock(mm);
 				kvfree(data);
 				size =3D size * 5 / 4;
 				goto alloc;
@@ -1680,6 +1682,7 @@ static int fill_files_note(struct memelfnote *note)
 		*start_end_ofs++ =3D vma->vm_pgoff;
 		count++;
 	}
+	mmap_read_unlock(mm);
=20
 	/* Now we know exact count of files, can store it */
 	data[0] =3D count;
--=20
2.34.1