Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com;
Envelope-to: trix@redhat.com,
 davem@davemloft.net,
 kuba@kernel.org,
 gary@garyguo.net,
 rdunlap@infradead.org,
 esben@geanix.com,
 huangguangbin2@huawei.com,
 michael@walle.cc,
 moyufeng@huawei.com,
 arnd@arndb.de,
 chenhao288@hisilicon.com,
 andrew@lunn.ch,
 prabhakar.mahadev-lad.rj@bp.renesas.com,
 yuehaibing@huawei.com,
 netdev@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org
Message-ID: <54168947-f587-2209-b6df-80aefb968123@xilinx.com>
Date:   Wed, 16 Feb 2022 08:41:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] net: ethernet: xilinx: cleanup comments
Content-Language: en-US
To:     <trix@redhat.com>, <davem@davemloft.net>, <kuba@kernel.org>,
        <michal.simek@xilinx.com>, <radhey.shyam.pandey@xilinx.com>,
        <gary@garyguo.net>, <rdunlap@infradead.org>, <esben@geanix.com>,
        <huangguangbin2@huawei.com>, <michael@walle.cc>,
        <moyufeng@huawei.com>, <arnd@arndb.de>, <chenhao288@hisilicon.com>,
        <andrew@lunn.ch>, <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        <yuehaibing@huawei.com>
CC:     <netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20220215190447.3030710-1-trix@redhat.com>
From:   Michal Simek <michal.simek@xilinx.com>
In-Reply-To: <20220215190447.3030710-1-trix@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 07:41:47.9913
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 59cc8481-8133-471c-a14c-08d9f11fc9bf
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0038.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR02MB7193
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/15/22 20:04, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Remove the second 'the'.
> Replacements:
> endiannes to endianness
> areconnected to are connected
> Mamagement to Management
> undoccumented to undocumented
> Xilink to Xilinx
> strucutre to structure
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>   drivers/net/ethernet/xilinx/Kconfig               | 2 +-
>   drivers/net/ethernet/xilinx/ll_temac.h            | 4 ++--
>   drivers/net/ethernet/xilinx/ll_temac_main.c       | 2 +-
>   drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
>   drivers/net/ethernet/xilinx/xilinx_emaclite.c     | 2 +-
>   5 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
> index 911b5ef9e680..0014729b8865 100644
> --- a/drivers/net/ethernet/xilinx/Kconfig
> +++ b/drivers/net/ethernet/xilinx/Kconfig
> @@ -1,6 +1,6 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   #
> -# Xilink device configuration
> +# Xilinx device configuration
>   #
>   
>   config NET_VENDOR_XILINX
> diff --git a/drivers/net/ethernet/xilinx/ll_temac.h b/drivers/net/ethernet/xilinx/ll_temac.h
> index 4a73127e10a6..ad8d29f84be6 100644
> --- a/drivers/net/ethernet/xilinx/ll_temac.h
> +++ b/drivers/net/ethernet/xilinx/ll_temac.h
> @@ -271,7 +271,7 @@ This option defaults to enabled (set) */
>   
>   #define XTE_TIE_OFFSET			0x000003A4 /* Interrupt enable */
>   
> -/**  MII Mamagement Control register (MGTCR) */
> +/**  MII Management Control register (MGTCR) */


When you touch this you should remove /** which points to kernel-doc format.

When fixed you can add my
Reviewed-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal