Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp633479pxb; Wed, 16 Feb 2022 00:27:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJx4p8Gj+luztVTlCaSwInreLW8kDEzZhV/ebdGp7RQu6TiWMpvOSSRNvPprte42UjZQj/9h X-Received: by 2002:a17:90a:8046:b0:1b9:c7aa:fd66 with SMTP id e6-20020a17090a804600b001b9c7aafd66mr491440pjw.82.1645000068527; Wed, 16 Feb 2022 00:27:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645000068; cv=none; d=google.com; s=arc-20160816; b=HTTOppdgM++bjVh2N4AuI/+VrSZnWG0QXjHx6cQFstrg7bTMlIzVzypWdrZgogPoxX U+79Q/CR0V7F9RJFVA5qjU0mFSuoMMCLddT9W6vpwx9us6wq3kZdHa1u8nohCcjzYrs0 GKfo2JyBa4SjCv9qhLloSRGI35jTO7js2OQQohvRtKdxFVdyLJ0GeUCxMhfAyj9V9BpD mwryK4b9d6jBw8eJSGmwDXsrxHI/joyFnwj+lOUYTkLmux/iDzXgGgjhLQ4AtCO0aOsg mey5X12Npu//4nGkx/ZK8N2r+cNST0T08rruW60rqwcdu32lxEzX9t4rLNQMq2CZmtof KGvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/vyEw0eXQEU8g1xsO8H/bJkTc/oKSosKDkFDWSTBcF8=; b=FtRgg9/719/JoVX4QOAYLVo3VHyOsuLqIhdQnx7VauUmZT7Jj92gFeD07tVyHymW3i yMnlQ8X77UvjwqrETIetA8AFOHsDAzzh1s/oCxacgx15yAuS29U+Z+r+5ClJy36rWjNt 0QVon4o3m7/JYSm/Urc4XnRZCJSgMhquCCoC/rzIowGGBOoCEZD5EG8SsxmPDcVhvQ78 syWTaAl1rwG5lxVLd0FdvPmKoExbUYyxEvZ0yCz/SO74HWi/OWIUxyJVAC6E+DD8HuMg BwzYmgHbEtTAsMV2FpB2IWg1VkIYZGw9xYyRWi/8SyAG4zE3mUz0X8scV0RlVybfHkU3 zUyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NQmL76GE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id e4si10546684pjr.42.2022.02.16.00.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 00:27:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NQmL76GE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 32A80DFFA; Wed, 16 Feb 2022 00:16:10 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231556AbiBPIQF (ORCPT + 99 others); Wed, 16 Feb 2022 03:16:05 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:33648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231528AbiBPIQE (ORCPT ); Wed, 16 Feb 2022 03:16:04 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E86CA13D3D for ; Wed, 16 Feb 2022 00:15:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644999352; x=1676535352; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mZe1Um7zlEYvfSJSwbgaDtjTEuNMEhb6+5hvoEsUI10=; b=NQmL76GEyhrzoQqAzbaKDepd2WTgA5uhjC1FeXoyhRet8ryMxORa5ZSg aclVgKrQTk7u1/y7z0lfc0Q4fytMhLtezHU7Cf0z5aCG+gpa9ZtviluAx CehuouT/dxzc8/Hy40Ekh+8rV30ezvrcwXUTa5XxtZg2oK1VjwOhD+mbQ 7ld+DZ/rA5ziDV5xXPIfllhHCoGsiBCEwYyZR13ayndvUia9uMJIEmRGV an7TKep76O5ZWzIIA723YaxqF4aJ/9/aL6fdKO9BjkRwQ7OCnGURJ3aeE v4xmEKVWKmK06jNUP1HklnztNaQQPzwSDp8UJ/GkjgYpYm4Zw5lAX6OQt w==; X-IronPort-AV: E=McAfee;i="6200,9189,10259"; a="250750868" X-IronPort-AV: E=Sophos;i="5.88,373,1635231600"; d="scan'208";a="250750868" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2022 00:15:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,373,1635231600"; d="scan'208";a="773920851" Received: from pglc00512.png.intel.com ([10.221.239.204]) by fmsmga006.fm.intel.com with ESMTP; 16 Feb 2022 00:15:51 -0800 From: tien.sung.ang@intel.com To: Dinh Nguyen Cc: linux-kernel@vger.kernel.org, Ang Tien Sung Subject: [PATCH] firmware: stratix10-svc: add missing callback parameter on RSU Date: Wed, 16 Feb 2022 16:15:13 +0800 Message-Id: <20220216081513.28319-1-tien.sung.ang@intel.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ang Tien Sung Fix a bug whereby, the return response of parameter a1 from an SMC call is not properly set to the callback data during an INTEL_SIP_SMC_RSU_ERROR command. Fixes: 6b50d882d38d ("firmware: add remote status update client support") Signed-off-by: Ang Tien Sung --- drivers/firmware/stratix10-svc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c index 29c0a616b317..c4bf934e3553 100644 --- a/drivers/firmware/stratix10-svc.c +++ b/drivers/firmware/stratix10-svc.c @@ -477,7 +477,7 @@ static int svc_normal_to_secure_thread(void *data) case INTEL_SIP_SMC_RSU_ERROR: pr_err("%s: STATUS_ERROR\n", __func__); cbdata->status = BIT(SVC_STATUS_ERROR); - cbdata->kaddr1 = NULL; + cbdata->kaddr1 = &res.a1; cbdata->kaddr2 = NULL; cbdata->kaddr3 = NULL; pdata->chan->scl->receive_cb(pdata->chan->scl, cbdata); -- 2.26.2