Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Liu Ying <victor.liu@nxp.com>
To:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     agx@sigxcpu.org, robert.foss@linaro.org, linux-imx@nxp.com
Subject: [PATCH] drm/bridge: nwl-dsi: Remove superfluous write to NWL_DSI_IRQ_MASK register
Date:   Wed, 16 Feb 2022 16:58:42 +0800
Message-Id: <20220216085842.1973868-1-victor.liu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Dqis+ct8IK+K1ZTngO9z2UbKm4MYmS8hMQp9iZ23FLVDW1ltOWAEHiRoyitj?=
 =?us-ascii?Q?moc2hn9wj26HtLkfz4OzdaBwDEno/LnIj15oCeip/52OYmS53P0jCADEDR3Y?=
 =?us-ascii?Q?kFNGGvzECWsPC+7sjTArOcXIYeCbRnVjiNJpnQ7IXAJK8U9Xn3PxhMLqp7cV?=
 =?us-ascii?Q?MNyF1j6kuEm/kya3sT5SR+aOE6UiDe2d6eg8lnd634KW334IVP2u09QB4t6A?=
 =?us-ascii?Q?LkvXUxgLLSMmMmlFV8jAnva5nCYx0DLL3l91Xpoal5fnWBBdqtnRO2oOqx9x?=
 =?us-ascii?Q?8SqqN7wuaWb1YLMc2JO11gPsPZBqH7yy30Y+ayc+BDxJbjPXoSzcgxCiDbjI?=
 =?us-ascii?Q?XJeJCFX5jfr0H0FBiHp0c1kt2MfG5iiMGGwHUEiz+5HWmbrcYzIqY5Gppyf4?=
 =?us-ascii?Q?k8R6aVjFL7+ZeImgPSLZQFUO5ycFNdeipSmss9qNYKxd00R4D9vXGq6st9kQ?=
 =?us-ascii?Q?AcaIy+Ghcm84J8qY9OUCJIUFJ/GkWs4ahV+5pvZ3ZZmFrrshxihDnUWuUWHQ?=
 =?us-ascii?Q?r5RlSEX+9xxdDkbYINmAKRAJ/6zk1576FzTPQLORSKAZBY/7h66qf2dwwh+7?=
 =?us-ascii?Q?II9jMct9XglWgc0I7SG83/lUPPWUl96Iw+mMBcNZpBXUJ6bNMBwpB9Q3tmKo?=
 =?us-ascii?Q?/xyTttJYsMo30bBwJWBPMo++iRc6LDxJhL4WvN+Ystn/f7AebmezVFNE78Mi?=
 =?us-ascii?Q?2S7jzFoIVxMAcnoD82QCZzznk0gdTazBFKkBz+TKnXF8bhgnFkL3iKpTFXh9?=
 =?us-ascii?Q?cqr/v/jwbbWOOaBT9UjcFWvuaChVQB4noHjEDPwOHz5fW4Yl60AYYpRl/PjD?=
 =?us-ascii?Q?HXaQeKCZNPRiqfzTv4IzuK/LIvzOpIEA7UJBtVbrot4OX5PcEA549KZBHazn?=
 =?us-ascii?Q?XLNeokGl6zy2AObYay2Dkl7CrKwAGXi6t5Trsxom3Cg1G0qI++fcg3EWYlBF?=
 =?us-ascii?Q?6XfZY57/8bTytu4U5AxzoTcaeDxJRY8eINbDgfQA92kk6hfyGL/wPN5XYCy5?=
 =?us-ascii?Q?A85NfZlTAWkiWEY8LZSQGEymFDSbgfF3pTBvK67FhFXsuZGE+lkEDQA73sZl?=
 =?us-ascii?Q?JbjJbJrtGxl59DOZDYAsarhfrNhTHi6DcowbuyOS7XQRmxHCF0JYlpdFeE6K?=
 =?us-ascii?Q?lYVVLgaEofbaY9ZgUPLobQPWBxpmhmLoyW6qLavS4QYuSJhYG8YRJnH+tUd3?=
 =?us-ascii?Q?fRERWv0h5zuSPNTz02bSHhOnniFlT/iN9zxCtTQa8n2bValeCJmqvtzySCFX?=
 =?us-ascii?Q?CEWwZYQIvboF23HCx0Qpj/au4RItzT+D/OmjqKlB1aqGBSXy8VouoVTPLUqw?=
 =?us-ascii?Q?Ah58hHsoInUzWr+j5kbh+Kz7qo7kagZ8YNiQWTgxaT5NHhXJCqkfXBSut9Y0?=
 =?us-ascii?Q?PnORFJcNcpHlKD/aGdsIb6tvkOO6Yc/MgzG5FemMIeTNpj4Q5cqvapbFHTdY?=
 =?us-ascii?Q?C7Gyf7KUkcBI+Ed20E0XFhBR6tgDARcvM6IIyYlAzPtwH0r2dQErGvt58TL+?=
 =?us-ascii?Q?pxrxL+qddDoUrQhMERQsXnH3CS4UuAxGgJTg8bvOV/+lW0i4kfh2zWybo4t4?=
 =?us-ascii?Q?9nIfI5aHcgG6oNWZkcjLdaOBsgDqsvAbWFT8o2zNK5Rd8/VdE+q1sGX0rT5Z?=
 =?us-ascii?Q?9BVnxNS2rC5dj2PBRRVjMN0=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7378318f-5d53-49c3-ad30-08d9f12aa910
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 08:59:38.0278
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ABcY6EPFsZh8MfbT8TbYiH7RxvVMU14JwnFsQJa8hw0fCUIgnBrXTaofjadGSrhXeYrTQN8Afhr+Nq/iDIKvTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4078
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

To initialize register NWL_DSI_IRQ_MASK, it's enough to write it
only once in function nwl_dsi_init_interrupts().

Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 drivers/gpu/drm/bridge/nwl-dsi.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
index af07eeb47ca0..fcc4a2889ad4 100644
--- a/drivers/gpu/drm/bridge/nwl-dsi.c
+++ b/drivers/gpu/drm/bridge/nwl-dsi.c
@@ -333,17 +333,13 @@ static int nwl_dsi_config_dpi(struct nwl_dsi *dsi)
 
 static int nwl_dsi_init_interrupts(struct nwl_dsi *dsi)
 {
-	u32 irq_enable;
-
-	nwl_dsi_write(dsi, NWL_DSI_IRQ_MASK, 0xffffffff);
-	nwl_dsi_write(dsi, NWL_DSI_IRQ_MASK2, 0x7);
-
-	irq_enable = ~(u32)(NWL_DSI_TX_PKT_DONE_MASK |
-			    NWL_DSI_RX_PKT_HDR_RCVD_MASK |
-			    NWL_DSI_TX_FIFO_OVFLW_MASK |
-			    NWL_DSI_HS_TX_TIMEOUT_MASK);
+	u32 irq_enable = ~(u32)(NWL_DSI_TX_PKT_DONE_MASK |
+				NWL_DSI_RX_PKT_HDR_RCVD_MASK |
+				NWL_DSI_TX_FIFO_OVFLW_MASK |
+				NWL_DSI_HS_TX_TIMEOUT_MASK);
 
 	nwl_dsi_write(dsi, NWL_DSI_IRQ_MASK, irq_enable);
+	nwl_dsi_write(dsi, NWL_DSI_IRQ_MASK2, 0x7);
 
 	return nwl_dsi_clear_error(dsi);
 }
-- 
2.25.1