Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Subject: Re: [RESEND v13 08/10] ASoC: qcom: Add lpass CPU driver for codec dma
 control
To:     Stephen Boyd <swboyd@chromium.org>, <agross@kernel.org>,
        <alsa-devel@alsa-project.org>, <bgoswami@codeaurora.org>,
        <bjorn.andersson@linaro.org>, <broonie@kernel.org>,
        <devicetree@vger.kernel.org>, <judyhsiao@chromium.org>,
        <lgirdwood@gmail.com>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <perex@perex.cz>,
        <quic_plai@quicinc.com>, <robh+dt@kernel.org>,
        <rohitkr@codeaurora.org>, <srinivas.kandagatla@linaro.org>,
        <tiwai@suse.com>
CC:     Venkata Prasad Potturu <quic_potturu@quicinc.com>
References: <1644850708-11099-1-git-send-email-quic_srivasam@quicinc.com>
 <1644850708-11099-9-git-send-email-quic_srivasam@quicinc.com>
 <CAE-0n52jD_BvQm4CeTkiR723-3uKC9G4fFeynFbs5Ukg_S762g@mail.gmail.com>
From:   Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Organization: Qualcomm
Message-ID: <d70291a6-7e3f-0406-2826-3a30f2d5650b@quicinc.com>
Date:   Wed, 16 Feb 2022 15:12:42 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAE-0n52jD_BvQm4CeTkiR723-3uKC9G4fFeynFbs5Ukg_S762g@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 2/15/2022 7:03 AM, Stephen Boyd wrote:
Thanks for your time Stephen!!!
> Quoting Srinivasa Rao Mandadapu (2022-02-14 06:58:26)
>> diff --git a/sound/soc/qcom/lpass-cdc-dma.c b/sound/soc/qcom/lpass-cdc-dma.c
>> new file mode 100644
>> index 0000000..4a50baa
>> --- /dev/null
>> +++ b/sound/soc/qcom/lpass-cdc-dma.c
>> @@ -0,0 +1,304 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Copyright (c) 2021 The Linux Foundation. All rights reserved.
>> + *
>> + * lpass-cdc-dma.c -- ALSA SoC CDC DMA CPU DAI driver for QTi LPASS
>> + */
>> +
>> +#include <linux/clk.h>
>> +#include <linux/module.h>
> export.h for EXPORT_SYMBOL usage.
>
>> +#include <sound/soc.h>
>> +#include <sound/soc-dai.h>
>> +
>> +#include "lpass-lpaif-reg.h"
>> +#include "lpass.h"
>> +
>> +#define CODEC_MEM_FREQ_NORMAL 153600000
> Is this in Hz? CODEC_MEM_HZ_NORMAL?
Okay. Will change accordingly.
>
>> +
>> +enum codec_dma_interfaces {
>> +       LPASS_CDC_DMA_INTERFACE1 = 1,
>> +       LPASS_CDC_DMA_INTERFACE2,
>> +       LPASS_CDC_DMA_INTERFACE3,
>> +       LPASS_CDC_DMA_INTERFACE4,
>> +       LPASS_CDC_DMA_INTERFACE5,
>> +       LPASS_CDC_DMA_INTERFACE6,
>> +       LPASS_CDC_DMA_INTERFACE7,
>> +       LPASS_CDC_DMA_INTERFACE8,
>> +       LPASS_CDC_DMA_INTERFACE9,
>> +       LPASS_CDC_DMA_INTERFACE10,
>> +};
>> +
>> +static void __lpass_get_dmactl_handle(struct snd_pcm_substream *substream, struct snd_soc_dai *dai,
>> +                                     struct lpaif_dmactl **dmactl, int *id)
>> +{
>> +       struct snd_soc_pcm_runtime *soc_runtime = asoc_substream_to_rtd(substream);
>> +       struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(soc_runtime, 0);
>> +       struct lpass_data *drvdata = snd_soc_dai_get_drvdata(dai);
>> +       struct snd_pcm_runtime *rt = substream->runtime;
>> +       struct lpass_pcm_data *pcm_data = rt->private_data;
>> +       struct lpass_variant *v = drvdata->variant;
>> +       unsigned int dai_id = cpu_dai->driver->id;
>> +
>> +       switch (dai_id) {
>> +       case LPASS_CDC_DMA_RX0 ... LPASS_CDC_DMA_RX9:
>> +               *dmactl = drvdata->rxtx_rd_dmactl;
>> +               *id = pcm_data->dma_ch;
>> +               break;
>> +       case LPASS_CDC_DMA_TX0 ... LPASS_CDC_DMA_TX8:
>> +               *dmactl = drvdata->rxtx_wr_dmactl;
>> +               *id = pcm_data->dma_ch - v->rxtx_wrdma_channel_start;
>> +               break;
>> +       case LPASS_CDC_DMA_VA_TX0 ... LPASS_CDC_DMA_VA_TX8:
>> +               *dmactl = drvdata->va_wr_dmactl;
>> +               *id = pcm_data->dma_ch - v->va_wrdma_channel_start;
>> +               break;
>> +       default:
>> +               dev_err(soc_runtime->dev, "invalid dai id for dma ctl: %d\n", dai_id);
>> +               break;
>> +       }
>> +}
>> +
>> +static int __lpass_get_codec_dma_intf_type(int dai_id)
>> +{
>> +       int ret;
>> +
>> +       switch (dai_id) {
>> +       case LPASS_CDC_DMA_RX0:
>> +       case LPASS_CDC_DMA_TX0:
>> +       case LPASS_CDC_DMA_VA_TX0:
>> +               ret = LPASS_CDC_DMA_INTERFACE1;
>> +               break;
>> +       case LPASS_CDC_DMA_RX1:
>> +       case LPASS_CDC_DMA_TX1:
>> +       case LPASS_CDC_DMA_VA_TX1:
>> +               ret = LPASS_CDC_DMA_INTERFACE2;
>> +               break;
>> +       case LPASS_CDC_DMA_RX2:
>> +       case LPASS_CDC_DMA_TX2:
>> +       case LPASS_CDC_DMA_VA_TX2:
>> +               ret = LPASS_CDC_DMA_INTERFACE3;
>> +               break;
>> +       case LPASS_CDC_DMA_RX3:
>> +       case LPASS_CDC_DMA_TX3:
>> +       case LPASS_CDC_DMA_VA_TX3:
>> +               ret = LPASS_CDC_DMA_INTERFACE4;
>> +               break;
>> +       case LPASS_CDC_DMA_RX4:
>> +       case LPASS_CDC_DMA_TX4:
>> +       case LPASS_CDC_DMA_VA_TX4:
>> +               ret = LPASS_CDC_DMA_INTERFACE5;
>> +               break;
>> +       case LPASS_CDC_DMA_RX5:
>> +       case LPASS_CDC_DMA_TX5:
>> +       case LPASS_CDC_DMA_VA_TX5:
>> +               ret = LPASS_CDC_DMA_INTERFACE6;
>> +               break;
>> +       case LPASS_CDC_DMA_RX6:
>> +       case LPASS_CDC_DMA_TX6:
>> +       case LPASS_CDC_DMA_VA_TX6:
>> +               ret = LPASS_CDC_DMA_INTERFACE7;
>> +               break;
>> +       case LPASS_CDC_DMA_RX7:
>> +       case LPASS_CDC_DMA_TX7:
>> +       case LPASS_CDC_DMA_VA_TX7:
>> +               ret = LPASS_CDC_DMA_INTERFACE8;
>> +               break;
>> +       case LPASS_CDC_DMA_RX8:
>> +       case LPASS_CDC_DMA_TX8:
>> +       case LPASS_CDC_DMA_VA_TX8:
>> +               ret = LPASS_CDC_DMA_INTERFACE9;
>> +               break;
>> +       case LPASS_CDC_DMA_RX9:
>> +               ret  = LPASS_CDC_DMA_INTERFACE10;
>> +               break;
>> +       default:
>> +               ret = -EINVAL;
>> +               break;
>> +       }
>> +       return ret;
>> +}
>> +
>> +static int __lpass_platform_codec_intf_init(struct snd_soc_dai *dai,
>> +                                           struct snd_pcm_substream *substream)
>> +{
>> +       struct snd_soc_pcm_runtime *soc_runtime = asoc_substream_to_rtd(substream);
>> +       struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(soc_runtime, 0);
>> +       struct lpaif_dmactl *dmactl = NULL;
>> +       struct device *dev = soc_runtime->dev;
>> +       int ret, id, codec_intf;
>> +       unsigned int dai_id = cpu_dai->driver->id;
>> +
>> +       codec_intf = __lpass_get_codec_dma_intf_type(dai_id);
>> +       if (codec_intf < 0) {
>> +               dev_err(dev, "failed to get codec_intf: %d\n", codec_intf);
>> +               return codec_intf;
>> +       }
>> +
>> +       __lpass_get_dmactl_handle(substream, dai, &dmactl, &id);
>> +       if (!dmactl) {
>> +               dev_err(dev, "failed to get dmactl handle for dai_id: %d\n", dai_id);
>> +               return -EINVAL;
>> +       }
>> +
>> +       ret = regmap_fields_write(dmactl->codec_intf, id, codec_intf);
>> +       if (ret) {
>> +               dev_err(dev, "error writing to dmactl codec_intf reg field: %d\n", ret);
>> +               return ret;
>> +       }
>> +       ret = regmap_fields_write(dmactl->codec_fs_sel, id, 0x0);
>> +       if (ret) {
>> +               dev_err(dev, "error writing to dmactl codec_fs_sel reg field: %d\n", ret);
>> +               return ret;
>> +       }
>> +       ret = regmap_fields_write(dmactl->codec_fs_delay, id, 0x0);
>> +       if (ret) {
>> +               dev_err(dev, "error writing to dmactl codec_fs_delay reg field: %d\n", ret);
>> +               return ret;
>> +       }
>> +       ret = regmap_fields_write(dmactl->codec_pack, id, 0x1);
>> +       if (ret) {
>> +               dev_err(dev, "error writing to dmactl codec_pack reg field: %d\n", ret);
>> +               return ret;
>> +       }
>> +       ret = regmap_fields_write(dmactl->codec_enable, id, LPAIF_DMACTL_ENABLE_ON);
>> +       if (ret) {
>> +               dev_err(dev, "error writing to dmactl codec_enable reg field: %d\n", ret);
>> +               return ret;
>> +       }
>> +       return 0;
>> +}
>> +
>> +static int lpass_cdc_dma_daiops_startup(struct snd_pcm_substream *substream,
>> +                                   struct snd_soc_dai *dai)
>> +{
>> +       struct lpass_data *drvdata = snd_soc_dai_get_drvdata(dai);
>> +       struct snd_soc_pcm_runtime *soc_runtime = asoc_substream_to_rtd(substream);
>> +
>> +       switch (dai->id) {
>> +       case LPASS_CDC_DMA_RX0 ... LPASS_CDC_DMA_RX9:
>> +       case LPASS_CDC_DMA_TX0 ... LPASS_CDC_DMA_TX8:
>> +               clk_set_rate(drvdata->cdc_clks[2].clk, CODEC_MEM_FREQ_NORMAL);
>> +               clk_prepare_enable(drvdata->cdc_clks[2].clk);
> Where do '2' and '5' come from? Why are they part of the bulk clk array?
> Why not get them separately and give them real named pointer values?
Okay. will change to real named pointers.
>
>> +               break;
>> +       case LPASS_CDC_DMA_VA_TX0 ... LPASS_CDC_DMA_VA_TX0:
>> +               clk_set_rate(drvdata->cdc_clks[5].clk, CODEC_MEM_FREQ_NORMAL);
>> +               clk_prepare_enable(drvdata->cdc_clks[5].clk);
>> +               break;
>> +       default:
>> +               dev_err(soc_runtime->dev, "%s: invalid  interface: %d\n", __func__, dai->id);
>> +               break;
>> +       }
>> +       return 0;
>> +}
>> +
>> +static void lpass_cdc_dma_daiops_shutdown(struct snd_pcm_substream *substream,
>> +                                     struct snd_soc_dai *dai)
>> +{
>> +       struct lpass_data *drvdata = snd_soc_dai_get_drvdata(dai);
>> +       struct snd_soc_pcm_runtime *soc_runtime = asoc_substream_to_rtd(substream);
>> +
>> +       switch (dai->id) {
>> +       case LPASS_CDC_DMA_RX0 ... LPASS_CDC_DMA_RX9:
>> +       case LPASS_CDC_DMA_TX0 ... LPASS_CDC_DMA_TX8:
>> +               clk_disable_unprepare(drvdata->cdc_clks[2].clk);
>> +               break;
>> +       case LPASS_CDC_DMA_VA_TX0 ... LPASS_CDC_DMA_VA_TX0:
>> +               clk_disable_unprepare(drvdata->cdc_clks[5].clk);
>> +               break;
>> +       default:
>> +               dev_err(soc_runtime->dev, "%s: invalid  interface: %d\n", __func__, dai->id);
>> +               break;
>> +       }
>> +}
>> +
>> +static int lpass_cdc_dma_daiops_hw_params(struct snd_pcm_substream *substream,
>> +                                     struct snd_pcm_hw_params *params,
>> +                                     struct snd_soc_dai *dai)
>> +{
>> +       struct snd_soc_pcm_runtime *soc_runtime = asoc_substream_to_rtd(substream);
>> +       struct lpaif_dmactl *dmactl = NULL;
>> +       unsigned int ret, regval;
>> +       unsigned int channels = params_channels(params);
>> +       int id;
>> +
>> +       switch (channels) {
>> +       case 1:
>> +               regval = LPASS_CDC_DMA_INTF_ONE_CHANNEL;
>> +               break;
>> +       case 2:
>> +               regval = LPASS_CDC_DMA_INTF_TWO_CHANNEL;
>> +               break;
>> +       case 4:
>> +               regval = LPASS_CDC_DMA_INTF_FOUR_CHANNEL;
>> +               break;
>> +       case 6:
>> +               regval = LPASS_CDC_DMA_INTF_SIX_CHANNEL;
>> +               break;
>> +       case 8:
>> +               regval = LPASS_CDC_DMA_INTF_EIGHT_CHANNEL;
>> +               break;
>> +       default:
>> +               dev_err(soc_runtime->dev, "invalid PCM config\n");
>> +               return -EINVAL;
>> +       }
>> +
>> +       __lpass_get_dmactl_handle(substream, dai, &dmactl, &id);
>> +       if (!dmactl) {
>> +               dev_err(soc_runtime->dev, "failed to get dmactl handle\n");
>> +               return -EINVAL;
>> +       }
>> +       ret = regmap_fields_write(dmactl->codec_channel, id, regval);
>> +       if (ret) {
>> +               dev_err(soc_runtime->dev,
>> +                       "error writing to dmactl codec_channel reg field: %d\n", ret);
>> +               return ret;
>> +       }
>> +       return 0;
>> +}
>> +
>> +static int lpass_cdc_dma_daiops_trigger(struct snd_pcm_substream *substream,
>> +                                   int cmd, struct snd_soc_dai *dai)
>> +{
>> +       struct snd_soc_pcm_runtime *soc_runtime = asoc_substream_to_rtd(substream);
>> +       struct lpaif_dmactl *dmactl;
>> +       int ret = 0, id;
>> +
>> +       switch (cmd) {
>> +       case SNDRV_PCM_TRIGGER_START:
>> +       case SNDRV_PCM_TRIGGER_RESUME:
>> +       case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
>> +               __lpass_platform_codec_intf_init(dai, substream);
>> +               break;
>> +       case SNDRV_PCM_TRIGGER_STOP:
>> +       case SNDRV_PCM_TRIGGER_SUSPEND:
>> +       case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
>> +               __lpass_get_dmactl_handle(substream, dai, &dmactl, &id);
>> +               if (!dmactl) {
>> +                       dev_err(soc_runtime->dev, "failed to get dmactl handle\n");
> This same message is in many places. I really hope it never gets printed
> because finding out which line it got printed at is going to be
> impossible.
Okay. Will add function name in each print.
>
>> +                       return -EINVAL;
>> +               }
>> +               ret = regmap_fields_write(dmactl->codec_enable, id, LPAIF_DMACTL_ENABLE_OFF);
>> +               if (ret) {
>> +                       dev_err(soc_runtime->dev,
>> +                               "error writing to dmactl codec_enable reg: %d\n", ret);
>> +                       return ret;
>> +               }
>> +               break;
>> +       default:
>> +               ret = -EINVAL;
>> +               dev_err(soc_runtime->dev, "%s: invalid %d interface\n", __func__, cmd);
>> +               break;
>> +       }
>> +       return ret;
>> +}
>> +
>> +const struct snd_soc_dai_ops asoc_qcom_lpass_cdc_dma_dai_ops = {
>> +       .startup        = lpass_cdc_dma_daiops_startup,
>> +       .shutdown       = lpass_cdc_dma_daiops_shutdown,
>> +       .hw_params      = lpass_cdc_dma_daiops_hw_params,
>> +       .trigger        = lpass_cdc_dma_daiops_trigger,
>> +};
>> +EXPORT_SYMBOL_GPL(asoc_qcom_lpass_cdc_dma_dai_ops);
>> +
>> +MODULE_DESCRIPTION("QTi LPASS CDC DMA Driver");
>> +MODULE_LICENSE("GPL");
>> diff --git a/sound/soc/qcom/lpass.h b/sound/soc/qcom/lpass.h
>> index e059c4a..d279a72 100644
>> --- a/sound/soc/qcom/lpass.h
>> +++ b/sound/soc/qcom/lpass.h
>> @@ -410,5 +410,6 @@ int asoc_qcom_lpass_cpu_dai_probe(struct snd_soc_dai *dai);
>>   extern const struct snd_soc_dai_ops asoc_qcom_lpass_cpu_dai_ops;
>>   int lpass_cpu_pcm_new(struct snd_soc_pcm_runtime *rtd,
>>                                  struct snd_soc_dai *dai);
>> +extern const struct snd_soc_dai_ops asoc_qcom_lpass_cdc_dma_dai_ops;
>>
>>   #endif /* __LPASS_H__ */
>> --
>> 2.7.4
>>