Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <85740a8e-e654-7742-642f-44d01c323c26@gmail.com>
Date:   Wed, 16 Feb 2022 12:50:41 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH v2 03/15] staging: r8188eu: remove converted DBG_88E calls
 from core/rtw_mlme_ext.c
Content-Language: en-US
To:     Phillip Potter <phil@philpotter.co.uk>, gregkh@linuxfoundation.org
Cc:     dan.carpenter@oracle.com, Larry.Finger@lwfinger.net,
        straube.linux@gmail.com, martin@kaiser.cx,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20220216010709.791-1-phil@philpotter.co.uk>
 <20220216010709.791-4-phil@philpotter.co.uk>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <20220216010709.791-4-phil@philpotter.co.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Phillip,

On 2/16/22 04:06, Phillip Potter wrote:
> Remove all the netdev_dbg/pr_debug calls that were previously converted
> from DBG_88E inside core/rtw_mlme_ext.c. Due to the sheer number of
> lines, this patch is separated out for ease of review. After some thought,
> it makes more sense to just entirely strip all of these calls, so that
> debugging code in the driver can be more consistent and useful going
> forwards.
> 
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>

[code snip]

>   	if (pstat->aid > 0) {
> -		netdev_dbg(padapter->pnetdev, "old AID %d\n", pstat->aid);
>   	} else {

Ok, this one has same issues as 2nd one. I am going to stop reviewing 
this series for now, because looks like I am missing some context...


With regards,
Pavel Skripkin