Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Feb 2022 11:38:30 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     =?utf-8?B?5Ya36Z2Z?= <3090101217@zju.edu.cn>
Cc:     balbi@kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, pavel.hofman@ivitera.com,
        ruslan.bilovol@gmail.com, Jing Leng <jleng@ambarella.com>
Subject: Re: [PATCH v3] usb: gadget: f_uac1: add different speed transfers
 support
Message-ID: <YgzUJhcFk1FAKfJV@kroah.com>
References: <YgprpGbtBpojsCmQ@kroah.com>
 <20220215030848.5709-1-3090101217@zju.edu.cn>
 <Yguz4hOBYTXRL35t@kroah.com>
 <13396706.ae161.17f005864cf.Coremail.3090101217@zju.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <13396706.ae161.17f005864cf.Coremail.3090101217@zju.edu.cn>
Precedence: bulk

On Wed, Feb 16, 2022 at 10:24:27AM +0800, 冷静 wrote:
> Hi Greg KH,
> 
> Sorry for the trouble, as a new contributor to kernel.
> Although I have readed the document that how to submit patches,
> I'm still missing some details.
> 
> > Where is the patch version information?
> The new patch adds more detailed patch description and adds
> 'static' before 'struct usb_ss_ep_comp_descriptor ac_int_ep_desc_comp'.

As the documentation states, that goes below the --- line.

Please look at the hundreds of examples of other patch series being sent
with new versions.  And again, the documentation should show you how to
do this.

> > Why are you setting values to 0 when you do not have to as that is the
> > default value?
> This modification is similar to uac2.
> On page 362 of the USB3.2 specification.
> bMaxBurst is 0 means that no burst transfer.
> bmAttributes is 0 means that no mult.

That is not what I was referring to.  If you do not set a field in a
static structure, it is by default set to 0.  You do not have to define
it again.

thanks,

greg k-h