Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        Xiaoke Wang <xkernel.wang@foxmail.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wfx: check the return value of devm_kmalloc()
Date:   Wed, 16 Feb 2022 12:56:14 +0100
Message-ID: <1660310.YPgQWDYhUI@pc-42>
Organization: Silicon Labs
In-Reply-To: <tencent_BD0AC737C546F88052FF7F11881D3350EE06@qq.com>
References: <tencent_BD0AC737C546F88052FF7F11881D3350EE06@qq.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?2DrZtLQrXL4dDs89Li9Jf9pvxEJo5bzHc/6+jO5gbnYcl29+oK5jhQUETY?=
 =?iso-8859-1?Q?0O29v/YKvjvTVU0+d8B+EPsaJ5HI8Ld6DMvvXBcm7iRP0bM9cckHv+1eWU?=
 =?iso-8859-1?Q?H6NqiOPA/Mfv6S32qbHrSLkEnZMLfvPh+BPNTkNbuGXCi54nqSjGAnbyH4?=
 =?iso-8859-1?Q?gRYHQIiXIgh8hANzo8Ap5nTI/pGlbOl1pPykDGpwRaNCZXCYPiYnsH42Wa?=
 =?iso-8859-1?Q?IVppQpNnCO/Ivq8BBDcsyGbYnqt3M24npiHw/u9ptk4+hcq+fUwkEYqAzF?=
 =?iso-8859-1?Q?LzyWwp9q4Jfd2Bu3qOYP41vPqIWoK/TzkZjqdxebv7lIYvke28926YtVUh?=
 =?iso-8859-1?Q?AIvepy1IFZlSlFKDN1SgdWIqBvz9ASOweaSr26SDFI6CF9js6vE2YE3pfH?=
 =?iso-8859-1?Q?KUmtK5JuxKUIv8eGUL1VeSKIHo2R7yluYmSy+qizQTILs4vyT+txhJDG9E?=
 =?iso-8859-1?Q?VGnwCHxcspr5Y4uyxeFpWiQUOjUAxzDvilht0FaOcWG/KSI/S5fjfar1mH?=
 =?iso-8859-1?Q?Ol+uxOhIPGWrTxTtXoFeoA2EPQq0yeGv6Jh0d+vokK4R1g/b9eDc4GURh+?=
 =?iso-8859-1?Q?FK3a+6HYZOaipVij9+rbeeZVBSwywXa8Q68ZjPPJdTlKf1OKegkL7nBh1a?=
 =?iso-8859-1?Q?3PkI8ZAdZ+1bxWjEssky/d4eaag+z46maVer11O/zId6odAtGLIGctzQEC?=
 =?iso-8859-1?Q?gBTEHPEhmmP9rQwOcqdFJtoIi3DYeKAcffhX9TusP1G+wRNim2+m4fJULG?=
 =?iso-8859-1?Q?AFvsqyBJ2uoHTYWmvuqCTxcKP8qZs83UxnzhWIcgtQr3t4sIhNvwma5COs?=
 =?iso-8859-1?Q?UrcZdTk+SrLJL3skMvvHTstK7Ea7ACyx+GtXfNmmAROL6mO5xFvycq10gf?=
 =?iso-8859-1?Q?J7aSj2gDDhef17poq6qhL07+yhhwdHZMIMMw6fwteqfi0VUCv6s1LS1I1a?=
 =?iso-8859-1?Q?/uHCLS90TC5RmZOlzVERpJWL90a1WPvVjuRWh8f5iSjSEuXYBk0mMi33QZ?=
 =?iso-8859-1?Q?wuJOPMi1wbh+uW9ziKnyepyfGInix5QJU97edu3kG53K8nOe4DXiX50O0M?=
 =?iso-8859-1?Q?u0kKXnL6Hau26mVV5pkNAhj1245cYkNVYdu2+2ui/xzoKeqfpLSM7StLBl?=
 =?iso-8859-1?Q?pb/nigLNm8xqd/dv/LeMyV1gLyVTGV7+DU+UFZqCGnHvTtfwghylvqfZRg?=
 =?iso-8859-1?Q?tzSJ2WVf2yaIFkmB5Xj0yENQfIycu7UHLWbkwYWlmuTh0TEr3wpG604DCw?=
 =?iso-8859-1?Q?Mdu17Gh1Q3URbjs+zLF6ZXIAWX8LW4mM4de2CERC/EWDD9WacKcQqTTsKh?=
 =?iso-8859-1?Q?4U5PDO3elYtEwO5psjVpnyIVFSP+sZPVJRjtObtcnWVCbHSaqCcUZ36Rri?=
 =?iso-8859-1?Q?opc4L60dCZ4mVINxeFSH1UPauesGVzk98XetYB6/e9tRKMOD0HX+EOnf8z?=
 =?iso-8859-1?Q?ABjF7O32pbTXj93jeAtCE8/fS3OPS5So3D7fZU34ysUNWONpnUHF1pJNIs?=
 =?iso-8859-1?Q?a8sVWHRw7lz71Xrv7w+iXh7tVSDGKDX4lgsYkkVPogLHThVwES9AR+7eew?=
 =?iso-8859-1?Q?HL11AIKNMm2XG4alpgs1i2xem/jvCItScYVHxu1Acqii5p4M1pCGsQwZeg?=
 =?iso-8859-1?Q?5EBx4sX+PvBRmKGmw5ra1r5Z2Yl7/bHj72aiYe7+af7pje9a9ROXBYGz4g?=
 =?iso-8859-1?Q?oZ46ZwohmWnW3GOsbd8=3D?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20e3a89e-4551-4b45-7c68-08d9f14358d2
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 11:56:20.9627
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NOkY4K4sxxa6pDPE1bLoakHrbkrI00b3sa3J0ywl5/t4HoNg+SNLKIx/5Dj6v867jtDh3blR7aLhV71CM7Bq7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5133
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 16 February 2022 12:29:50 CET xkernel.wang@foxmail.com wrote:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>=20
> devm_kmalloc() returns a pointer to allocated memory on success, NULL
> on failure. While there is a memory allocation of devm_kmalloc()
> without proper check. It is better to check the return value of it to
> prevent wrong memory access.
>=20
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
>  drivers/staging/wfx/main.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c
> index 4b9fdf9..0ef9225 100644
> --- a/drivers/staging/wfx/main.c
> +++ b/drivers/staging/wfx/main.c
> @@ -294,6 +294,8 @@ struct wfx_dev *wfx_init_common(struct device *dev,
>         hw->wiphy->n_iface_combinations =3D ARRAY_SIZE(wfx_iface_combinat=
ions);
>         hw->wiphy->iface_combinations =3D wfx_iface_combinations;
>         hw->wiphy->bands[NL80211_BAND_2GHZ] =3D devm_kmalloc(dev, sizeof(=
wfx_band_2ghz), GFP_KERNEL);
> +       if (!hw->wiphy->bands[NL80211_BAND_2GHZ])
> +               return NULL;
>         // FIXME: also copy wfx_rates and wfx_2ghz_chantable
>         memcpy(hw->wiphy->bands[NL80211_BAND_2GHZ], &wfx_band_2ghz,
>                sizeof(wfx_band_2ghz));
> --
>=20

Good catch! However, I think you should call ieee80211_free_hw(hw)
before to return.

While reviewing your code, I have noticed that all the error handlers
of this function return without calling ieee80211_free_hw(hw).

--=20
J=E9r=F4me Pouiller