Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of nvidia.com: DNS Timeout)
Message-ID: <0d8cc8c0-31a1-0290-5aa5-0c7b16db1edb@nvidia.com>
Date:   Wed, 16 Feb 2022 18:41:39 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH V1] PCI/ASPM: Save/restore L1SS Capability for
 suspend/resume
Content-Language: en-US
To:     "Kenneth R. Crudup" <kenny@panix.com>,
        Bjorn Helgaas <helgaas@kernel.org>
CC:     <bhelgaas@google.com>, <lorenzo.pieralisi@arm.com>,
        <hkallweit1@gmail.com>, <wangxiongfeng2@huawei.com>,
        <mika.westerberg@linux.intel.com>, <kai.heng.feng@canonical.com>,
        <chris.packham@alliedtelesis.co.nz>, <yangyicong@hisilicon.com>,
        <treding@nvidia.com>, <jonathanh@nvidia.com>, <abhsahu@nvidia.com>,
        <sagupta@nvidia.com>, <linux-pci@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <kthota@nvidia.com>,
        <mmaddireddy@nvidia.com>, <sagar.tv@gmail.com>
References: <20220207163332.GA397884@bhelgaas>
 <79a41832-12e2-2ed-f3af-da3bac90d941@panix.com>
 <3ca14a7-b726-8430-fe61-a3ac183a1088@panix.com>
 <0ccd43af-0293-521b-86d3-ea2ea1c70e5c@nvidia.com>
 <75a48fb6-3913-ccaf-3c-6d41bbbda533@panix.com>
From:   Vidya Sagar <vidyas@nvidia.com>
In-Reply-To: <75a48fb6-3913-ccaf-3c-6d41bbbda533@panix.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 13:11:49.0776
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 28daed99-0dde-4d35-8772-08d9f14de429
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.238];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT020.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4245
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/16/2022 11:30 AM, Kenneth R. Crudup wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Wed, 16 Feb 2022, Vidya Sagar wrote:
> 
>> I see that the ASPM-L1 state of Realtek NIC which was in disabled state before
>> hibernate got enabled after hibernate.
> 
> That's actually my SD-Card reader; there's a good chance the BIOS does "something"
> to it at boot time, as it's possible to boot from SD-Card on my laptop.
> 
>> This patch doesn't do anything to LnkCtl register which has control for ASPM L1
>> state.
> 
>> Could you please check why ASPM L1 got enabled post hibernation?
> 
> I wouldn't know how to do that; if you're still interested in that let me know
> what to do to determine that.
I would like Bjorn to take a call on it.
At this point, there are contradictions in observations.
Just to summarize,
- The root ports in your laptop don't have support for L1SS
- With the same old code base with which the errors were observed plus 
my patch on top of it, I see that ASPM-L1 state getting enabled for one 
of the endpoints (Realtek SD-Card reader) after system comes out of 
hibernation even though ASPM-L1 was disabled before the system enter 
into hibernation. No errors are reported now.
- With the linux-next top of the tree plus my patch, no change in the 
ASPM states and no errors also reported.

This points to BIOS being buggy (both old and new with new one being 
less problematic)

Bjorn, what are your comments on it?

> 
>          -Kenny
> 
> --
> Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange County CA
>