Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Feb 2022 10:38:43 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     tangmeng <tangmeng@uniontech.com>
Cc:     peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@redhat.com,
        namhyung@kernel.org, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] perf tools: Remove redundant err variable
Message-ID: <Ygz+Y0uaXRY8tibF@kernel.org>
References: <20220216030425.27779-1-tangmeng@uniontech.com>
 <20220216030425.27779-2-tangmeng@uniontech.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220216030425.27779-2-tangmeng@uniontech.com>
Precedence: bulk

Em Wed, Feb 16, 2022 at 11:04:25AM +0800, tangmeng escreveu:
> The variable err in the perf_event__process_sample is only used
> in the only one judgment statement, it is not used in other places.
> 
> So, use the return value from hist_entry_iter__add() directly
> instead of taking this in another redundant variable.

Thanks, applied.

- Arnaldo

 
> Signed-off-by: tangmeng <tangmeng@uniontech.com>
> ---
>  tools/perf/builtin-top.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index 1fc390f136dd..3c8c60b7f6f0 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -746,7 +746,6 @@ static void perf_event__process_sample(struct perf_tool *tool,
>  {
>  	struct perf_top *top = container_of(tool, struct perf_top, tool);
>  	struct addr_location al;
> -	int err;
>  
>  	if (!machine && perf_guest) {
>  		static struct intlist *seen;
> @@ -839,8 +838,7 @@ static void perf_event__process_sample(struct perf_tool *tool,
>  
>  		pthread_mutex_lock(&hists->lock);
>  
> -		err = hist_entry_iter__add(&iter, &al, top->max_stack, top);
> -		if (err < 0)
> +		if (hist_entry_iter__add(&iter, &al, top->max_stack, top) < 0)
>  			pr_err("Problem incrementing symbol period, skipping event\n");
>  
>  		pthread_mutex_unlock(&hists->lock);
> -- 
> 2.20.1
> 
> 

-- 

- Arnaldo