Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Feb 2022 16:30:34 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     Yang Li <yang.lee@linux.alibaba.com>
cc:     benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] HID: i2c-hid: remove unneeded semicolon
In-Reply-To: <20220216015042.113021-1-yang.lee@linux.alibaba.com>
Message-ID: <nycvar.YFH.7.76.2202161630200.11721@cbobk.fhfr.pm>
References: <20220216015042.113021-1-yang.lee@linux.alibaba.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 16 Feb 2022, Yang Li wrote:

> Eliminate the following coccicheck warning:
> ./drivers/hid/i2c-hid/i2c-hid-core.c:357:56-57: Unneeded semicolon
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/hid/i2c-hid/i2c-hid-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index 91b2fa0d33c7..c078f09a2318 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -354,7 +354,7 @@ static int i2c_hid_set_or_send_report(struct i2c_hid *ihid,
>  		 * With simple "send report" all data goes into the output
>  		 * register.
>  		 */
> -		*(__le16 *)ihid->cmdbuf = ihid->hdesc.wOutputRegister;;
> +		*(__le16 *)ihid->cmdbuf = ihid->hdesc.wOutputRegister;
>  		length += sizeof(__le16);
>  	}

Thanks, that was me fat-fingering the fixup in the original patch. 
Applied.

-- 
Jiri Kosina
SUSE Labs