Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Feb 2022 16:50:17 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     =?ISO-8859-15?Q?Jos=E9_Exp=F3sito?= <jose.exposito89@gmail.com>
cc:     benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Magic Keyboard first generation and 2015 FN key
 mapping
In-Reply-To: <20220208183704.40101-1-jose.exposito89@gmail.com>
Message-ID: <nycvar.YFH.7.76.2202161650050.11721@cbobk.fhfr.pm>
References: <20220208183704.40101-1-jose.exposito89@gmail.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, 8 Feb 2022, José Expósito wrote:

> Hi everyone,
> 
> This patchset adds the missing key mapping for the Magic Keyboard first
> generation and the 2015 models.
> 
> Since the first generation model had numlock emulation in place, I
> decided to fix the bug (described in the patch) and keep it in place
> just because it has been there for so long that people might use it.
> Having said that, there is no indication in the keyboard about which
> keys can be used as numbers or how to enable/disable numlock.
> I think that a patch removing APPLE_NUMLOCK_EMULATION might make sense,
> but I didn't want to remove existing functionality without asking :)
> 
> Thanks a lot,
> José Expósito
> 
> v2: Resolve conflicts

Queued in hid.git#for-5.18/apple. Thanks José,

-- 
Jiri Kosina
SUSE Labs