Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Feb 2022 10:39:41 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     tangmeng <tangmeng@uniontech.com>
Cc:     peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@redhat.com,
        namhyung@kernel.org, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] perf tools: Remove redundant ret variable
Message-ID: <Ygz+nQksMpsorTC8@kernel.org>
References: <20220216030425.27779-1-tangmeng@uniontech.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220216030425.27779-1-tangmeng@uniontech.com>
Precedence: bulk

Em Wed, Feb 16, 2022 at 11:04:24AM +0800, tangmeng escreveu:
> Return value from hist_entry_iter__add() directly instead
> of taking this in another redundant variable.

Thanks, applied.

- Arnaldo

 
> Signed-off-by: tangmeng <tangmeng@uniontech.com>
> ---
>  tools/perf/builtin-annotate.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
> index 490bb9b8cf17..e347b8ef088f 100644
> --- a/tools/perf/builtin-annotate.c
> +++ b/tools/perf/builtin-annotate.c
> @@ -190,7 +190,6 @@ static int process_branch_callback(struct evsel *evsel,
>  	};
>  
>  	struct addr_location a;
> -	int ret;
>  
>  	if (machine__resolve(machine, &a, sample) < 0)
>  		return -1;
> @@ -203,8 +202,7 @@ static int process_branch_callback(struct evsel *evsel,
>  
>  	hist__account_cycles(sample->branch_stack, al, sample, false, NULL);
>  
> -	ret = hist_entry_iter__add(&iter, &a, PERF_MAX_STACK_DEPTH, ann);
> -	return ret;
> +	return hist_entry_iter__add(&iter, &a, PERF_MAX_STACK_DEPTH, ann);
>  }
>  
>  static bool has_annotation(struct perf_annotate *ann)
> -- 
> 2.20.1
> 
> 

-- 

- Arnaldo