Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Feb 2022 07:37:14 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Michael Walle <michael@walle.cc>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: ocelot: fix confops resource index
Message-ID: <20220216153714.GA14638@MSI.localdomain>
References: <20220216082020.981797-1-michael@walle.cc>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220216082020.981797-1-michael@walle.cc>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+0A7zFdJrK7SGk7rtH+2QK1AgVsmu3uEhWEHNyvp+RU76Ji8lvj3/N1nmMam?=
 =?us-ascii?Q?juQM7slgAgg4Rw1F3IC49fVJo4qJWlryQndHA8/xy+O6g1JzSDBFzBqThbMB?=
 =?us-ascii?Q?PXr1KmopbSSRcIf6JWPbikqpzevH6lzN2FiV/CF/NuQl51Cnc7WiWRsTd9/F?=
 =?us-ascii?Q?ezB+hcQyGRqR7UpDlPzdueDk6P5YxMxGj7t6o/IgadSlpwh+uPHVd2kqqYYU?=
 =?us-ascii?Q?xqggNqiVbSU3DzKca5sFPt/nsTnwVzdO2vwVQZYlEKKT/c0mj/ZJfUlvFKSz?=
 =?us-ascii?Q?63pnf/uj/ZjJYdeo+ILIICSGbSHR2S6Hox6k9RanmQspHTj/rA8wFP5KA1xL?=
 =?us-ascii?Q?lRDQ+iUnIcH85HOFdElQhxkiOzfwj+Zk/O6HaouV6ppFLL6SpYv66spHXz/V?=
 =?us-ascii?Q?JNje8EBTAcSVIS7fueYh3CoOdSIy+sZ19SUl3SNQS+T+Ld1K3MWLPvVh271I?=
 =?us-ascii?Q?+d4yBDLCklo1G6SIPjnPsDYIs/uDyDI/ePt6MqkrFzqCRFfKVreyRTxwEMKG?=
 =?us-ascii?Q?bLsV3fd/2amLBx1SvKGZQ/YgHbyRHLu9xjKjsSwfDQIDFTbmHRwNl6HOen4o?=
 =?us-ascii?Q?C0d/3GaYQazhpOQMPE2dOB217s3nahu4UHnN7Vk0OSrJTW20rAzVQ1WwhXm8?=
 =?us-ascii?Q?Jd+xZ6lDz0xdF4mv27PueJHiD/jcFSifn1sSb/6mo2cwR5usxjrKGHXiw6kX?=
 =?us-ascii?Q?vGzmBGpwlPJe0FmXqAoUD2wnxSL5jK9UE+2JeavF3Zb7t6Ti9HMZEmtQ21L2?=
 =?us-ascii?Q?wMe/9rXSTuiOFDWRM/xvHWpBQiQGoVeYxQIvXkGKer+5tk5EEG4SXBivP5Oo?=
 =?us-ascii?Q?OyvlLNQZ0l1/HMGORoHWAeaUHrVXbrvsKzLPvN4oIwICaM0Beenr4B5zfeJz?=
 =?us-ascii?Q?MwCmniyGq9igb42XckiTSdBRKjf3IZZ+WuwtNq2Xy6hSYgd93EeRS9JzdJYx?=
 =?us-ascii?Q?/PNSwQ7Qf6SzqsUGreVcbUskTnfM+rfHGPr9NFLflhzKgmJ9plYRHIvffK2r?=
 =?us-ascii?Q?yW4F5G7C+1xQ1KyYWZKcPZcASuHBKP2c3jwwjTsp1qrIEqvI1TgUsDhfMDIN?=
 =?us-ascii?Q?/vWuF0mEKnY/7vC7W8vVW/3dEfa1W7mnY8XwmqX0nqB2bf9neVOw4xrrHQTg?=
 =?us-ascii?Q?Qi0ZcFGib6X/HKb0vxqZwWDPZo+ndtjXXC30RmMFw7RrOPRCOyFFYcZGjp5u?=
 =?us-ascii?Q?ke2AGpc+ZThRO4HMFkDYunX8wGeJk0x9VQNGbreFU8Ti76cYs2IqNn3u27F4?=
 =?us-ascii?Q?vBhLjtJvXAmNMH5nW9mJrdw6QfuL6jlVipbh2nteTHhob6Sqq/WbFB4h33dU?=
 =?us-ascii?Q?GI/LLgMepCT2ZcJBF7wnOyun/KbS0wcFrM213EBw/hyL6tevi3x+Z8jca3lf?=
 =?us-ascii?Q?vtkwhiPW/Im6eFQ41ips3a0w0SNWzoi5nDx43PLZ9XQIEW+BhL6xc8vKRKF6?=
 =?us-ascii?Q?qyZTqE5QCSCy7vvaPjeS1VMck8+g91dHH7W46gKkpQsiMIgtO7nsCfJSvld6?=
 =?us-ascii?Q?aI1LmbRQq6ovfGfzROsAFxfrJnx0ufbOo2S+fBMJVEk7RxfiK4YPKVzceDJu?=
 =?us-ascii?Q?+BLT6ISR5tPfPn9W3i0itg68jJWUemVjnEALvgRT8awgGR0lF81XGMizjEcr?=
 =?us-ascii?Q?jnjbf56irRuEVLWcLT09e7VUk3DHs0DEkBRbrWhxVYpVGr5Xi0sctFWispZp?=
 =?us-ascii?Q?p66yRQ=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a9f0b62-5668-44d1-051f-08d9f1624581
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 15:37:42.9495
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qJVSa4OCmopl+jRRyleeW+188trlY2Q0v67Vc5LUo3+mD3Jiv3lyZv8xzza5aQst4juLrEC5evJUL4f6a/KNOuf/EH9672svRczuchjGRU8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4277
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Michael,

On Wed, Feb 16, 2022 at 09:20:20AM +0100, Michael Walle wrote:
> Prior to commit ad96111e658a ("pinctrl: ocelot: combine get resource and
> ioremap into single call") the resource index was 1, now it is 0. But 0
> is the base region for the pinctrl block. Fix it.
> I noticed this because there was an error that the memory region was
> ioremapped twice.

My apologies... I missed this and didn't have access to hardware to
test. Thanks for the fix.

Reviewed-by: Colin Foster <colin.foster@in-advantage.com>


> 
> Fixes: ad96111e658a ("pinctrl: ocelot: combine get resource and ioremap into single call")
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  drivers/pinctrl/pinctrl-ocelot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c
> index 685c79e08d40..a859fbcb09af 100644
> --- a/drivers/pinctrl/pinctrl-ocelot.c
> +++ b/drivers/pinctrl/pinctrl-ocelot.c
> @@ -1892,7 +1892,7 @@ static struct regmap *ocelot_pinctrl_create_pincfg(struct platform_device *pdev)
>  		.max_register = 32,
>  	};
>  
> -	base = devm_platform_ioremap_resource(pdev, 0);
> +	base = devm_platform_ioremap_resource(pdev, 1);
>  	if (IS_ERR(base)) {
>  		dev_dbg(&pdev->dev, "Failed to ioremap config registers (no extended pinconf)\n");
>  		return NULL;
> -- 
> 2.30.2
>