Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp1025434pxb; Wed, 16 Feb 2022 09:17:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJxxJXbZ8Hzs5M8rlQBVvFfnnScpJs992bfOouH8F65mGG1yibUKp3qn7wJodTKllZwdcyvB X-Received: by 2002:a17:906:edbd:b0:6b6:bd54:235c with SMTP id sa29-20020a170906edbd00b006b6bd54235cmr3118805ejb.363.1645031872045; Wed, 16 Feb 2022 09:17:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645031872; cv=none; d=google.com; s=arc-20160816; b=tQ61PlL64cv4NVX0cpPwthNDgOiOcPQVJih1ZG4ElogR0EXi7WWES8f78hwQuG/D7O NLxrT9KSkpHsgoaYo1c1ALeqV6GuS5vMeNWAeYAwm3bXFiWGcdTvIXDA5JZXPi5Ah7Y4 mjaDUC1dlbO0HMmoA7VyfqQXRwSlZrPwmhvnCbm5w+A3ULJg+jpKkynZUoGXGrHDRSad 7reauMyYiRuNpLc4JnplGhp3oarsymDQ6nvnbD97Vj46nnWpRT/NhYLvZxGIlhaDOuGa 8H/1dWA9fg3l07QkFnm9QhSsnRs3A9meOD+YuPa2h9pYid3MeT04KO1bYjxMyH1SL6Dt WFZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=XvA8U4SyXCnsVseKo1yffsTrzZzqNOcqdAeYZByR8+I=; b=xYEQOg70fgMolRpiSCcDyXqcBALo7UBUW0IRAT64Bgnl/J1rzF2bPvNI6WH7cT5kOQ b0TVBB0GdCbbmXO5KI8aCN1yZP51qhfLHNWYE9+/UlJaoX+aIPopcpxAUdSg/LjGf+Rc kZghta76iO5GE9DstXuazVninwl7a76zXwl0yfC1UjWabMp7rWM1wohOEuvL7yk8btwv 86S5haLVXFYx77qyRSwRbZBO2u5QCDcSzFNaDxVwzUviHIngI9uaLIU4K/+5yD5GYFQH 7mSqrWqyJ8v6lKdVf528+FOS8ORRL0VQ0OGFrXQeYkJSbmibLqyKel7FrEzFX7W69GSz UtEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=2Q53fou1; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id di2si198725ejc.796.2022.02.16.09.17.25; Wed, 16 Feb 2022 09:17:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=2Q53fou1; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235686AbiBPPpv (ORCPT + 99 others); Wed, 16 Feb 2022 10:45:51 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:33288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235698AbiBPPpp (ORCPT ); Wed, 16 Feb 2022 10:45:45 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB1EC2A5989 for ; Wed, 16 Feb 2022 07:45:32 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7B2BF1F37D; Wed, 16 Feb 2022 15:45:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1645026331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XvA8U4SyXCnsVseKo1yffsTrzZzqNOcqdAeYZByR8+I=; b=2Q53fou1I48/b1Noz3GJHj2JY6/nWjIJJ+yDMxryp4s/5pMmCaulIVGCad2VVPQx0If1LA foqCjjalX8Wp0ydrU0Iwo/4IXdFsACip3D2cCcNyZmm0OqKU8JKNSnFwG5FU3ZtwqqbmEb TCIy3qr/Q5KA3ozi4L7wN0O6px6ky44= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1645026331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XvA8U4SyXCnsVseKo1yffsTrzZzqNOcqdAeYZByR8+I=; b=SAwW6Ub/Lwy40IYtgZGqLS7p8pjgIXHY5OVO945Ls+lkhtVrgLIZRqD6vw6s0fz5m+QyaJ L08F7rfWSp7Bi+DA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EE23C13B15; Wed, 16 Feb 2022 15:45:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qUoSNxocDWJxOgAAMHmgww (envelope-from ); Wed, 16 Feb 2022 15:45:30 +0000 Date: Wed, 16 Feb 2022 16:45:29 +0100 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Rafael J. Wysocki" , Greg Kroah-Hartman , Michal Hocko , Rafael Parra Subject: Re: [PATCH v2 2/2] drivers/base/memory: determine and store zone for single-zone memory blocks Message-ID: References: <20220210184359.235565-1-david@redhat.com> <20220210184359.235565-3-david@redhat.com> <9738c049-a6a2-19f7-f9be-e7ae98c2c66b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9738c049-a6a2-19f7-f9be-e7ae98c2c66b@redhat.com> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 16, 2022 at 02:46:56PM +0100, David Hildenbrand wrote: > And yes, add_memory_block() chould __init, that would also make it > clearer out of which context init_memory_block() is called with > MEM_ONLINE. I can send an addon patch for that! Yeah, I think that would have helped me, and it definitely makes it more clear, so go ahead ;-) -- Oscar Salvador SUSE Labs