Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Feb 2022 07:42:02 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Michael Walle <michael@walle.cc>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: ocelot: fix duplicate debugfs entry
Message-ID: <20220216154202.GB14638@MSI.localdomain>
References: <20220216122727.1005041-1-michael@walle.cc>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220216122727.1005041-1-michael@walle.cc>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3KJTwzBkOsCtYD/t4LiUcplPoTG3uTlhAQZW4bkbzoyOSpVONTd4tpHrNMLh?=
 =?us-ascii?Q?j80PDTs8lZYeA1tnyLs2QIwTNsnTiB7aplqQpEz1H0ipNZ3T7tK4h02sTLT+?=
 =?us-ascii?Q?YyQKHQgeTExOG6lofK/saHUrcyk+kS1vK0UOp/LMxbKIS6bCBMMawx0T4ufS?=
 =?us-ascii?Q?nK1tcW9JOzbGJRQ8elm9SG3SwLFEsVCVdYbuckoel5W9zXUTVi80AFq2Mw3D?=
 =?us-ascii?Q?rn77KfbYIuUZUFtgES9XpfBlyWcJu95YCB8l00kvSZj/Cc1VTRZZX+QkmxZR?=
 =?us-ascii?Q?KYB65HG6i9I6uWaKEgBCdlTrFzONQsclVfekQHLNT5Glq/094o6Cp5H5EYqj?=
 =?us-ascii?Q?se01hMKJCTQrCw4vrTNcJ9qj7UZVEEgUt5e+2Nmfctnnx4dq3csphjcOmqeV?=
 =?us-ascii?Q?qh5sA7n2vTe6dWMpM+bqgjC8Tqt7pHktrOxebx6O5hEFx6YRVxtGRP1u0kT0?=
 =?us-ascii?Q?SHopMe2huebijUVCv761RI03Di6nEFCbVjzbMVqm/zMCbphdL28FjzMPiwQN?=
 =?us-ascii?Q?zTyNioZQU7GGtZJPV6+i8g406eCzMBgpBpdccJfUn6vwNrghTEPyOnhS1OAN?=
 =?us-ascii?Q?X1cKl6cfh+YQ8tk18uuWfWkfi0nUbR+UGpmdYMre85wHxpSponV4sWLqLX8S?=
 =?us-ascii?Q?ikxa5ekzQy/OLQQSLtD20FtyIRDqz0U1L+6zaqVUS/Gor7CB8T3plZcufgXT?=
 =?us-ascii?Q?uIWhbw5u/CkRxYW5ZZklKW85dk/LhvM/yQm5+5mYML5PF0trXrmW59PvuJU7?=
 =?us-ascii?Q?wId8kkHTG0vpso57jRtqkt7br+dsrnwoi8U/HkRUw7JQx4ccl+e4kYnxPIU+?=
 =?us-ascii?Q?qA3LDwtXTPta85n/mU1Xq8LaZOsVeRWMSKX79FyHPFl5QDQxVtRFQM2yejCD?=
 =?us-ascii?Q?mPYhkNIFcCFwRe5f09stfVnp2CFU8i94bps7nf8ck3rHIkjkYP7iw9RTBnol?=
 =?us-ascii?Q?XxWKpfZz8LqD5fwErhcVYCgMIJEjOZ0g5HQ6+THYnA41GH22wW2fop4nWC99?=
 =?us-ascii?Q?Ic+i/C4Att496Tk3msJKOo6lIV4Kap9sA8NdJ5x7ENo1tSv/cVMjODNxdvju?=
 =?us-ascii?Q?uR5Tz/HnYUVvEf1VtAzAEYBozJIJSjjCoZyGCo1tSQ1FL348y1QUTaDsj/ue?=
 =?us-ascii?Q?xsA3vixoru3m+iiTrVkNeQIYTm31eeDT5+1jXnR7drcaC1vR12g5WIUGTS4P?=
 =?us-ascii?Q?bCkpYIvHczA30XPWEiPtZvR3398fRyXYfjpndje6ZBuXdq8ejHupRlPgBCFU?=
 =?us-ascii?Q?G/JP+C3i6lq3fGmvZT8w/vKQIvevLA9ARSar7+eHOIJDB2XPkipCKDuGgAnA?=
 =?us-ascii?Q?LtQ5wF5ZXHlikZ3kHdOUOXjNVa+ozP5BxQnYWGNhLO8+2DWLx/5FXks+afqk?=
 =?us-ascii?Q?STF8gDDz249s0w77+eoGomsAJEo1wEaPGlw/wI2inlLFofT8zww083ZWCZYb?=
 =?us-ascii?Q?jbE2rFUQH/uSNU0QqhzUWhI+rTa/hia2dg+ylXsgUxSX5z19sBYspEKIPsEc?=
 =?us-ascii?Q?wdmjDcjz63EjjyCHcfnkc8RBYn5E2I1bH8shj1qAYkRaz2B6WxHuhGlLCUPT?=
 =?us-ascii?Q?DspXLxuPrcAvF3M2bclirbef72vJhpL8HxdBDNnQY8oVZTMzigyhq5YfFtV4?=
 =?us-ascii?Q?FRYml1IH1nCoWMvxRAQPjh4vm7VZmYSkJvzL8CdGFCusZyQE6q1vhRFpnka1?=
 =?us-ascii?Q?XAwPSg=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd910efc-c6fd-4963-4944-08d9f162ebc5
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 15:42:21.6174
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Nr68OyhbUW6ed6SPFWrimkvFWXkL89MOjavhjAfifZdQV7fViq76iLHH6JZPJxHypC61VR27Oun3eb/f0XKtE743cR6I7398VYCY6nQfTek=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB2016
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 16, 2022 at 01:27:27PM +0100, Michael Walle wrote:
> This driver can have up to two regmaps. If the second one is registered
> its debugfs entry will have the same name as the first one and the
> following error will be printed:
> 
> [    2.242568] debugfs: Directory 'e2004064.pinctrl' with parent 'regmap' already present!
> 
> Give the second regmap a name to avoid this.
> 
> Fixes: 076d9e71bcf8 ("pinctrl: ocelot: convert pinctrl to regmap")
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  drivers/pinctrl/pinctrl-ocelot.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c
> index a859fbcb09af..35b213de1af8 100644
> --- a/drivers/pinctrl/pinctrl-ocelot.c
> +++ b/drivers/pinctrl/pinctrl-ocelot.c
> @@ -1890,6 +1890,7 @@ static struct regmap *ocelot_pinctrl_create_pincfg(struct platform_device *pdev)
>  		.val_bits = 32,
>  		.reg_stride = 4,
>  		.max_register = 32,
> +		.name = "pincfg",
>  	};
>  
>  	base = devm_platform_ioremap_resource(pdev, 1);
> -- 
> 2.30.2
> 

Reviewed-by: Colin Foster <colin.foster@in-advantage.com>