Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Feb 2022 16:26:00 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     Nestor Lopez Casado <nlopezcasad@logitech.com>
cc:     =?ISO-8859-15?Q?Filipe_La=EDns?= <lains@riseup.net>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Lucas Zampieri <lzampier@redhat.com>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: logitech-dj: add new lightspeed receiver id
In-Reply-To: <CAE7qMro-ies_7DXhvqWE=aNhGcZKTFGxj9xmU38w12jHTOWbmA@mail.gmail.com>
Message-ID: <nycvar.YFH.7.76.2202161625300.11721@cbobk.fhfr.pm>
References: <20220126144400.130797-1-lzampier@redhat.com> <CAO-hwJ+KyV+Ks38DDF8EuT9kEc9jd9SvNn=nGyTwjkD3GOQ+RA@mail.gmail.com> <15ef80cc2ecdcc993043aa0c1d5ea88f41f9b67b.camel@riseup.net> <CAE7qMro-ies_7DXhvqWE=aNhGcZKTFGxj9xmU38w12jHTOWbmA@mail.gmail.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 15 Feb 2022, Nestor Lopez Casado wrote:

> > > > As of logitech lightspeed receiver fw version 04.02.B0009,
> > > > HIDPP_PARAM_DEVICE_INFO is being reported as 0x11.
> > > >
> > > > With patch "HID: logitech-dj: add support for the new lightspeed receiver
> > > > iteration", the mouse starts to error out with:
> > > >   logitech-djreceiver: unusable device of type UNKNOWN (0x011) connected on
> > > >   slot 1
> > > > and becomes unusable.
> > > >
> > > > This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B0018.
> > >
> > > The patch looks good to me.
> > >
> > > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > >
> > > Ideally, Nestor, can you confirm this is expected and that we won't
> > > have any bad surprises there?
> Yes, I confirm this matches our specifications, this is an iteration
> of Lightspeed 1.2
> No objections on my side.

Thanks. Based on this, I've applied this with

	Acked-by: Nestor Lopez Casado <nlopezcasad@logitech.com>

then. Please shout out loudly if you're not ok with that :)

-- 
Jiri Kosina
SUSE Labs