Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 16 Feb 2022 16:58:58 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Prasad Kumpatla <quic_pkumpatl@quicinc.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        "Srinivas Kandagatla =?ISO-8859-1?Q?=20=1B?= [ 
        =?ISO-8859-1?Q?=20B=1B?= [ =?ISO-8859-1?Q?=20B?= =?ISO-8859-1?Q?=1B?= [
        B" <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH] regmap-irq: Update interrupt clear register for proper
 reset
Message-ID: <Yg0tUlQ/Qs8AHa4O@sirena.org.uk>
References: <20220216100026.25543-1-quic_pkumpatl@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fzypM6lEStJ0CbMn"
Content-Disposition: inline
In-Reply-To: <20220216100026.25543-1-quic_pkumpatl@quicinc.com>
Precedence: bulk


--fzypM6lEStJ0CbMn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 16, 2022 at 03:30:26PM +0530, Prasad Kumpatla wrote:
> With the existing logic where clear_ack is true, interrupt clear register
> reset is not handled properly. Due to this only the first interrupts get
> processed properly and further interrupts are blocked due to interrupt
> clear register is not reset. So writing 0x00 and 0xff(when ack_invert is
> true) should have no effect, other than clearing the ACKs just set.

This commit log still has the problem that it's not clearly describing
the problem and I've forgotten again - in what way is the interrupt
clear reset not handled properly?  What should happen and what does
happen?

>  				if (d->chip->ack_invert && !ret)
> -					ret = regmap_write(map, reg,
> -							   d->mask_buf[i]);
> +					ret = regmap_write(map, reg, 0xff);

Why only 0xff and not UINT_MAX?

>  				else if (!ret)
> -					ret = regmap_write(map, reg,
> -							   ~d->mask_buf[i]);
> +					ret = regmap_write(map, reg, 0x00);

Please write 0 normally, no need for 00.

--fzypM6lEStJ0CbMn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmINLVEACgkQJNaLcl1U
h9D09gf+JwEZ6LxLtPsYZXopIjju84kxjtJWT/2+YUa7DqB63ObSech/ypG7TLS7
dj1SjI1wQMNn6G0gMk9q7RiViuofuaOA/N+BHzKzxkeOvilqrYSFdlU8awS7w5RN
bhpXnTHpFbOK+ZwKefWjmXrTfevs73AktezrcLVhOhhsb+Yl45MEQr8U+slkJHVw
nPCMX+s5bfuGHJR/tky4wjbGmkdcKJx6VeceCnocaUKJ+EnD/QvMvvRD8akVVAh7
+zhBTbCbmEdKU0qfbJJQeiYZgIsqcxO4fXpe5sKdIOkw3N1IFW+ddwbAd2ZzeP/J
outZ+EETI+BnwvdyrHK7D9Rr+d83fA==
=tJhS
-----END PGP SIGNATURE-----

--fzypM6lEStJ0CbMn--