Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220216062615.779778-1-ztong0001@gmail.com> <CAJZ5v0hsDVqZM=iP=4CYhGT99ScQ1xQNYHKcdJHHCscEhXOoCA@mail.gmail.com>
In-Reply-To: <CAJZ5v0hsDVqZM=iP=4CYhGT99ScQ1xQNYHKcdJHHCscEhXOoCA@mail.gmail.com>
From:   Tong Zhang <ztong0001@gmail.com>
Date:   Wed, 16 Feb 2022 08:37:28 -0800
Message-ID: <CAA5qM4Bzdctm61jMgkRdKkSqqk7LZqsHUqpn1Loo85eiQUzkxQ@mail.gmail.com>
Subject: Re: [PATCH] ACPICA: proactively check null ptr to avoid API misuse
To:     "Rafael J. Wysocki" <rafael@kernel.org>
Cc:     Robert Moore <robert.moore@intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Len Brown <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@acpica.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Feb 16, 2022 at 4:22 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Wed, Feb 16, 2022 at 7:26 AM Tong Zhang <ztong0001@gmail.com> wrote:
> >
> > There are some cases that user use acpi_ns_walk_namespace() without
> > checking acpi_disable flag. When acpi=off is provided in boot cmdline,
> > acpi_gbl_root_node is NULL and calling acpi_ns_walk_namespace() will
> > crash kernel. In order to avoid such misuse, we proactively check null ptr
> > and return an error when we know ACPI is disabled.
>
> The issue should be fixed by this commit in the upstream ACPICA code
> base: https://github.com/acpica/acpica/commit/b1c3656ef4950098e530be68d4b589584f06cddc
>
Thank you Rafael. I've just seen that commit upstream.