Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <91fd3b35-b791-af37-6663-9c37055f339e@intel.com>
Date:   Wed, 16 Feb 2022 16:25:24 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.6.0
Subject: Re: [PATCH V3] x86/sgx: Add poison handling to reclaimer
Content-Language: en-US
From:   Reinette Chatre <reinette.chatre@intel.com>
To:     <tony.luck@intel.com>, <dave.hansen@linux.intel.com>,
        <jarkko@kernel.org>, <tglx@linutronix.de>, <bp@alien8.de>,
        <luto@kernel.org>, <mingo@redhat.com>, <linux-sgx@vger.kernel.org>,
        <x86@kernel.org>
CC:     <linux-kernel@vger.kernel.org>
References: <dcc95eb2aaefb042527ac50d0a50738c7c160dac.1643830353.git.reinette.chatre@intel.com>
In-Reply-To: <dcc95eb2aaefb042527ac50d0a50738c7c160dac.1643830353.git.reinette.chatre@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0p2QmQ1L0NWL2pwUkhJTFJsZVIxRTdTUjNhUjNrbXVwT3pUQVBTSE1TWVJG?=
 =?utf-8?B?RWVWY1Z6MFVPVzFlV0RoODRnZHVhaXBVa2FUUG1lUlRWcHFYeFN3V0RZM09W?=
 =?utf-8?B?TEx2aUZCQnArcllobkI5SVVLWUlXdGhXSHNvc0JnMzFSclFKdWNhdmY2UUww?=
 =?utf-8?B?TkdIcUNmSnIwRjZqaGlrb1VSSlo0SXVnMWJvczRCL2FvYk10ZEJHa3k2REFR?=
 =?utf-8?B?NTJrUVlWSG5oMElzL1FENm9CREhUc1FibDRYMUY3aFhUeEZDWXV0bGxHVW51?=
 =?utf-8?B?amR2VVFBQ05laDNsSVN2cG9kTlNpZFRlSWZYcDZBS0Rzd25UQ2IySVJYVkts?=
 =?utf-8?B?TElydCtjQy9Ka2Ztb2d1dFhPVmNFKzJnUEVNMmpTZGEvU2tNME5mMnJwUEJD?=
 =?utf-8?B?MENSdFlnN0Z6YWRYcHNjL0JHWHdYODlkam13cXV5dllCeGd1bkhNeWlvNW8y?=
 =?utf-8?B?aE94TDBLVTVxTU84ZmlnYnpaZXhqQVhGMkFibUxNUFN6QnRFZmJtRSs2UVg2?=
 =?utf-8?B?M3VJbGpnazdGUUtQVU1KN0N0YmEwMHVmQ0NSaUo4YVpMd0NxcHo1ODdUOTdO?=
 =?utf-8?B?UytiSXpXQkNKcm8vUVVjeFlrNTlaYXh1LzFqb00vaGZOSHlTRG4yVitkVUZJ?=
 =?utf-8?B?QUFQbVFRajNwQUZab0FsY0lGTDBiUUsweHh3aERiNXFqY09PVWJpUjJEaUts?=
 =?utf-8?B?aGoraWFOR000YzBaMzg4Rk1NVElNK0JoOG4xdFM1Z0picWh2NmRWNENGbWky?=
 =?utf-8?B?K3FuWnZxZ1AyMVd6TWxPNStRZk5zQTRtNzdVTUVOdU5GWDR2ZmVXZlI3dlFv?=
 =?utf-8?B?UUdhY3prUU9nckwvWm8xb1JUdnNiQlBGMUYxQTJKczl0dmtvTS8wZWs2T2xB?=
 =?utf-8?B?UEZNd25rQTJRR1JxVmRlYUppQ3JNZ2FoeERhSlNRV2RNY1M1WEJtZDVxNUV1?=
 =?utf-8?B?Y3FuTlN0d0t0Q1JieXp4Yld4d0o3U3FrMGpnb0dYbVBYdkR3d0JVVUR5NVln?=
 =?utf-8?B?ckQ2TDFmaVpoQ3BoWnFyejBDN1hjeEtrY1FyTWtmMDV1c1paYmg5WVFjN1pr?=
 =?utf-8?B?b2xjUWxqTUw3TStYTDV1UGJid2UvMlFERk1vd1p5Tnhycks3SG9XNVd6c3lM?=
 =?utf-8?B?a0FzeU50YUlvYWYxbEVTZTBiTEVVZEFRaGJVZjRYMi9EMWRMRW5pTGluc2Jv?=
 =?utf-8?B?TDZRaHBmMUtsSkVFakxyc2taTlBpWjB2K0xUbGZQQi9PeEIxM1ZVQ2R1SXZn?=
 =?utf-8?B?NnI5WGpFdnFTTWJVcVU5Vm9IVDJUZGNTb2YvbTVsSW0reGRIRzRDdGp3TUQ3?=
 =?utf-8?B?cWRBRERCZzFxQVVNSnBYNEVvTzcxTWxUcllzck43SEx5VytCdTl5anBlcVlX?=
 =?utf-8?B?Mnl2SXpJS1lmQ29sazRTREZyTnh2ak9KazFxajN5T0ZsYkZDQ0VCVk1qNGJR?=
 =?utf-8?B?SWRkQmRKM3RoTThDdWNQSkJGSUhHTDU0RVlDeHhCQk42YmN4N1VvUnJmUHU0?=
 =?utf-8?B?T2c4cit4biszUWYycDRMQ1QzNkdHdkZyZWMxNm1kYnNlL2x1NEFHK2FrcTJG?=
 =?utf-8?B?U05pNTFIa3RFeXpSeVgwQk5xNmtwT3JpaEtFYm45d2Z2UWVPbkU5Y3Zmc1lw?=
 =?utf-8?B?ekdZd0hnT0txdzhTMmxRWGhLaVVsRm1VelBWZUgzcGRhcWxKZW9IL1J6VGNj?=
 =?utf-8?B?Nkc1RzAzQ0hoQ0dRcWNBSEgzRVN3WFNFZFBkT0hjWkkyMHRUazBMN1I4djNP?=
 =?utf-8?B?NWhrK0IyMG5VQUFhSjl6N2V0cmYveTQyb3FCZEhGTVVRaFk4Z3VLVmlYUTg0?=
 =?utf-8?B?SmJNM0ZDc2RtTmtJN2JQN2ZnUmhrMTZYZjRpOUh2ZmlxR1F1NkVwajM3SE1K?=
 =?utf-8?B?VnNVZy92ZGtLa0pubzhLS1lFRjBTT2JuN1NGUTl4ZGZocGdXOG10a2Fpbmla?=
 =?utf-8?B?Q3dFNW1vZVMvc1hoT0tXdVZZQ2Zqd2JubzEwcTVjSytzc2dEcEowOUs1cHV1?=
 =?utf-8?B?Tnp6Smd2dlg5RmJMWXE4QWVuWEpPWTcxdUw2ekRkYkJ5VEh4TnZRdk56M1d4?=
 =?utf-8?B?M2s4d0tDSmxDTGtuaWJocW1lK3VEd1VRUDMvRThBVXZGSGhHdFpjSHNMTDYv?=
 =?utf-8?B?Zm0zazFhK1JnN2FDYjR6TUJuMjRMbXJJQTVMeHpkREVaQm15b2hES1orM3E0?=
 =?utf-8?B?YzZ3dWlaSnBzV29CMzZPNmM5QmFhVStUQnExSTljc2hLaTd3N0ljaVNURjVI?=
 =?utf-8?Q?MeKoWHYyj0kyfNpi7cQFUuZY5iz23PbT7GisSZOBhI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: db2f4473-9bd8-4332-65ad-08d9f1ac0007
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 00:25:29.2257
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H4Z9ilhr8a6Vh2mMifPa810oPljheVedt+PeEyFw25CCZrmz0B+EuhjJOJnkCJUTJbJHjjuXqpZ7sYgvcwBLOrz7oFwSOSxxTeGqe6KgKuk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5313
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dear Maintainers,

On 2/2/2022 11:41 AM, Reinette Chatre wrote:
> The SGX reclaimer code lacks page poison handling in its main
> free path. This can lead to avoidable machine checks if a
> poisoned page is freed and reallocated instead of being
> isolated.
> 
> A troublesome scenario is:
>  1. Machine check (#MC) occurs (asynchronous, !MF_ACTION_REQUIRED)
>  2. arch_memory_failure() is eventually called
>  3. (SGX) page->poison set to 1
>  4. Page is reclaimed
>  5. Page added to normal free lists by sgx_reclaim_pages()
>     ^ This is the bug (poison pages should be isolated on the
>     sgx_poison_page_list instead)
>  6. Page is reallocated by some innocent enclave, a second (synchronous)
>     in-kernel #MC is induced, probably during EADD instruction.
>     ^ This is the fallout from the bug
> 
> (6) is unfortunate and can be avoided by replacing the open coded
> enclave page freeing code in the reclaimer with sgx_free_epc_page()
> to obtain support for poison page handling that includes placing the
> poisoned page on the correct list.
> 
> Fixes: d6d261bded8a ("x86/sgx: Add new sgx_epc_page flag bit to mark free pages")
> Fixes: 992801ae9243 ("x86/sgx: Initial poison handling for dirty and free pages")
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>

Could you please consider this fix for inclusion?

Thank you very much

Reinette