Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <87a6eq49yq.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Richard Fitzgerald <rf@opensource.cirrus.com>
Cc:     <broonie@kernel.org>, <robh+dt@kernel.org>,
        <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: Re: [PATCH 2/2] ASoC: audio_graph_card2: Add support for variable slot widths
In-Reply-To: <20220216171408.265605-3-rf@opensource.cirrus.com>
References: <20220216171408.265605-1-rf@opensource.cirrus.com>
        <20220216171408.265605-3-rf@opensource.cirrus.com>
User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0
Content-Type: text/plain; charset=US-ASCII
Date:   Thu, 17 Feb 2022 00:23:52 +0000
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vTnng4G2z16ekeS99vuF+R+hUptkFKDvFVxLOPKfVIxNbPqfXnxHs9FnzjlV?=
 =?us-ascii?Q?Vy3cLpbFlQfizq+XBwdcGdsoaGQYMQDNdHgt1y2eDUdid+ME1y+/+jJWU3ca?=
 =?us-ascii?Q?Qtqe7MQWd/1vus22kuCzRCfBPpxJb6Om4rQv5/9FZpfQpc8V1eAZ6DroodXb?=
 =?us-ascii?Q?5csYGOt2dZdC78IhUhmaA++oTN/lYKcGV1s6UPOvXTD2kg0DZ5f+r6DNZfGq?=
 =?us-ascii?Q?TVodj3r5pBZ0AH4YmgxT9kdYeNUxa8kkfOBEqIYGTLSPgcFkGR+T9mGxakBq?=
 =?us-ascii?Q?CwPwqzDUcdpjMyZyvZPe7lcCMu8j4FeUeuby0+oPUyb15f6ExEcg2vMIwiv1?=
 =?us-ascii?Q?TyGlsdA5Yn5B3L623G/Sd24gTBOxURZ1Sc0pqbI3NmhAA6hB6av80/pnTbkJ?=
 =?us-ascii?Q?Lt2Q4ehrbMxpd5Ywt9oxeAOveZH6WgALSTlW/omziJs6RoBb6F7WI9W953eP?=
 =?us-ascii?Q?5VMB5OKzC9nuzGaznthc62M5ZpQrclyY3EO8Pe7gxCQ7txZLjj1LafGkxlxs?=
 =?us-ascii?Q?QAz6XpPS2Dyrtraesas2HZcl2yCDWcrF6iWTpptqYbC3Ecw8dfIANqw/TZxD?=
 =?us-ascii?Q?V7+i0QsZ+5szVCy+gp8AZm0wZJ3/JOxbxriQJo7fNTWPwci6rCnqNX+uiFCe?=
 =?us-ascii?Q?g0TX2n7mhqrJ2qGwlQf9+TdFBxWfLzNl25PPH5qC4sNFEfjYAH28gC2B0qjk?=
 =?us-ascii?Q?Q8af5/hJpxtDOrLWRMCbmi6l2GqiIeO58iiDZa8uzUm0p7jlUJWEwYFSaEQ4?=
 =?us-ascii?Q?FSz5sRxRZoikbul6jdBxeVrrsgGxFivAwMFyr8MLtiTiO6Ok6q2cJhvDxGK6?=
 =?us-ascii?Q?SNl9NvBUhPiVhUjlUn3A3/nSQ/Mjc4JoQSG7+5jAc7L4G+4yg9GinQOxd21O?=
 =?us-ascii?Q?PPQ/lZVENVNRpwDYjNYLWdjs/rDbUw8hMh1iPdFnkOfvu5nfrbEBVPgUNNUb?=
 =?us-ascii?Q?c/ClWb+1dZS8EXqLFmkE1ADbCtDmkv2yXzBUA+5/tb2tiz9H33glpls1IkNK?=
 =?us-ascii?Q?yFZOFNZLGr+oD4qgPzaClr7w4+1dVO1rTclFVKCMxcpeAJQmTJydfCB0FJ8q?=
 =?us-ascii?Q?gQ6LiEQKwGpLPAvbJOp4fBeENjTRmGB+KlXzOvUOM4WNpJZE5fkCF45rJPu8?=
 =?us-ascii?Q?UunjmdL2tfEjFdzuVHs8Ctc8iL5ud5wol5vbYV868sxDBl587caF+QyQRomm?=
 =?us-ascii?Q?k17Wztvr7G0RLlSeacJd0oYTFuTBB/UlLn5uY0qfOmxuAcUQOTpyjpqmBH0c?=
 =?us-ascii?Q?dqOZTd+n/405WlYJ/Yf1VrDi8jXHfAdcgIGN+5iKIWr/UghwxeJlFmShONaM?=
 =?us-ascii?Q?WALqj6dsQhWSDTNpYL8u47SEPjOs+XCn2i5LsOThPnrMbPfwsIeO2IgJqHXs?=
 =?us-ascii?Q?Ofk45z29EhV4thuwjzi2rlq+lfnB1ixyKQZcXRzCN4XIJIBUEomxCLIBQjEK?=
 =?us-ascii?Q?30ZgqYF6FpCV0mcqmGbeUmFgsgXIY9a5kP63qo/9fowHfA5Za2qKUdGG3NR2?=
 =?us-ascii?Q?07ku8y53IQ7S0t4j7X9T22OYhiVTwprvPf2ahhLTy5Tq7oEf6ZMpE4KoaLHV?=
 =?us-ascii?Q?x4EPchz4+gD+UIzbA9OlZvHOlZSvZYlmaoIGLDv2M8IbIhSl+oc3PorfCezO?=
 =?us-ascii?Q?UWbWInCZ0G+fWeP0E+GX3g+Djl8O2JlD+q8WSg2c1jhMqMlGtA9C95k0yFHh?=
 =?us-ascii?Q?6+CjDyqiAWvYX10NM9mGHZnk3Lj2wU/eFsT5JFzTqdDZOY7t/xFL+EnKhVud?=
 =?us-ascii?Q?AvHTefssyw=3D=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a6107b29-9500-477f-2d15-08d9f1abc6ac
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 00:23:52.7478
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2MKp638n7K9exJ1Hgo4FJYDJr4WYiRkNCslYHhLt2fjfVjsxy0Wyrw+Br6dCXu0I4S8EkC7JxoaZ+dQT7eM6WWkHMaAZDKY40owLt4ZWltSKyDVj2lo/Lsj97eEuHhIB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB9813
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Richard

Thank you for your patch.
One comment from me.

>  struct asoc_simple_dai {
>  	const char *name;
>  	unsigned int sysclk;
> @@ -26,6 +31,9 @@ struct asoc_simple_dai {
>  	unsigned int rx_slot_mask;
>  	struct clk *clk;
>  	bool clk_fixed;
> +	struct asoc_simple_tdm_width_map *tdm_width_map;
> +	int n_tdm_widths;
> +	struct snd_soc_dai *dai;
>  };
(snip)
> +	ret = snd_soc_dai_set_tdm_slot(simple_dai->dai,
> +				       simple_dai->tx_slot_mask,
> +				       simple_dai->rx_slot_mask,
> +				       simple_dai->slots,
> +				       slot_width);
(snip)
> +	for_each_prop_dai_codec(props, i, pdai) {
> +		ret = asoc_simple_set_tdm(pdai, params);
> +		if (ret < 0)
> +			return ret;
> +	}
> +
> +	for_each_prop_dai_cpu(props, i, pdai) {
> +		ret = asoc_simple_set_tdm(pdai, params);
> +		if (ret < 0)
> +			return ret;
> +	}
(snip)
> @@ -386,6 +479,8 @@ static int asoc_simple_init_dai(struct snd_soc_dai *dai,
>  	if (!simple_dai)
>  		return 0;
>  
> +	simple_dai->dai = dai;

Indeed the relationship between asoc_simple_dai and snd_soc_dai are
very mystery, and current utils is using confusable naming.
We want to have some better solution about there.

Having snd_soc_dai pointer inside asoc_simple_dai itself is not bad idea.
But we can get snd_soc_dai pointer without it.

Please check asoc_simple_dai_init().
Not tested, but we can replace the code like this ?

=>	struct snd_soc_dai *dai;

	for_each_prop_dai_codec(props, i, pdai) {
=>		dai = asoc_rtd_to_codec(rtd, i);
		ret = asoc_simple_set_tdm(dai, pdai, params);
		if (ret < 0)
			return ret;
	}


Thank you for your help !!

Best regards
---
Kuninori Morimoto