Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vishnu Dasa <vdasa@vmware.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
CC:     Jorgen Hansen <jhansen@vmware.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "acking@vmware.com" <acking@vmware.com>,
        "dtor@vmware.com" <dtor@vmware.com>,
        Pv-drivers <Pv-drivers@vmware.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 1/3] VMCI: Fix the description of vmci_check_host_caps()
Thread-Topic: [PATCH 1/3] VMCI: Fix the description of vmci_check_host_caps()
Thread-Index: AQHYHs1e9+zpOx9Ht0ud6aMZ3l07FqyXXNqA
Date:   Thu, 17 Feb 2022 07:08:57 +0000
Message-ID: <7844DB64-F8A6-49C2-A0A7-0A9AA634BFDA@vmware.com>
References: <cover.1644531317.git.christophe.jaillet@wanadoo.fr>
 <7f7ad8c171566f6f8716c3451b9ddc2e83fe003f.1644531317.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <7f7ad8c171566f6f8716c3451b9ddc2e83fe003f.1644531317.git.christophe.jaillet@wanadoo.fr>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?73d1x2/hsdpmSGwtxF7SLm0q31bWBQ5+YSX6zs10b87Id0/s7NxutalQ0lE4?=
 =?us-ascii?Q?zyrDYl9f1kNyAw2gWP2IzY/07T6YwUSBh3X3WTF6vYNYHtOZ2+YcNO9LgRG3?=
 =?us-ascii?Q?S+fG9I4HnQeCCAfAYq9CGXJ6nAdArgxL5LcgXBoIIrW5XDFfEf9lCxhMLSh7?=
 =?us-ascii?Q?3H3EIHBtASRBlrUK3tUWO8MEWKepTHAjOUFWbI10fs1Cj1PNaElaXeJumKMD?=
 =?us-ascii?Q?ySvY6tQT3iyzxeJMTmyJpeWaSComk0WEYEVEtT2qeU9ozYmD7iGARGoCLMTw?=
 =?us-ascii?Q?vulgPxfGtjsoqlEYCDy3bEFbsiEaba0dYp8UU+W3NVwwHGljsbNrmIYKKS79?=
 =?us-ascii?Q?XoQH/ShPWHugV239pgoMb7RupMNQuSbQY8W8n2weV4j+HEGQpXNFC1RFLA+C?=
 =?us-ascii?Q?/ZHAVtaiZpl9+20ijAF5Ku1rsoAfav5F2Cu3qtwIad3gx1fKMotgM1IqY1m2?=
 =?us-ascii?Q?8zcD4TG6XUyPtwDGAGZWdbjA7irSwL/2gyy4Du4m/ssJ3jbAGDNow3wjPI9u?=
 =?us-ascii?Q?fnYiTtgSjC9ewUVjG8YI2aRhsiiVdGmQNJOT+Ro/B+rNzNOiv9A55PWJ0R6E?=
 =?us-ascii?Q?EDbAsXy+k9AznEjIp6lLp5floxRq0TfKeae9dhCCGQLwNH1g/GkTMdOQqe2d?=
 =?us-ascii?Q?YqB4HGCER9CuNtt+PrbOOCaQ5rWwZa7OaNl5+djLmfpllbf65GcazzYCT8Z8?=
 =?us-ascii?Q?jOLHHUEo0oQui4R/25VAY17QUTafeEZXimCZ1A9xK/+RUAcS17rv3X+Za3Ye?=
 =?us-ascii?Q?wLJxpR579DuYfLuTFzr/y9E8UIPzMzJuN+TDkvv/FiK2aOaYgyQbxuX3W1xu?=
 =?us-ascii?Q?5LfKkylMiHqXYqdIjT5dDMVH0qIimoWjRDuVZ9G3X51/0OVzGgTww6u9VJur?=
 =?us-ascii?Q?SJ0bHsafQJ6lgcjSvqtZA3eVDgTetUsRCDbqinjdIm5nOGEIq2zz19weCq3T?=
 =?us-ascii?Q?zXqxK4Qx1UH20exLOF/vl/ZwRKsOQLsF6js3kZW6TVV2hoK+YcyAgKi7YrQ9?=
 =?us-ascii?Q?lwUfOI2ya4x4K3+TNRTkDEQEC1zj7PseJKbZprSKcsTHGhe2uXoA0Ner77WE?=
 =?us-ascii?Q?2N2lQJAf5jSoTaFeMyTnAPWy4Sr94Lo1puCSo0gvwBXozLNGggt8LcDAEhOB?=
 =?us-ascii?Q?4bB2cPQ4FEwKZCZSAVbmgHeJMH3XODu3LDOGIJmmskTHiuOz7SHpunzw8qM/?=
 =?us-ascii?Q?rbhX0hUZcOQsCwDZLc7ux/J9BdyOGX2HFhtQWUVHEx57kBBkLaqhicFq32I7?=
 =?us-ascii?Q?ZL/UPcBoqoWzSFmT6v83nzZ7hFqjFujKbLUuip94LX3p1qYJf4FrYwKDeJPS?=
 =?us-ascii?Q?oCSQfW3Cllri8DcSSL9ANrV9enJa2Xkc14wb61OARoM/eX4z+bL5JLtcNhbu?=
 =?us-ascii?Q?0VeqUyNykCdEAw4gLdw6MmthqE0QlV6KWgdiET8rKGjqvB4hCqFyVPZwcMzk?=
 =?us-ascii?Q?gbOjEpmtH9bxfY26fCzNlDGXT4tZKPsoSrA4q63JCeeWcYP+sPCO+dD0uAUU?=
 =?us-ascii?Q?+I/PCY+pVhaBysBsJM/13iWbg8qj7auAKmi0lQNo33SWVsR3b9R7qQ8jZotj?=
 =?us-ascii?Q?mYPWGxFgRWsV+ORLyqf3tUo6+fPHjlq7+72tOks/uO9zrV5cAahYey5Z+VY6?=
 =?us-ascii?Q?U5o8BQH+a+xllaoxLaI4aWw5AlR5e7Fu+hyzaH6QGq7SlMy0iwGwRD2Xv/fp?=
 =?us-ascii?Q?v30MF0z+kfAy/B889BN6uvoNjcA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <018A86F78669CA48BA7D0168EFFD25EE@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR05MB3962.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e271f559-81ea-4038-dcd2-08d9f1e45dec
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2022 07:08:57.9027
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: I1SiB3iCflS2JmBgzknMu+kR6fRZqwPyQa6EHB/A3WxskJmnNTesrM+MNjjol5A2zYO0fUKuH9k7bVxt3zTBYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR05MB8068
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Feb 10, 2022, at 2:27 PM, Christophe JAILLET <christophe.jaillet@wanad=
oo.fr> wrote:
>=20
> vmci_check_host_caps() doesn't return a bool but an int.
> Fix the description accordingly.
>=20
> Fixes: 	782f24453536 ("VMCI: fix error handling path when registering gue=
st driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/misc/vmw_vmci/vmci_guest.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc/vmw_vmci/v=
mci_guest.c
> index aa61a687b3e2..1a1858742f75 100644
> --- a/drivers/misc/vmw_vmci/vmci_guest.c
> +++ b/drivers/misc/vmw_vmci/vmci_guest.c
> @@ -253,9 +253,9 @@ static void vmci_guest_cid_update(u32 sub_id,
>=20
> /*
>  * Verify that the host supports the hypercalls we need. If it does not,
> - * try to find fallback hypercalls and use those instead.  Returns
> - * true if required hypercalls (or fallback hypercalls) are
> - * supported by the host, false otherwise.
> + * try to find fallback hypercalls and use those instead.  Returns 0 if
> + * required hypercalls (or fallback hypercalls) are supported by the hos=
t,
> + * an error code otherwise.
>  */
> static int vmci_check_host_caps(struct pci_dev *pdev)
> {
> --=20
> 2.32.0
>=20

Thanks!

Acked-by: Vishnu Dasa <vdasa@vmware.com>=