Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp176177pxb; Thu, 17 Feb 2022 01:15:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJywtbl20ARlBfNIGQssZzf7qE6jQ26cXUq7UqA5ZVKwH6gd1I/ehVOXzo1J6S9my6T7BZNX X-Received: by 2002:a17:902:e80c:b0:14d:7fdb:fcc3 with SMTP id u12-20020a170902e80c00b0014d7fdbfcc3mr1997218plg.159.1645089357223; Thu, 17 Feb 2022 01:15:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645089357; cv=none; d=google.com; s=arc-20160816; b=GAmEwmPI3bVcoI7L+jVdW26dYuOTTUHNJDZFy2H4pE0m8ZylZb11kRl71ExTEYZUuV nw0kPwWlzg1FQp6+eY1dvgdBocOT9QS0/4Ly6LhKAtP2RBdT8TyOIbRK4ofec5xlmw3+ k2vMr33L7pbJXFxtE2IckE+CzPpR+x/MTFJbSacpJlRnCKBrVxOj5SQWid7ueCZq4NWz 1Ta84tfoJV7RKuzio4tP4j49cfFy9VKqg9iq0TpQj5LmxZ3hRbbXyo93sTmVj0YTjllA jnLnije2veTu2J8t9zR2hryT9O23Qy+UxAKJUuIsVr1wNw0iRaTtoacQpPQUujJ2nJcw 1pYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=fbkjSAH5zzjT9bdkUEcfX+58XyqQCYr3PakKI23mckw=; b=ILgF54/Su5K3hQSzXiXMvulDi+xxGcYHLYX8BXHN42JPzzm5cfNJVfCTy/JjRD9RpW fBXuEaM3F/nLiq24+xTnf0F95Q1xVcHq905J/vk9QFfCvPHJQPOjdUF+1zZ8Q6JakMLQ 4YU+IfRJWDzLbeXxCrbVeCn/DbsX5QH7Ln223xpB83AewyuWFpn+OaIHz3efQiFMbWW8 DCf9SlyczSZUf2LqFRILMLtx6INgdNtTcZ1BJ9Dr+eNYBwxAINWf9hqRfdVhun9FF2R9 tlr4koLIIgdupd/cCkAZly0AXcAh1DtY2DEL03FD6DtAovyWEMZiNkL8uy9AoPY/v7o3 lB9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jCBnYGr0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c15si22312432plg.506.2022.02.17.01.15.37; Thu, 17 Feb 2022 01:15:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jCBnYGr0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235922AbiBQGzW (ORCPT + 99 others); Thu, 17 Feb 2022 01:55:22 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235843AbiBQGzN (ORCPT ); Thu, 17 Feb 2022 01:55:13 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD99727F296 for ; Wed, 16 Feb 2022 22:54:59 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id m7so4754912pjk.0 for ; Wed, 16 Feb 2022 22:54:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fbkjSAH5zzjT9bdkUEcfX+58XyqQCYr3PakKI23mckw=; b=jCBnYGr0FwYAETE7VlgSz7COIhTuOqqXUvkcjf30rbfBPxuuk08YKvaOQPVYt4UgHb FfNHWqxTe9rEjj3Qzmo5dVaJ9VS0shIflUfCiEbFtokKMjLM6qxMrkNcnR7AU50HiHxx GP5KznxEUasfAj7zlqi0aMCfJ8H9WPHdB4/HalHPmbR0v4Ywo07XT2+LHLYOk3OotlmA rZ+5JVE9CC4QqauK7OrfjE4N6aGvdyORyjg1WMtXhfMcIJeIElpgSoFGC5GR7ae4nlRr eMizuvpnlNy1C8kSJaGVN1jJtgPa5P+RFPeYgpvdXqPLWJWVwdX/kadRBxOsAMOookYq 0aqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fbkjSAH5zzjT9bdkUEcfX+58XyqQCYr3PakKI23mckw=; b=iakQWAMnzcKk/GEGxz926HV6tbPw92rKGpoVEDUReXFTo/5rENZSkCp/moNpWVdZF5 zOMucJ1JlVPoTeT6FNKsP7HLNBVtcMYRKBvwTJlE2l1g5Y7naOkvfR3RuEGD6+mY698a 69zk55gSpQRorHxdSCsR053WG2xpVN/tu+7N6RT6HySkakdIsMS8LosXtaYhCbLbCm4k Gadpv+CRmfiNlz6kf9b0jzPZ0RKyNGlVckkzSCesQfjrROuoAV5ONjAT3f8ikrJnQVVr umAzXEfaG6S2pAOvDPXm1Rjtu0C12t9OLQPImGlVaJnAaZVHjqVgpDe4Vqe9Hjo46eKv G/qQ== X-Gm-Message-State: AOAM530FtAM6H7RAKz2Gqep7itQebioYrl0zdkDS08zOvXY0TyJ7RMI3 bmqccdr9xOc2kidqO9WnPQh5cQ== X-Received: by 2002:a17:90b:360e:b0:1b9:d9f0:b37 with SMTP id ml14-20020a17090b360e00b001b9d9f00b37mr1634420pjb.111.1645080899225; Wed, 16 Feb 2022 22:54:59 -0800 (PST) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id 8sm10115763pfl.164.2022.02.16.22.54.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Feb 2022 22:54:58 -0800 (PST) Date: Thu, 17 Feb 2022 14:54:51 +0800 From: Shawn Guo To: Rob Herring Cc: Thomas Gleixner , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Sudeep Holla , Rob Herring , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Daniel Lezcano , Maulik Shah , "Rafael J . Wysocki" , Marc Zyngier , Lorenzo Pieralisi Subject: Re: [PATCH v5 2/3] dt-bindings: interrupt-controller: Add Qualcomm MPM support Message-ID: <20220217065447.GC31965@dragon> References: <20220216132830.32490-1-shawn.guo@linaro.org> <20220216132830.32490-3-shawn.guo@linaro.org> <1645070363.942246.2266021.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1645070363.942246.2266021.nullmailer@robh.at.kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 16, 2022 at 09:59:23PM -0600, Rob Herring wrote: > On Wed, 16 Feb 2022 21:28:29 +0800, Shawn Guo wrote: > > It adds DT binding support for Qualcomm MPM interrupt controller. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Shawn Guo > > --- > > .../interrupt-controller/qcom,mpm.yaml | 94 +++++++++++++++++++ > > 1 file changed, 94 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): I ran dt_binding_check without DT_CHECKER_FLAGS=-m. Will re-test and fix. Shawn > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml: properties:qcom,mpm-pin-count: 'oneOf' conditional failed, one must be fixed: > 'type' is a required property > hint: A vendor boolean property can use "type: boolean" > Additional properties are not allowed ('maxItems' was unexpected) > hint: A vendor boolean property can use "type: boolean" > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml: properties:qcom,mpm-pin-count: 'oneOf' conditional failed, one must be fixed: > 'enum' is a required property > 'const' is a required property > hint: A vendor string property with exact values has an implicit type > from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml: properties:qcom,mpm-pin-count: 'oneOf' conditional failed, one must be fixed: > '$ref' is a required property > 'allOf' is a required property > hint: A vendor property needs a $ref to types.yaml > from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# > hint: Vendor specific properties must have a type and description unless they have a defined, common suffix. > from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml: properties:qcom,mpm-pin-map: 'oneOf' conditional failed, one must be fixed: > 'type' is a required property > hint: A vendor boolean property can use "type: boolean" > 'description' is a required property > hint: A vendor boolean property can use "type: boolean" > Additional properties are not allowed ('$ref', 'items' were unexpected) > hint: A vendor boolean property can use "type: boolean" > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml: properties:qcom,mpm-pin-map: 'oneOf' conditional failed, one must be fixed: > 'enum' is a required property > 'const' is a required property > hint: A vendor string property with exact values has an implicit type > from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# > '/schemas/types.yaml#/definitions/uint32-matrix' does not match '^#/(definitions|$defs)/' > hint: A vendor property can have a $ref to a a $defs schema > hint: Vendor specific properties must have a type and description unless they have a defined, common suffix. > from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml: ignoring, error in schema: properties: qcom,mpm-pin-count > Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.example.dt.yaml:0:0: /example-0/interrupt-controller@45f01b8: failed to match any schema with compatible: ['qcom,qcm2290-mpm'] > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1593741 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. >