Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0c71b2e6-894d-8a36-533c-f5ff8b5e2683@nvidia.com>
Date:   Wed, 16 Feb 2022 21:45:13 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v4 1/4] mm: Don't skip swap entry even if zap_details
 specified
Content-Language: en-US
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Andrew Morton <akpm@linux-foundation.org>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Matthew Wilcox <willy@infradead.org>,
        Yang Shi <shy828301@gmail.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Alistair Popple <apopple@nvidia.com>,
        David Hildenbrand <david@redhat.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Hugh Dickins <hughd@google.com>
References: <20220216094810.60572-1-peterx@redhat.com>
 <20220216094810.60572-2-peterx@redhat.com>
 <da98141f-c8d8-f796-d8ec-352d9b2abd6a@nvidia.com>
 <Yg3TKD6i9JjoRe80@xz-m1.local>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <Yg3TKD6i9JjoRe80@xz-m1.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnN3czQ2T0xHbEx3VUlkSlF1WXo2RDQxY1NvbTFKUkxZMlRNZnZ6dTQyNzNm?=
 =?utf-8?B?TDFXQmVRUjdRcEg0RlJuYXdRbXhGZFNwR3dBemFvMEJiUzkrRE0xTjNsRXZE?=
 =?utf-8?B?YlVFR3dGYmMrbWM5S1J2MTdVNnRvdW8xaGo3NTB4QlBtbHhDbjVJWVRyRzhZ?=
 =?utf-8?B?ZWFEaVowczJuL1pXZ1pDdzdVcnhOZHhjQmZucG9wcjdDaWUzaGJuNnpKSjNn?=
 =?utf-8?B?Tnc5TUZnWU03S3ZSQlUxVjNLRHRQU0NYTG9ZSytqai9WbXpuZXVnMUpocStr?=
 =?utf-8?B?N2tRcytSYXlQREN1dDZlVnllOG5MQVdkSGdXVW5TMjU2K0o5bHVrTjNOS2Zh?=
 =?utf-8?B?QUZyWGhFSzJRZXhacmpHaFRGV2N0aUFpb3BualBrcGh1WjJvK0U1Vnh3OXlI?=
 =?utf-8?B?czhoUlBmMUJkQWIrRXdUZzQvc05UaENBTmZkL1ByR2ZVQUJSTEovaTJhTzdv?=
 =?utf-8?B?aTY5bDJrWXdhcEV5cmlmRndvSnlCRU03dU1jRjU0NkFzOTZ5MStrZnFzZnU4?=
 =?utf-8?B?VVJld3dYbHJJOU9OZ0lYRTVYT0pWclFJOVFIRXVNcEljYk1BL1kwaXB5RjZ1?=
 =?utf-8?B?TFlBRk5EMkZkd2h6S3FiRy9abE00Z1g4TE05bFp0eFE1R1EyaTJWZ2pmQWpl?=
 =?utf-8?B?L2lXZkFwNEJqQ2c5UzF1eE5zZC9VK2ZLcDRJSUx1R2F4ejlhZXJ6RENaTU55?=
 =?utf-8?B?ak9nT2JDZHZLdXc2a2sxOXdVTVN6aFJ5U2lpSVNpd1FDMVRTT3NvQ25CdnBW?=
 =?utf-8?B?TkdsNytpL2dWYy9BRlZqSm1MTE9pQjFNSVVIK3IyZnIxOVdaV1VxRXhJYlQz?=
 =?utf-8?B?WHExTFVtbUl1ZkEwS1ZMcCt6MUhKYmxKTEhIL3VML1FGVEZ3VS9oVTJONFBE?=
 =?utf-8?B?VHpPYW0yR2V2MjlnMjFRaXp4VndqSVNCZ2tqUzJqSTI2djZ6dWlvNXMvSndx?=
 =?utf-8?B?b042dUtUdy9yRXdtYjI0ZU1nNXEyeHZyWFI1aXlYcFNBT1FIanJvbW43VHVp?=
 =?utf-8?B?ZFQyYjRVcGQxQlMzM3JSZW1QVzJwOE9jVG9WYzA4UWQ3a0hOL04zRlkrUGFl?=
 =?utf-8?B?TjI5cnpQbG96czBtTkdNdXFKcWhxRmpRUUVmaXE5VEVzNk1HSllRYkplVjYx?=
 =?utf-8?B?TW83Yk1vOTBCVEU0SVFIc2VwT0xCb25UVGZZYTY4VGtScFEzWGRqN3grQWRo?=
 =?utf-8?B?bTRXMmk2a1JHekEvNFh3OVVoNklBZWxwcTF6QTg0Z21JKzNvaXMyOEJiM3By?=
 =?utf-8?B?MFRnZ201ODVqa05Veko4ejlaeTFieXhmeEJ5SkVBVm5uUHJxdDYxSjEveEFa?=
 =?utf-8?B?S1J0TlpkdkRaQ0Q1RkszK0FkQUJXWmhLcUs3Ukp3aVB4SmVqYjMxUk5VTXJs?=
 =?utf-8?B?NjZXRmdFRFllTTlaTERWb3pGaVVHY255NXpuME5YRDZJUzVnQTErSUhaL2o4?=
 =?utf-8?B?c1NLOVhBZjVwMXJkakMzRWVzQU1sZjQ2WTd4R0EvMlBBbHhTcVBwSU96ZGlr?=
 =?utf-8?B?QW1vWVFQU0FZT1pGaFhGenIxdjhTbjJSYVMyTE1tY01DUzRMTVR3UWEwN041?=
 =?utf-8?B?MlZ6RWE4aUU1MG5wT3VCNndQeWJTaDlBMzNLWkN2cS9Jd3V2ejhGWTRwZlN2?=
 =?utf-8?B?WDNkc1U0cXBMWVJsWEMvNDBndUU0cFpNVHp1SVl3OFJXN0x0VmdEQ1lVU2lS?=
 =?utf-8?B?bWFnTDQrb21OOVBUZlpvOVVsbDQ4dVd0V2Fsd1lCeFVqcjVLMHNXRkI4MTd2?=
 =?utf-8?B?d0ZQTHREdFR5a3p1ZUw4YVJxVkFBWWZ3ZmE2M3ZvbkhUc0g3SmNXR1NwaWFu?=
 =?utf-8?B?NnVLcHI0QVplVEZFaHZxZlhmUFNWeEM4YmNsSXZuT0FRcnY4NTliQ3Jlc0FI?=
 =?utf-8?B?MGpsWVRwQ2kreDhQM2RrSlJ6YUNMYm5XdHlNNlkwL1NtK2p6eGtlQzNvM2o3?=
 =?utf-8?B?VnAyMm1PVGVVUVVvbWxVRWhZemRzT21sSUlaUGZoaXhNQ3RSNWhiSy8zb1Fl?=
 =?utf-8?B?VThjQU1id3JwK3orSDFnWHBoZ0IvczJFeEFIbE9uNmpNa1pXb204MlN3TmIv?=
 =?utf-8?B?YXN2Y3kyYjU1dVo5L1pwSkM1SnVDUzNScEkvcVlvL2tITCtEZWNBMlV0bFVk?=
 =?utf-8?B?eGJTemNyYmdwVHNRT3Z2cTZ4dFgwMFZ2b2RJTkNPemd0aTQ4SkZnM3N2SnpY?=
 =?utf-8?Q?njOfJ95KPK0BU0T8Yszv6Hc=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e324c137-2d3b-4d2f-3666-08d9f1d8ac13
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 05:45:15.3524
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eLFb/o/5uBZM9AfwmQeKXTuVtljQEIJHp3ufSImpq0vtCrvE9P9MHN+GstX2pvJxtYVw/bUiMAEf13oYT4m8Vg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2348
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/16/22 20:46, Peter Xu wrote:
...
> I personally used 78/79 col width for a long time for different projects, but
> sure I can adjust my config.  I found that the "official guide" points us to
> 75 instead:
> 
> https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
> 
>    The body of the explanation, line wrapped at 75 columns, which will be copied
>    to the permanent changelog to describe this patch.
> 
> I'll follow that.
> 

Oh, I'll change to that too, then. Thanks for spotting that.

> [...]
>>> +			if (!should_zap_cows(details))
>>> +				continue;
>>>   			rss[MM_SWAPENTS]--;
>>> -		else if (is_migration_entry(entry)) {
>>
>> Can we put a newline here, and before each "else" block? Because now it
>> is getting very dense, and the visual separation really helps.
> 
> The thing is we don't have a rule to add empty lines here, or do we?  Changing
> it could make it less like what we have had.
> 

I'm not claiming rules or standards, this is just a special case of trying
to make it a little nicer. No big deal either way, of course.


thanks,
-- 
John Hubbard
NVIDIA