Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b3284840-0f2a-89ff-8525-6a77f6ff7063@canonical.com>
Date:   Thu, 17 Feb 2022 10:38:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] dt-bindings: soc: Add HPE GXP SOC binding
Content-Language: en-US
To:     nick.hawkins@hpe.com, verdun@hpe.com
Cc:     Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <nick.hawkins@hpe.com>
 <20220216181434.41682-1-nick.hawkins@hpe.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
In-Reply-To: <20220216181434.41682-1-nick.hawkins@hpe.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 16/02/2022 19:14, nick.hawkins@hpe.com wrote:
> From: Nick Hawkins <nick.hawkins@hpe.com>
> 
> Description: This binding will be used in creating the HPE GXP
>  architecture. GXP is the name of the HPE SoC.
> This SoC is used to implement BMC features of HPE servers
> (all ProLiant, Synergy, and many Apollo, and Superdome machines)
> It does support many features including:
>         ARMv7 architecture, and it is based on a Cortex A9 core
>         Use an AXI bus to which
>                 a memory controller is attached, as well as
>                  multiple SPI interfaces to connect boot flash,
>                  and ROM flash, a 10/100/1000 Mac engine which
>                  supports SGMII (2 ports) and RMII
>                 Multiple I2C engines to drive connectivity with a
> 				 host infrastructure
>                 A video engine which support VGA and DP, as well as
>                  an hardware video encoder
>                 Multiple PCIe ports
>                 A PECI interface, and LPC eSPI
>                 Multiple UART for debug purpose, and Virtual UART for
>                  host connectivity
>                 A GPIO engine.

You need to do something with this indentation. It's unreadable. Please
look at git history to see how other people are writing longer commit
messages. Some examples of lists:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=1deab8c8abe3a167142ddc080995d36a321ace60
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=0a9f6487f96e746f129f15216eb8cba2bbd7c36a
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=6b17743d934ecb5c7b3429c601a04f8fd254013f

> 
> Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
> ---
>  .../devicetree/bindings/soc/hpe/gxp.yaml      | 35 +++++++++++++++++++
>  MAINTAINERS                                   |  6 ++++
>  2 files changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/hpe/gxp.yaml
> 
> diff --git a/Documentation/devicetree/bindings/soc/hpe/gxp.yaml b/Documentation/devicetree/bindings/soc/hpe/gxp.yaml
> new file mode 100644
> index 000000000000..8690c1e28ed2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/hpe/gxp.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/hpe/gxp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HPE bmc GXP SoC driver
> +
> +maintainers:
> +  - Nick Hawkins <nick.hawkins@hpe.com>
> +  - Jean-Marie Verdun <verdun@hpe.com>
> +
> +properties:
> +  compatible:
> +    const: hpe,gxp

I have no clue what this is... It is called a "SoC driver", but uses a
SoC compatible. It's not possible to understand the big picture, based
on this one patch (and it is not part of series...).

Please go through the comments you received... I provided you some time
with an example how the submission should look like:

https://lore.kernel.org/linux-samsung-soc/31da451b-a36c-74fb-5667-d4193284c6cd@canonical.com/T/#mf98d2ac27a8481dc69dd110f9861c8318cade252
1. Cover letter with changelog
2. Patches split and organized:
a. dt-bindings,
b. driver changes,
c. DTS.

Thinks could be separated, e.g. driver changes with corresponding DTS
updates, but you cannot send a bindings as separate email and DTS in
entirely different email to different people. We need to see all of them.

For example the Tesla FSD above split SPI changes into completely
separate series. That's ok. Still The series above bring everything
needed to judge/review that part.

> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> +

Best regards,
Krzysztof