Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp209800pxb; Thu, 17 Feb 2022 02:14:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJwRUN3zCJgKG+w2u1KrhNlCSik75+Q6LCuAtE85+AK7nIb7AHOHvc0GGtItJQTOrx91JBdE X-Received: by 2002:a50:f689:0:b0:410:a334:2b9f with SMTP id d9-20020a50f689000000b00410a3342b9fmr1741614edn.251.1645092867214; Thu, 17 Feb 2022 02:14:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645092867; cv=none; d=google.com; s=arc-20160816; b=iKrJDislZdvNeCTuPBZQCap4YucYaaMfmJgqYIRVIUcmnWCvmqY4bJBUW+NbRZvmt2 sqtYJizN7MGNjBnqHG7h5tB6/bhvALl92G+e5+XtYgi5dwh2wVG484/DGUvjOPBycYKc X5sP+b4oqor8H4EkYBuJAu1Wc0Z7NPB8YZXzhMCz4/qN3ngvojiXydlhg4zR8daURGEv vT3eM8Z0LYNgLN/jOPpXCO6JgrFhV83fUaKyxpT/WOVC+zAk4Eg+5b4j8BxErTmbr7Jr 7ERxKHc22oLXVRWds2t95su+AMofTplflHmRFPXUEqSDX2gXeG7xhgyPwvkY7y+CgTAd 2OLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=DrgN1eWHHUcF9iGgbWHsxYrZrQB0AYARGjvjz3Po6Ko=; b=ojnq93ks4KlqLH0vB8ANLUMlerkwuFAZFZLX+7MKgblj/vnJlKCCTt3FBmzxtumxki E+wMN8Zk/METQFzSOhh1lTzsAI+Oy9nQPgncJmPfVxyrh7wqWua38K6V+OxPagz5pFQA JWLJUXccNq5S47UE3ceeXIBP8th0X+peTGpOzolHwaCqkxajX9zvRWerhDqGa55WgedW IOQL0634wUw+NZkFPamMxC8sW/o6kfKBlvj9zm0Lf6Etd1qY65CVjKiIaXcpsjPvoKrd q45ob1j8wxqsmK393n+hSvnEAEcpvvza6GzcNabpbpajM+IxyXK/T+puhPANs2Uerw11 QRWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fnr5DTR1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s1si1953317ejn.486.2022.02.17.02.14.03; Thu, 17 Feb 2022 02:14:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fnr5DTR1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233504AbiBQEoa (ORCPT + 99 others); Wed, 16 Feb 2022 23:44:30 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbiBQEo1 (ORCPT ); Wed, 16 Feb 2022 23:44:27 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CDCB18E13E; Wed, 16 Feb 2022 20:44:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 019B661D5A; Thu, 17 Feb 2022 04:44:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11A95C340E9; Thu, 17 Feb 2022 04:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645073051; bh=BGju6hGLRyEf2m6nqCHDCLlyVhV4bPLTg/Mt5EZCJk0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fnr5DTR1stC0tveq/1mbFOkNj5sGzaRnrjkYH/pbWahB2ee6xp4BUQOs7YH8Tli9/ n9A/ttfmc08ZuY7onnlVC440omb/w0TOlwvR71v2f8uAHMuEwxBgXwY2vGVnvZDNH5 3/Wb1txHpwytTtU+JnYa0lpGOGRjfN3DR4LwFKmhfL6VBs76ABJufWvQGuEwDUt67q qskYMzy9I3aXTmcyIK+Zvuh13H4n1aLe9e4pXrCiKQ6+4ul+jnzdNnw5bQQjoA+RSz 1cTGG92nMhPQHt6PYjL9jTh9YFOEZFunmrOfA6DQQu4OBmHUpoBnz1VC5G2dSwEAYD Pn+G4yWt69P1w== Date: Wed, 16 Feb 2022 20:44:09 -0800 From: Jakub Kicinski To: Jeffrey Ji Cc: Eric Dumazet , "David S . Miller" , Brian Vazquez , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Mahesh Bandewar , jeffreyji Subject: Re: [PATCH v1 net-next] teaming: deliver link-local packets with the link they arrive on Message-ID: <20220216204409.1d2928b1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20220215220517.2498751-1-jeffreyji@google.com> References: <20220215220517.2498751-1-jeffreyji@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Feb 2022 22:05:17 +0000 Jeffrey Ji wrote: > From: jeffreyji > > skb is ignored if team port is disabled. We want the skb to be delivered > if it's an LLDP packet. > > Issue is already fixed for bonding in commit > b89f04c61efe3b7756434d693b9203cc0cce002e This is not the correct way to quote a commit. It should be commit <12+ chars of sha1> ("title line"). > Signed-off-by: jeffreyji You must CC maintainers. scripts/get_maintainer.pl is your friend. You don't have to CC linux-kernel, tho, nobody reads that. Please resend. > diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c > index 8b2adc56b92a..24d66dfbb2e1 100644 > --- a/drivers/net/team/team.c > +++ b/drivers/net/team/team.c > @@ -734,6 +734,12 @@ static rx_handler_result_t team_handle_frame(struct sk_buff **pskb) > port = team_port_get_rcu(skb->dev); > team = port->team; > if (!team_port_enabled(port)) { > + if (is_link_local_ether_addr(eth_hdr(skb)->h_dest)) > + /* Please run checkpatch --strict on your submissions > + * link-local packets are mostly useful when stack > + * receives them with the link they arrive on. > + */ > + return RX_HANDLER_PASS; > /* allow exact match delivery for disabled ports */ > res = RX_HANDLER_EXACT; > } else {