Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7d257438-b6cc-8a57-e8e4-b6fd6d0b4cac@gmail.com>
Date:   Thu, 17 Feb 2022 11:03:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v2] tty: serial: atmel: add earlycon support
Content-Language: fr-FR
To:     Michael Walle <michael@walle.cc>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>
Cc:     linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20220217094620.1148571-1-michael@walle.cc>
From:   Richard Genoud <richard.genoud@gmail.com>
In-Reply-To: <20220217094620.1148571-1-michael@walle.cc>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Le 17/02/2022 à 10:46, Michael Walle a écrit :
> Add early console support which relies on the bootloader for the
> initialization of the UART.
> Please note, that the compatibles are taken from at91-usart MFD
> driver.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
Acked-by: Richard Genoud <richard.genoud@gmail.com>

> ---
>   drivers/tty/serial/Kconfig        |  1 +
>   drivers/tty/serial/atmel_serial.c | 24 ++++++++++++++++++++++++
>   2 files changed, 25 insertions(+)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 0e5ccb25bdb1..407a98ec0791 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -139,6 +139,7 @@ config SERIAL_ATMEL_CONSOLE
>   	bool "Support for console on AT91 serial port"
>   	depends on SERIAL_ATMEL=y
>   	select SERIAL_CORE_CONSOLE
> +	select SERIAL_EARLYCON
>   	help
>   	  Say Y here if you wish to use an on-chip UART on a Atmel
>   	  AT91 processor as the system console (the system
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 2d09a89974a2..73d43919898d 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -2673,6 +2673,30 @@ static struct console atmel_console = {
>   	.data		= &atmel_uart,
>   };
>   
> +static void atmel_serial_early_write(struct console *con, const char *s,
> +				     unsigned int n)
> +{
> +	struct earlycon_device *dev = con->data;
> +
> +	uart_console_write(&dev->port, s, n, atmel_console_putchar);
> +}
> +
> +static int __init atmel_early_console_setup(struct earlycon_device *device,
> +					    const char *options)
> +{
> +	if (!device->port.membase)
> +		return -ENODEV;
> +
> +	device->con->write = atmel_serial_early_write;
> +
> +	return 0;
> +}
> +
> +OF_EARLYCON_DECLARE(atmel_serial, "atmel,at91rm9200-usart",
> +		    atmel_early_console_setup);
> +OF_EARLYCON_DECLARE(atmel_serial, "atmel,at91sam9260-usart",
> +		    atmel_early_console_setup);
> +
>   #define ATMEL_CONSOLE_DEVICE	(&atmel_console)
>   
>   #else
Thanks !