Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6b81ba48-af34-71ef-8ee7-9526e7f3b073@linux.ibm.com>
Date:   Wed, 16 Feb 2022 15:25:49 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v10 05/27] ima: Define ima_namespace struct and start
 moving variables into it
Content-Language: en-US
To:     Mimi Zohar <zohar@linux.ibm.com>, linux-integrity@vger.kernel.org
Cc:     serge@hallyn.com, christian.brauner@ubuntu.com,
        containers@lists.linux.dev, dmitry.kasatkin@gmail.com,
        ebiederm@xmission.com, krzysztof.struczynski@huawei.com,
        roberto.sassu@huawei.com, mpeters@redhat.com, lhinds@redhat.com,
        lsturman@redhat.com, puiterwi@redhat.com, jejb@linux.ibm.com,
        jamjoom@us.ibm.com, linux-kernel@vger.kernel.org,
        paul@paul-moore.com, rgb@redhat.com,
        linux-security-module@vger.kernel.org, jmorris@namei.org,
        Christian Brauner <brauner@kernel.org>
References: <20220201203735.164593-1-stefanb@linux.ibm.com>
 <20220201203735.164593-6-stefanb@linux.ibm.com>
 <429010298df589687e1d1a09bac21e302d642c7e.camel@linux.ibm.com>
From:   Stefan Berger <stefanb@linux.ibm.com>
In-Reply-To: <429010298df589687e1d1a09bac21e302d642c7e.camel@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2/16/22 09:41, Mimi Zohar wrote:
> On Tue, 2022-02-01 at 15:37 -0500, Stefan Berger wrote:
>> Define the ima_namespace structure and the ima_namespace variable
>> init_ima_ns for the host's IMA namespace. Implement basic functions for
>> namespacing support.
> Implement the basic functions - ima_ns_init()  and ima_init_namespace()
> - for namespacing support.
>
>> Move variables related to the IMA policy into the ima_namespace. This way
>> the IMA policy of an IMA namespace can be set and displayed using a
>> front-end like securityfs.
>> Implement ima_ns_from_file() to get the IMA namespace via the user
>> namespace of the securityfs superblock that a file belongs to.
> Currently, ima_ns_from_file() doesn't exist in this patch.
Ah, left-over from previous version. Remove.
>
>> To get the current ima_namespace use &init_ima_ns when a function
>> that is related to a policy rule is called.
> In preparation for IMA namespacing, update the existing functions to
> pass the ima_namespace struct.  For now, ...
>
>>
>> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
>> Acked-by: Christian Brauner <brauner@kernel.org>
> After addressing the one inline comment,
Done.
> 	Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>

Thanks.