Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220217004204.99773-1-yang.lee@linux.alibaba.com>
In-Reply-To: <20220217004204.99773-1-yang.lee@linux.alibaba.com>
From:   Marco Elver <elver@google.com>
Date:   Thu, 17 Feb 2022 09:34:06 +0100
Message-ID: <CANpmjNNhbdr6gsQ-za=7mUH2etXqQ3voWncd2mg3fcdiEWWnnQ@mail.gmail.com>
Subject: Re: [PATCH -next] kernel/fork: Remove duplicated include in kernel/fork.c
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     akpm@linux-foundation.org, ebiederm@xmission.com, eb@emlix.com,
        linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>,
        Borislav Petkov <bp@suse.de>, fenghua.yu@intel.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 17 Feb 2022 at 01:42, Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Fix following includecheck warning:
> ./kernel/fork.c: linux/sched/mm.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

This looks like a reasonable fix -- but why is this "To" me? At the
very least you'd have to get the email of the original author that
added that line and perhaps the committer. Cc'd the right people.

Looks like another robot sent the exact same fix:
https://lore.kernel.org/all/20220217015348.1900270-1-deng.changcheng@zte.com.cn/

Too many robots sending the same things will be interesting...

> ---
>  kernel/fork.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 64dbfb9426fd..2bfc74c2d2e3 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -97,7 +97,6 @@
>  #include <linux/scs.h>
>  #include <linux/io_uring.h>
>  #include <linux/bpf.h>
> -#include <linux/sched/mm.h>
>
>  #include <asm/pgalloc.h>
>  #include <linux/uaccess.h>
> --
> 2.20.1.7.g153144c
>