Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
In-Reply-To: <YgyNScQJNVjJpqEc@google.com>
References: <20220211012510.1198155-1-swboyd@chromium.org> <20220211012510.1198155-2-swboyd@chromium.org>
 <YgyNScQJNVjJpqEc@google.com>
From:   Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.10
Date:   Wed, 16 Feb 2022 11:05:11 -0800
Message-ID: <CAE-0n51vdZ=PLXx5Hq+R+F7KwDRPBauN0XjvE_qFtNoHiRWU2w@mail.gmail.com>
Subject: Re: [PATCH v3 1/4] Input: Extract ChromeOS vivaldi physmap show function
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     benjamin.tissoires@redhat.com, Jiri Kosina <jikos@kernel.org>,
        linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
        "Sean O'Brien" <seobrien@chromium.org>,
        Douglas Anderson <dianders@chromium.org>,
        Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Quoting Dmitry Torokhov (2022-02-15 21:36:09)
> On Thu, Feb 10, 2022 at 05:25:07PM -0800, Stephen Boyd wrote:
> >  drivers/input/Kconfig                 |  7 +++++
> >  drivers/input/Makefile                |  1 +
> >  drivers/input/keyboard/Kconfig        |  2 ++
> >  drivers/input/keyboard/atkbd.c        | 22 +++++----------
> >  drivers/input/keyboard/cros_ec_keyb.c | 32 ++++++++--------------
> >  drivers/input/vivaldi-keymap.c        | 39 +++++++++++++++++++++++++++
> >  include/linux/input/vivaldi-keymap.h  | 28 +++++++++++++++++++
>
> Since you called the config INPUT_VIVALDIFMAP I think we should call
> these files vivaldi-fmap.(h|c) as well. They are not really keymaps.

Sure. I used 'f' for 'function'. It could also be INPUT_VIVALDI_PHYSMAP
and vivaldi-physmap.(h|c) if that's more appropriate. I'll resend this
with fmap and we can take it from there.