Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        syzkaller-bugs@googlegroups.com
Cc:     Bart Van Assche <bvanassche@acm.org>,
        syzbot <syzbot+831661966588c802aae9@syzkaller.appspotmail.com>,
        jgg@ziepe.ca, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org, syzkaller-bugs@googlegroups.com,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Tejun Heo <tj@kernel.org>
Subject: Re: [syzbot] possible deadlock in worker_thread
Date:   Thu, 17 Feb 2022 13:27:08 +0100
Message-ID: <4168398.ejJDZkT8p0@leap>
In-Reply-To: <YgnQGZWT/n3VAITX@slm.duckdns.org>
References: <0000000000005975a605d7aef05e@google.com> <2959649d-cfbc-bdf2-02ac-053b8e7af030@I-love.SAKURA.ne.jp> <YgnQGZWT/n3VAITX@slm.duckdns.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On luned=C3=AC 14 febbraio 2022 04:44:25 CET Tejun Heo wrote:
> Hello,
>=20
> On Mon, Feb 14, 2022 at 10:08:00AM +0900, Tetsuo Handa wrote:
> > +	destroy_workqueue(srp_tl_err_wq);
> >=20
> > Then, we can call WARN_ON() if e.g. flush_workqueue() is called on syst=
em-wide workqueues.
>=20
> Yeah, this is the right thing to do. It makes no sense at all to call
> flush_workqueue() on the shared workqueues as the caller has no idea what
> it's gonna end up waiting for. It was on my todo list a long while ago but
> slipped through the crack. If anyone wanna take a stab at it (including
> scrubbing the existing users, of course), please be my guest.
>=20

Just to think and understand... what if the system-wide WQ were allocated a=
s unbound=20
ordered (i.e., as in alloc_ordered_workqueue()) with "max_active" of one?

1) Would it solve the locks dependency problem?
2) Would it introduce performance penalties (bottlenecks)?

Greetings,

=46abio

>
> Thanks.
>=20
> --=20
> tejun
>=20