Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Feb 2022 16:14:23 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org,
        Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
        agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com,
        broonie@kernel.org, robh+dt@kernel.org, quic_plai@quicinc.com,
        bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com,
        srinivas.kandagatla@linaro.org, rohitkr@codeaurora.org,
        linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        swboyd@chromium.org, judyhsiao@chromium.org
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
        Venkata Prasad Potturu <quic_potturu@quicinc.com>
Subject: Re: [RESEND v13 07/10] ASoC: qcom: Add support for codec dma driver
Message-ID: <202202151059.hEuYfkLa-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1644850708-11099-8-git-send-email-quic_srivasam@quicinc.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nAwtlvVmxXfPiRNZRrBOeZDK8kYPpvrCjk4lK3hHsk2FbkQyBXswHqwlqGL/?=
 =?us-ascii?Q?my02pQO8lwvRodPgWFcM8nXn53LULy9U0uE8l7y23PjIBkQRC+331qxk+pd8?=
 =?us-ascii?Q?mpzshDp+Q85YzPx/yXeNGeYMdeo3C6tul8vtyABAEC37des/+Ob27K8FD7v3?=
 =?us-ascii?Q?gh11URduZwvoTKWO1SkxqQMYCnTl+fL3MwUPoZMLMbW43/DJ+k9epZ+SHbzq?=
 =?us-ascii?Q?iVDT9dAIxQCm4nR0/sBDydDphRfsW1rqVTddgEjelZA8fp759rp8pyHCB0Sp?=
 =?us-ascii?Q?SBIpGUjslBTpnOXFea8zyGYoJ7xoQHBRRNhAwtUqQBjBWihHz73lxVXAm1yk?=
 =?us-ascii?Q?viTq1lKE3uhJhz0qqovfuUbq4nGkCW0w18PpLzkslLrdyINbVt2bb32EANVa?=
 =?us-ascii?Q?sZb8fiAZ5H84XvLhN9wkG4b602QlfV5FGyUpKd4lMX0/OaI6QfmjRH34hj3s?=
 =?us-ascii?Q?IECJV1d9tjuCqf8OUi+vLEMoD3QVs1tP5Rmgt+PTJhAbXsv70n7w9t7kA7Zl?=
 =?us-ascii?Q?3GB8U+KJ46WPArtx/NI4uGlAbyPIWRawMgk7wzfzZdmiPkNXt6unXEvfqgoh?=
 =?us-ascii?Q?JJ4SbOHbwChxvyC3vXlJ4k20LuWEzWbIJyQAfMcN9k1aALAp11IFj1+toi4Y?=
 =?us-ascii?Q?M+iHjgmRr/279Pn2t09xt+4chjN5BnnGImgK/EjsXEHCrGzzL+Vz/P23stCD?=
 =?us-ascii?Q?DdHFU1GrAcBKvV9EfMCHZdDGkO5OfACRn+q0OyvJIM4zNhsr3jMf0k69RPzH?=
 =?us-ascii?Q?/dohWcCw8gis4WXJtHKPBEpCznC5XJfSpIxczpLMNzlbWDMFe+xJOljHDD1a?=
 =?us-ascii?Q?HthcItt7j8WXe9VyB7c3wmH7PkeX8PUnI2cRj/vVGci2sEI6VfRqQGPO9tZH?=
 =?us-ascii?Q?No2VsRkgPlv9OJlhSsopnv3akWDKZUnefZmeRwqY62T7SRUaYqNjA8JFQQjv?=
 =?us-ascii?Q?lzDRWKYrHXgkPr89jhEIpcQXqmJHx4ur4V86WsDI1pW2OYTlIHRVOJ+ORrZQ?=
 =?us-ascii?Q?wwRdfWCjurFTQJjnUVTkyDRoIBx3UHijW39wjX78AdWDdZ/H7DfUUU5YOWfo?=
 =?us-ascii?Q?SVsUo/Y4MYow1W3pKp0E/5K7GU2c6ZIEWRJ9TiGdRX5QYSm3XOgzCd7CeEdN?=
 =?us-ascii?Q?C3LKHRvaWLp8gPx9JLzNlAF0T2xFJio2DsJGdZGAlgNsBGsNpLuIPJcGwqXB?=
 =?us-ascii?Q?etCtCIqBV5n/0pt2wDRhAw9c8uk/F8+D1wHEbtjHkHX269Vd56LNEMM+gdFZ?=
 =?us-ascii?Q?l9hsMeAX2zb/NJHeNPX//AuYcYZ9m8Rk9NGAq1Z815LmHje0TkXBIa37Ap1n?=
 =?us-ascii?Q?5Zv9ClnG4p4h3FrOZd4UN9gturzl6tljPVUb0Fy6iImA2Cp0BSCcDuC5AgP7?=
 =?us-ascii?Q?Brg3BIXyhaXR2qTrK5Mqz5XFnz+uz1emN2dh3U0TgkgRSbVYZzfmoSPexqmH?=
 =?us-ascii?Q?EgHd80xLsxk07uTgb0k9501odxsr0lmSIuSdJZTUPCue9hgaZpCKLVeFxrXd?=
 =?us-ascii?Q?ycdw2A5tHYTUN+UHTqvWYeifkIrHkjR5/zMajS9ngzePiQpNwI/f+NzToNyu?=
 =?us-ascii?Q?JFcLQfmVCUH83f7o2OQD/z6Q7q4txOCB+9Djlk9Gx2U8Eq57xFLYdrdUqaon?=
 =?us-ascii?Q?jut9QDvCLGsnnJCPXfr5S9lTuNGDNG4yQWqru9PSIGayoiG+u2RVjXkcwbmX?=
 =?us-ascii?Q?CemFUw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58b05a58-593c-4edc-1864-08d9f2177e76
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 13:14:57.1973
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yPXjENbq6KIb6uDdKJb2GwB3yIFtMLT7uvUf0YhRaOuAc2UqDbYmsHiBPvZ2o4Jb31sYDfkVFd+xwDSdzQSlukxGzUYbXEd0vjOtSvxmpKA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5337
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10260 signatures=675971
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 phishscore=0
 suspectscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202170060
X-Proofpoint-GUID: 3Nk1RqjrH0O0B4q0KhsN-AS6C9PdgzSB
X-Proofpoint-ORIG-GUID: 3Nk1RqjrH0O0B4q0KhsN-AS6C9PdgzSB
X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FAKE_REPLY_C,HEXHASH_WORD,
        RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Srinivasa,

url:    https://github.com/0day-ci/linux/commits/Srinivasa-Rao-Mandadapu/Add-support-for-audio-on-SC7280-based-targets/20220214-230256
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: m68k-randconfig-m031-20220214 (https://download.01.org/0day-ci/archive/20220215/202202151059.hEuYfkLa-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
sound/soc/qcom/lpass-platform.c:1233 lpass_platform_copy() warn: maybe return -EFAULT instead of the bytes remaining?

vim +1233 sound/soc/qcom/lpass-platform.c

e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1210  static int lpass_platform_copy(struct snd_soc_component *component,
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1211  			       struct snd_pcm_substream *substream, int channel,
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1212  			       unsigned long pos, void __user *buf, unsigned long bytes)
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1213  {
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1214  	struct snd_pcm_runtime *rt = substream->runtime;
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1215  	unsigned int dai_id = component->id;
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1216  	int ret = 0;
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1217  
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1218  	void __iomem *dma_buf = rt->dma_area + pos +
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1219  				channel * (rt->dma_bytes / rt->channels);
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1220  
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1221  	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1222  		if (is_cdc_dma_port(dai_id))
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1223  			ret = copy_from_user_toio(dma_buf, buf, bytes);
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1224  		else
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1225  			ret = copy_from_user((void __force *)dma_buf, buf, bytes);
                                                                                      ^^^^^^^^^^^^^^
Positives are treated as success in _soc_component_ret()

e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1226  	} else if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) {
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1227  		if (is_cdc_dma_port(dai_id))
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1228  			ret = copy_to_user_fromio(buf, dma_buf, bytes);
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1229  		else
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1230  			ret = copy_to_user(buf, (void __force *)dma_buf, bytes);

Same

e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1231  	}
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1232  
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14 @1233  	return ret;
e81c7e5d842d2b Srinivasa Rao Mandadapu 2022-02-14  1234  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org