Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Feb 2022 16:23:52 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        kbuild@lists.01.org, Jiri Slaby <jirislaby@kernel.org>,
        lkp@intel.com, kbuild-all@lists.01.org,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Mike Skoog <mskoog@endruntechnologies.com>,
        Mike Korreng <mkorreng@endruntechnologies.com>,
        info@endruntechnologies.com, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] serial: 8250: Add proper clock handling for
 OxSemi PCIe devices
Message-ID: <20220217132352.GC2467@kadam>
References: <202202130027.ZKBCgtm5-lkp@intel.com>
 <alpine.DEB.2.21.2202171009440.34636@angie.orcam.me.uk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.2202171009440.34636@angie.orcam.me.uk>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oi0FxpSHjEkuXoka2pvV6htIsMY9YXE+RGcUmaQB0hPT5pGI6IXGvwSyadtF?=
 =?us-ascii?Q?QCRCtUt7ts1DYWq3ECXi02pDhfrPqpl6JEgivbOLALInSmMlsLPxtBpu681F?=
 =?us-ascii?Q?YWtczq8Kk2oGfTiqk3KnuxSmsZNdjftt/7FvDfBKa66BeRGkeRMAmOv1KEim?=
 =?us-ascii?Q?Pd9Lyby+ZX9nV8amrIf7c7cZ5UoUQir4lwj1YoYfB+wTBYSQu7HzvDGeMit+?=
 =?us-ascii?Q?3KYyhSvdqBl8jFx+3xT/FJ1gVKjefP7JAi1bRZgyADZ5bVEw4mA7Y86k2P2A?=
 =?us-ascii?Q?/vHpUF3tSsLhOo5vRvs7dvqI+I/ZdEe0OdrFrzcmXaeCA4UmAvHSCCW1i6pn?=
 =?us-ascii?Q?UkF49q2DCvTVmp4OMiIXBqwDqQ/v5NAQrzxfw16xbjlxE3v0M0IMUtg4OZeM?=
 =?us-ascii?Q?CBNIPbkwZMrItj4oEsPWXBQU/A8BfESAy1jkC4kqCHJmHnSyL/g9kktKfv1I?=
 =?us-ascii?Q?pFsEXHlYoRwB5Y++VnLQPtmqK6gadPBMwlHhve+5zwCjpwLoO8h6I6Zbg4Ko?=
 =?us-ascii?Q?w0DUf0hddAWXWaWS3TP4Z93WRrHcRr2V7g+B0n5PKl0qYJSu9EQTGQqTJx76?=
 =?us-ascii?Q?MwZz6zZgBSZa+f4JW457/ksCnCzcFG7MW003N+xp49Ry01X/cPhDzyMekUAf?=
 =?us-ascii?Q?Gc6m0u2G4uf+wH7AkTLia1S5zuPwyKNHk+UMYc6ZzgupbLiExAUVFuJ7PkSW?=
 =?us-ascii?Q?pMskDTNX32uo0lfnc41EyeEgZla4sq3D+LPjxrUPodGWmPg13AQqrBVC3+eX?=
 =?us-ascii?Q?AQrHrUEvs2KbaKDGl4RwNWjG7BZEl/ThiaRXpjgZHSaSJV5vF0G++HBABJpN?=
 =?us-ascii?Q?6yA3KSCttfgyEFU0PR2HqBL7fLjIK6t8TO4fhpU1/6DXcHptAeUcQlnf7zrk?=
 =?us-ascii?Q?yj3IXWen4hHeyEVi3q6cyyzpDzymb6A6h5q4Cnd0tbxRdf0lKcZx0/Gi4pKM?=
 =?us-ascii?Q?vxDAujV5SmnwT0T7IiQcDtyipcwVQuvomfb1CNMDQe3dWTGTQAaqIHnCEonN?=
 =?us-ascii?Q?jU9hSUixQwCwM4XKhGb5Y8dQZY1iArslEZw/a7K0c5WGJGzTUkZ6H10+jl8W?=
 =?us-ascii?Q?Ot2fVBBKLBvKF58pnoH23Sf7HWa7S73AvENv6tOeYEonO6K9SOOCqxPwC6fO?=
 =?us-ascii?Q?rYtAg7/Iuz853mXJAc3B03ROjim2dtv0AXhlxSupI3EggVzNbf6+aEJFByJl?=
 =?us-ascii?Q?56xurIuSuMEPXL45Em/Ma3hjo+EkekvK98nte8pxmcWh6mESEZq9aZLmIAh9?=
 =?us-ascii?Q?YX4lElHCivC4b/akwnDhvcWzVZZ6WCspplVK85Jjkon5+hsKpZhByGhUyKL1?=
 =?us-ascii?Q?TUuwcTHpP1lxKVYdsxAtl2fvBsZkPMVkCQwQ3IAZ4dgadNMF52VmqNSJITGE?=
 =?us-ascii?Q?dRZiARF4pEWjBOkjhUNjInCYLaEdpTazVuqlHA87h9A5ad8aT4wTuK88+SUe?=
 =?us-ascii?Q?upYB6pkm7r4Haa9wQS6cyCNZ63UqEIeu702bgKTKKwl5vxzi4O7IoYycuhpo?=
 =?us-ascii?Q?gCft3CulrLpaopD0UyONiEhQhjOPWXTV3NUUFlYjI5BzVViziiA8mpfoIySC?=
 =?us-ascii?Q?jNdvfSgHKq/3sS9+PRuJjwU0D2VRk7wguyQ9lUslRNxGfZ1Xw1Xz7jPP1wA2?=
 =?us-ascii?Q?4sAnjOcAfvbqSs1Q1fLldTgw1V93LWFU+2PkiuJx8Ia76m7g5oVQOQBg9jnj?=
 =?us-ascii?Q?hiKFeQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6f9cf05-1a6d-455b-8b24-08d9f218c9a6
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 13:24:13.8406
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zgVoiocbqkirlaUt0Yl1LLat9c+emHXFIcSFeDNsaR//bskSlZM/RLDz2WyZQkWNY/xaZJZyMxPt3etBLMih8tmB8p9cDZ0wBp26/PmHmb0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5466
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10260 signatures=675971
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202170060
X-Proofpoint-GUID: 69Bm3NKNMVMF4j0S4dhR6BMDR_r0dJci
X-Proofpoint-ORIG-GUID: 69Bm3NKNMVMF4j0S4dhR6BMDR_r0dJci
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 17, 2022 at 12:05:58PM +0000, Maciej W. Rozycki wrote:
> On Thu, 17 Feb 2022, Dan Carpenter wrote:
> 
> > url:    https://github.com/0day-ci/linux/commits/Maciej-W-Rozycki/serial-8250-Fixes-for-Oxford-Semiconductor-950-UARTs/20220212-164255 
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git  tty-testing
> > config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220213/202202130027.ZKBCgtm5-lkp@intel.com/config )
> > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > 
> > New smatch warnings:
> > drivers/tty/serial/8250/8250_pci.c:1171 pci_oxsemi_tornado_get_divisor() error: uninitialized symbol 'tcr'.
> > drivers/tty/serial/8250/8250_pci.c:1172 pci_oxsemi_tornado_get_divisor() error: uninitialized symbol 'quot'.
> > drivers/tty/serial/8250/8250_pci.c:1180 pci_oxsemi_tornado_get_divisor() error: uninitialized symbol 'cpr'.
> 
>  These variables do get assigned to in the first iteration of the loop, 
> because the deviation calculated (`srem') is normalised to the range of 
> [0,spre/2] and that divided by the original divisor (`spre') always works 
> out at within [0,0.5], so `squot' will be within [0,32768].  I guess the 
> static analyser is too dumb to figure it out, so I'll see how to paper it 
> over unless someone has a better proposal.

These emails are a one time email so it's okay to ignore them if you
want.

regards,
dan carpenter