Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp522514pxb; Thu, 17 Feb 2022 08:57:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJxCNsW8v/jRTvDsP/Vo8QHGKL5AdciTxXIOnh+tpElpGIt2ei53wk33vYvKI6BUcBI32jQL X-Received: by 2002:a17:906:2695:b0:6ce:f9c:b476 with SMTP id t21-20020a170906269500b006ce0f9cb476mr3103369ejc.235.1645117021246; Thu, 17 Feb 2022 08:57:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645117021; cv=none; d=google.com; s=arc-20160816; b=N9LcoQ6+UoKad/4xYtSlyvLdR8NDu2FWSLsjOT+vQg4pcb5wDe0Qzw71uz01enVjQf xio1BTFPa8872kV3OJxjF+Ad3h4tlM18+7qS7LSUZWskz8oWe/Sevw+EFS3c6dXgKA99 Mg8/peVUZ/X7Kowj8Qv0Av4zmZ6hWwumrY/u37CFlEShBrd9DsIzqKE3wjgy4qlXulVa jT5AKPBtImKVWIrUkDf18LWNEIu11xhX5KKSwmm3lgY5yJtIV8/BlF9/7gVd3NGpX0yL /HeeX6BJLcSvHUfCrmBRlg3pt3rzghgwx+fzv68pX+aQKd0q+JtaNypWzBkUHV2ICvz0 Egmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=UOZd9jMSsS6Cmq3P1vAhSIV9RLiEmjv6FMsfKKgwGoY=; b=b6eRe1l5d+ECC2i+le6b6TZkPxhP3X5enA0YyQd5s4rJqKpHedNqxlv7bd1yI38juG K26LlJFvdiJVo5mHDbshLGRJeZdsgmcV2covQc5tZBHs5O2mycAvOctvurvJLJ+spXy4 rF3nxS2oXrZiIMfhePfTI/bl0XMsfkLwYnLQmG6rNQL7RsYbNhq+3ineWxESAFm9gYp2 mx4G7PfoUQzx4yjjnDAwuzQzYg1TGOnqbnPWWUZj7utE/N2/98q0Am5JhSbYBsBVZ5Xa 2XlYMsrTx9O2WYCdHS/YLYoWSViqIjDdaUlVbL9bb82G3FB32JBQPtjauwQsC66681OD 4vuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=XiPwUs6i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 27si1973589eja.681.2022.02.17.08.56.37; Thu, 17 Feb 2022 08:57:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=XiPwUs6i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242550AbiBQPeY (ORCPT + 99 others); Thu, 17 Feb 2022 10:34:24 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:49552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231865AbiBQPeW (ORCPT ); Thu, 17 Feb 2022 10:34:22 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B924B2B2C73 for ; Thu, 17 Feb 2022 07:34:07 -0800 (PST) Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 000831EC054E; Thu, 17 Feb 2022 16:34:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1645112042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=UOZd9jMSsS6Cmq3P1vAhSIV9RLiEmjv6FMsfKKgwGoY=; b=XiPwUs6iuCM8+PoJ/FD1ZF/y/BIViUFUSu9usW084bJIULeg23QTsdbUITKWIodTti6bE7 jvAfZenBlRr/NJ8dzLBPYqF7QZljQ73bXRBx3Zn/dMjKFTP536xKy0Plup93PFQP2bVoio E/cB0PV1Ze960QreE8IcO+Q1c5yqQuA= Date: Thu, 17 Feb 2022 16:34:07 +0100 From: Borislav Petkov To: "Kirill A. Shutemov" Cc: Sean Christopherson , Kai Huang , tglx@linutronix.de, mingo@redhat.com, dave.hansen@intel.com, luto@kernel.org, peterz@infradead.org, sathyanarayanan.kuppuswamy@linux.intel.com, aarcange@redhat.com, ak@linux.intel.com, dan.j.williams@intel.com, david@redhat.com, hpa@zytor.com, jgross@suse.com, jmattson@google.com, joro@8bytes.org, jpoimboe@redhat.com, knsathya@kernel.org, pbonzini@redhat.com, sdeep@vmware.com, tony.luck@intel.com, vkuznets@redhat.com, wanpengli@tencent.com, x86@kernel.org, linux-kernel@vger.kernel.org, Brijesh Singh , Tom Lendacky Subject: Re: [PATCHv2 00/29] TDX Guest: TDX core support Message-ID: References: <20220210004831.03dea501738bee060003d040@intel.com> <20220216154809.w27bt6oi3ql4ssip@black.fi.intel.com> <20220217152613.chm4zh7564ddzijq@black.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220217152613.chm4zh7564ddzijq@black.fi.intel.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 17, 2022 at 06:26:13PM +0300, Kirill A. Shutemov wrote: > Okay, so on TDX guest side I would have > > arch/x86/kernel/tdx.c => arch/x86/coco/tdx.c Right, and to answer a previous question: if that file starts becoming too huge and unwieldy then we should split it, by all means. What I don't like is getting a bunch of small files with no good reason why. > arch/x86/kernel/tdcall.S => arch/x86/coco/tdcall.S > arch/x86/kernel/tdxcall.S => arch/x86/virt/tdxcall.S > > The last one going to be used by TDX host as well to define SEMACALL > helper. > > Looks good? Right, that looks neat. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette