Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp524592pxb; Thu, 17 Feb 2022 08:59:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJxM7p9m5Kp/Ffiw6OBRM6UU+YBBR4AgOux7JSL1DGhnEMO202SPwtcP8qtbZV4/ab0M69YN X-Received: by 2002:a17:906:8457:b0:6cf:3c6:dbf3 with SMTP id e23-20020a170906845700b006cf03c6dbf3mr3199831ejy.286.1645117190644; Thu, 17 Feb 2022 08:59:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645117190; cv=none; d=google.com; s=arc-20160816; b=hI13PZQwocVhP6/M1mXobHiYqzEhiEa+IS6zJfVavqvHyeAazX3RR0hXJMD/E+W4KB h0R7iv0Q8kEmLx3J0MOn5pWOfs4W8KNrVZ7FEwdY1jah26+kvYy27J+KtfzU2IM/praU SFMajFtySsZ0YXfrWBbLl1v0aGrArehcGkgxcB1DZuGXhJwrgbg8C+0y0nnqFJyVOxuL asg/cFSUB8OMTAHzq50g00sCVpmMQUE8Xk/hS/GXVcJOK+dJo42IifFlys1wJn31VvwC GVJdZPoT3aSrTfx+c8aICD165IbioTQd2Q9LcqpDWY5kMFoKCVmJKrlfctYKkNUwHYCI lrJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:reply-to:cc:from:to :dkim-signature:date; bh=xig78IbVhEkp/h3Vt76vo9JttYCE5O3eydjvdxHGgXU=; b=F7jiLZ5BMSuErsQYClo3wl9jv1timvzq556q6bGvoMTOcvM/1zEIKSNO3puH4Q3bxE 2zxBm4xW2Mi3Ofp8lGWVzjb9F9QTeX9l5xN8jKIbJ0dwGcYIBZnb1//M99Prs0DYk1vq d8HpCp7fFMiCLUOS55yY9m+8ewubNJOXrmdzTtC+pO76cyCdOVRUd68KkZg3B91n3jFx 7qWwt7ij7Zuqms7Cxe6o2M9OE9Id+1XcplxWYW0kLB+POxfKAECYsfm60wv+0xLdzupc 7C4Uw2U9HGt9XYnNTOKhpo5gZMdh3a3IaUgRtVNl6KAU6aUQsvG8eqEpjBZKUZB0pYh6 VYnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@emersion.fr header.s=protonmail2 header.b=lqOBZMqE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=emersion.fr Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f10si1841701ejl.292.2022.02.17.08.59.26; Thu, 17 Feb 2022 08:59:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@emersion.fr header.s=protonmail2 header.b=lqOBZMqE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=emersion.fr Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242987AbiBQQS7 (ORCPT + 99 others); Thu, 17 Feb 2022 11:18:59 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:54766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239930AbiBQQS7 (ORCPT ); Thu, 17 Feb 2022 11:18:59 -0500 Received: from mail-4317.proton.ch (mail-4317.proton.ch [185.70.43.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F293D26550B; Thu, 17 Feb 2022 08:18:43 -0800 (PST) Date: Thu, 17 Feb 2022 16:18:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail2; t=1645114721; bh=xig78IbVhEkp/h3Vt76vo9JttYCE5O3eydjvdxHGgXU=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=lqOBZMqEfCVq3VumfrDJrT7drykDVqUPX2D3vk364ddWATgj8xPNQrXL7fqBbtGpg c1b43UdLgmNm4g96P5YVN6Jq3Dd1PDCb9Qgl+/q81JHD42yDx5qm1Vl3QnE/P7ysLB wioiqgNVq2+cqYjnFIbcuRcouR9qQl9K6b5z45VxxxpTAuLEiBp+qHvIt5oWyt7NXG dWMUKvOU0bq5rH3P1yjDM2q9ISEdnvS7SOfpt1paw375giCIWg8IbBkyqgx4w8PM+I gV1/rSgl37Z383id/4R+onPCEUP9nj9N34qp2QwhppVkwSk77Ji3jo2VfsUBJ0nPuC rH48B50eaQYXQ== To: Geert Uytterhoeven From: Simon Ser Cc: Thomas Zimmermann , Linux Fbdev development list , David Airlie , Helge Deller , Javier Martinez Canillas , Linux Kernel Mailing List , Linux/m68k , DRI Development Reply-To: Simon Ser Subject: Re: [PATCH 2/8] drm/fb-helper: Add support for DRM_FORMAT_C[124] Message-ID: In-Reply-To: References: <20220215165226.2738568-1-geert@linux-m68k.org> <20220215165226.2738568-3-geert@linux-m68k.org> <4fff0c08-adab-c1d5-4a7e-1513cb2bf7ca@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, February 17th, 2022 at 17:12, Geert Uytterhoeven wrote: > > What is C0? > > A non-existing color-indexed mode with zero colors ;-) > Introduced purely to make a check like in the comment below work. > What we really want to check here is if the mode is color-indexed > or not... Maybe it would be worth introducing a drm_format_info_is_color_indexed function? Would be self-describing when used, and would avoid to miss some places to update when adding new color-indexed formats.